feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Add missing callback for adding signals

Browse Source 
If a signal is added we have to add/update the property.

Task-number: QDS-14449
Change-Id: I8c4071a3fbba7f880d81dd697b15a2649d8acb10
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
This commit is contained in:
Thomas Hartmann
2025-03-14 15:54:17 +01:00
committed by Thomas Hartmann
parent f7831fdad2
commit faf44a6498
5 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qmldesigner/components/connectioneditor/connectionview.cpp
View File

@@ -258,6 +258,13 @@ void ConnectionView::bindingPropertiesChanged(const QList<BindingProperty> &prop
}
}
void ConnectionView::signalDeclarationPropertiesChanged(
const QVector<SignalDeclarationProperty> &propertyList, PropertyChangeFlags /* propertyChange */)
{
for (const SignalDeclarationProperty &property : propertyList)
d->dynamicPropertiesModel.updateItem(property);
}
void ConnectionView::signalHandlerPropertiesChanged(const QVector<SignalHandlerProperty> &propertyList,
AbstractView::PropertyChangeFlags /*propertyChange*/)
{

3
src/plugins/qmldesigner/components/connectioneditor/connectionview.h
View File

@@ -50,6 +50,9 @@ public:
void bindingPropertiesChanged(const QList<BindingProperty>& propertyList, PropertyChangeFlags propertyChange) override;
void signalHandlerPropertiesChanged(const QVector<SignalHandlerProperty>& propertyList, PropertyChangeFlags propertyChange) override;
void signalDeclarationPropertiesChanged(const QVector<SignalDeclarationProperty> &propertyList,
PropertyChangeFlags propertyChange) override;
void selectedNodesChanged(const QList<ModelNode> &selectedNodeList,
const QList<ModelNode> &lastSelectedNodeList) override;

2
src/plugins/qmldesigner/components/connectioneditor/dynamicpropertiesmodel.cpp
View File

@@ -148,7 +148,7 @@ void DynamicPropertiesModel::setCurrent(int internalId, PropertyNameView name)
void DynamicPropertiesModel::updateItem(const AbstractProperty &property)
{
if (!property.isDynamic())
if (!property.isDynamic() && !property.isSignalDeclarationProperty())
return;
if (auto *item = itemForProperty(property)) {

7
src/plugins/qmldesigner/components/propertyeditor/propertyeditorview.cpp
View File

@@ -1092,6 +1092,13 @@ void PropertyEditorView::auxiliaryDataChanged(const ModelNode &node,
m_qmlBackEndForCurrentType->contextObject()->setInsightCategories(data.toStringList());
}
void PropertyEditorView::signalDeclarationPropertiesChanged(
const QVector<SignalDeclarationProperty> &propertyList, PropertyChangeFlags /* propertyChange */)
{
for (const SignalDeclarationProperty &property : propertyList)
m_dynamicPropertiesModel->updateItem(property);
}
void PropertyEditorView::instanceInformationsChanged(const QMultiHash<ModelNode, InformationName> &informationChangedHash)
{
if (noValidSelection())

3
src/plugins/qmldesigner/components/propertyeditor/propertyeditorview.h
View File

@@ -59,6 +59,9 @@ public:
AuxiliaryDataKeyView key,
const QVariant &data) override;
void signalDeclarationPropertiesChanged(const QVector<SignalDeclarationProperty> &propertyList,
PropertyChangeFlags propertyChange) override;
void instanceInformationsChanged(const QMultiHash<ModelNode, InformationName> &informationChangedHash) override;
void nodeIdChanged(const ModelNode& node, const QString& newId, const QString& oldId) override;