feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Pass const values by reference

Browse Source 
Change-Id: I985aced32b95cfe4bc1bbbf7c917dc04b1d94f2d
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Orgad Shaneh
2014-05-05 17:15:20 +03:00
committed by Orgad Shaneh
parent 4cf0cae8bc
commit fb206c14fe
8 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/kitmanager.cpp
View File

@@ -442,7 +442,7 @@ void KitManager::deleteKit(Kit *k)
delete k; delete k;
} }
QString KitManager::uniqueKitName(const Kit *k, const QString name, const QList<Kit *> &allKits) QString KitManager::uniqueKitName(const Kit *k, const QString &name, const QList<Kit *> &allKits)
{ {
QStringList nameList; QStringList nameList;
nameList << QString(); // Disallow empty kit names! nameList << QString(); // Disallow empty kit names!

2
src/plugins/projectexplorer/kitmanager.h
View File

@@ -127,7 +127,7 @@ public:
static void deleteKit(Kit *k); static void deleteKit(Kit *k);
static QString uniqueKitName(const Kit *k, const QString name, const QList<Kit *> &allKits); static QString uniqueKitName(const Kit *k, const QString &name, const QList<Kit *> &allKits);
static bool registerKit(ProjectExplorer::Kit *k); static bool registerKit(ProjectExplorer::Kit *k);
static void deregisterKit(ProjectExplorer::Kit *k); static void deregisterKit(ProjectExplorer::Kit *k);

2
src/plugins/projectexplorer/kitmodel.cpp
View File

@@ -352,7 +352,7 @@ Kit *KitModel::markForAddition(Kit *baseKit)
return k; return k;
} }
QString KitModel::findNameFor(Kit *k, const QString baseName) QString KitModel::findNameFor(Kit *k, const QString &baseName)
{ {
QList<Kit *> kits = kitList(m_root); QList<Kit *> kits = kitList(m_root);
return KitManager::uniqueKitName(k, baseName, kits); return KitManager::uniqueKitName(k, baseName, kits);

2
src/plugins/projectexplorer/kitmodel.h
View File

@@ -86,7 +86,7 @@ public:
void markForRemoval(Kit *k); void markForRemoval(Kit *k);
Kit *markForAddition(Kit *baseKit); Kit *markForAddition(Kit *baseKit);
QString findNameFor(Kit *k, const QString baseName); QString findNameFor(Kit *k, const QString &baseName);
signals: signals:
void kitStateChanged(); void kitStateChanged();

2
src/plugins/projectexplorer/projectfilewizardextension.cpp
View File

@@ -480,7 +480,7 @@ static inline void getProjectChoicesAndToolTips(QStringList *projectChoicesParam
*projectActionParam = projectAction; *projectActionParam = projectAction;
} }
void ProjectFileWizardExtension::initProjectChoices(const QList<GeneratedFile> generatedFiles, const QVariantMap &extraValues) void ProjectFileWizardExtension::initProjectChoices(const QList<GeneratedFile> &generatedFiles, const QVariantMap &extraValues)
{ {
QStringList projectChoices; QStringList projectChoices;
QStringList projectToolTips; QStringList projectToolTips;

2
src/plugins/projectexplorer/projectfilewizardextension.h
View File

@@ -59,7 +59,7 @@ public slots:
void initializeVersionControlChoices(); void initializeVersionControlChoices();
private: private:
void initProjectChoices(const QList<Core::GeneratedFile> generatedFiles, const QVariantMap &extraValues); void initProjectChoices(const QList<Core::GeneratedFile> &generatedFiles, const QVariantMap &extraValues);
bool processProject(const QList<Core::GeneratedFile> &files, bool processProject(const QList<Core::GeneratedFile> &files,
bool *removeOpenProjectAttribute, QString *errorMessage); bool *removeOpenProjectAttribute, QString *errorMessage);
bool processVersionControl(const QList<Core::GeneratedFile> &files, QString *errorMessage); bool processVersionControl(const QList<Core::GeneratedFile> &files, QString *errorMessage);

2
src/plugins/projectexplorer/taskmodel.cpp
View File

@@ -438,7 +438,7 @@ void TaskFilterModel::handleRowsAboutToBeRemoved(const QModelIndex &index, int f
endRemoveRows(); endRemoveRows();
} }
void TaskFilterModel::handleDataChanged(QModelIndex top, QModelIndex bottom) void TaskFilterModel::handleDataChanged(const QModelIndex &top, const QModelIndex &bottom)
{ {
const QPair<int, int> range = findFilteredRange(top.row(), bottom.row(), m_mapping); const QPair<int, int> range = findFilteredRange(top.row(), bottom.row(), m_mapping);
if (range.first > range.second) if (range.first > range.second)

2
src/plugins/projectexplorer/taskmodel.h
View File

@@ -164,7 +164,7 @@ public:
private slots: private slots:
void handleNewRows(const QModelIndex &index, int first, int last); void handleNewRows(const QModelIndex &index, int first, int last);
void handleRowsAboutToBeRemoved(const QModelIndex &index, int first, int last); void handleRowsAboutToBeRemoved(const QModelIndex &index, int first, int last);
void handleDataChanged(QModelIndex,QModelIndex bottom); void handleDataChanged(const QModelIndex &top, const QModelIndex &bottom);
void handleReset(); void handleReset();
private: private: