feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix Krazy warnings about values or keys iteration in Editor/C++.

Browse Source 
Change-Id: I46ff779bae6d7bba105bc2019228ba38b95dc352
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
This commit is contained in:
Friedemann Kleint
2013-03-14 14:18:02 +01:00
parent 14e35b5dc4
commit fb9ded85d7
2 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/texteditor/snippets/snippetscollection.cpp
View File

@@ -319,11 +319,15 @@ bool SnippetsCollection::synchronize(QString *errorString)
}
Utils::FileSaver saver(m_userSnippetsPath + m_userSnippetsFile);
if (!saver.hasError()) {
typedef QHash<QString, int>::ConstIterator GroupIndexByIdConstIt;
QXmlStreamWriter writer(saver.file());
writer.setAutoFormatting(true);
writer.writeStartDocument();
writer.writeStartElement(kSnippets);
foreach (const QString &groupId, m_groupIndexById.keys()) {
const GroupIndexByIdConstIt cend = m_groupIndexById.constEnd();
for (GroupIndexByIdConstIt it = m_groupIndexById.constBegin(); it != cend; ++it ) {
const QString &groupId = it.key();
const int size = m_snippets.at(groupIndex(groupId)).size();
for (int i = 0; i < size; ++i) {
const Snippet &current = snippet(i, groupId);