feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TaskTree: Unify done / errorOccurred signals

Browse Source 
Get rid of TaskTree::errorOccurred signal. Provide additional
DoneResult arg for done signal.

Task-number: QTCREATORBUG-29834
Change-Id: I31a3a0701a14246b01f65303a1295f014c855ecf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2023-11-03 15:53:01 +01:00
parent d2500dc77b
commit fbe359308d
21 changed files with 79 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/coreplugin/plugininstallwizard.cpp
View File

@@ -262,12 +262,10 @@ public:
};
m_taskTree.reset(new TaskTree(root));
const auto onEnd = [this] {
connect(m_taskTree.get(), &TaskTree::done, this, [this] {
m_cancelButton->setVisible(false);
m_taskTree.release()->deleteLater();
};
connect(m_taskTree.get(), &TaskTree::done, this, onEnd);
connect(m_taskTree.get(), &TaskTree::errorOccurred, this, onEnd);
});
m_cancelButton->setVisible(true);
m_taskTree->start();