feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Do not clear the reader needlessly

Browse Source 
If the reader is not of the expected type or incompatible with
the new parameters, then it will get changed anyway. So do not
force a reset of the reader.

Change-Id: I5ab8770797d39488e6a530e93431e344b1c7f7e6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
Tobias Hunger
2019-10-08 12:42:41 +02:00
parent 2c82422932
commit fc4459a585
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/builddirmanager.cpp
View File

@@ -257,8 +257,6 @@ void BuildDirManager::setParametersAndRequestParse(const BuildDirParameters &par
} }
QTC_ASSERT(parameters.isValid(), return ); QTC_ASSERT(parameters.isValid(), return );
stopParsingAndClearState();
m_parameters = parameters; m_parameters = parameters;
m_parameters.workDirectory = workDirectory(parameters); m_parameters.workDirectory = workDirectory(parameters);
updateReparseParameters(reparseParameters); updateReparseParameters(reparseParameters);