feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Move TestParseResultPtr to the common place and don't repeat
this typedef.

Change-Id: Id8523b7898965ea9bfccb8a1bdc6a8ea23f090ed
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Jarek Kobus
2024-02-01 16:33:44 +01:00
parent 66f6b4c32e
commit fc605d7a76
4 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/autotest/itestparser.h
View File

@@ -40,8 +40,6 @@ public:
int column = 0; int column = 0;
}; };
using TestParseResultPtr = QSharedPointer<TestParseResult>;
class ITestParser class ITestParser
{ {
public: public:

2
src/plugins/autotest/testtreeitem.h
View File

@@ -29,6 +29,8 @@ class ITestConfiguration;
class TestParseResult; class TestParseResult;
enum class TestRunMode; enum class TestRunMode;
using TestParseResultPtr = std::shared_ptr<TestParseResult>;
class ITestTreeItem : public Utils::TypedTreeItem<ITestTreeItem> class ITestTreeItem : public Utils::TypedTreeItem<ITestTreeItem>
{ {
public: public:

2
src/plugins/autotest/testtreemodel.cpp
View File

@@ -685,7 +685,7 @@ void TestTreeModel::onParseResultsReady(const QList<TestParseResultPtr> &results
QTC_ASSERT(framework, return); QTC_ASSERT(framework, return);
TestTreeItem *rootNode = framework->rootNode(); TestTreeItem *rootNode = framework->rootNode();
QTC_ASSERT(rootNode, return); QTC_ASSERT(rootNode, return);
handleParseResult(result.data(), rootNode); handleParseResult(result.get(), rootNode);
} }
} }

1
src/plugins/autotest/testtreemodel.h
View File

@@ -22,7 +22,6 @@ class TestCodeParser;
} // namespace Internal } // namespace Internal
class TestParseResult; class TestParseResult;
using TestParseResultPtr = QSharedPointer<TestParseResult>;
class AUTOTESTSHARED_EXPORT TestTreeModel : public Utils::TreeModel<Utils::TreeItem, ITestTreeItem> class AUTOTESTSHARED_EXPORT TestTreeModel : public Utils::TreeModel<Utils::TreeItem, ITestTreeItem>
{ {