feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Consolidate creation of KitAspect's "Manage..."

Browse Source 
Change-Id: I001a21f41bcd5ff0614bdf98893b56137c06546f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2023-08-22 10:25:30 +02:00
parent 04eea22c5f
commit fc7c11fb65
10 changed files with 41 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/python/pythonkitaspect.cpp
View File

@@ -27,6 +27,8 @@ public:
PythonKitAspectImpl(Kit *kit, const KitAspectFactory *kitInfo)
: KitAspect(kit, kitInfo)
{
setManagingPage(Constants::C_PYTHONOPTIONS_PAGE_ID);
m_comboBox = createSubWidget<QComboBox>();
m_comboBox->setSizePolicy(QSizePolicy::Ignored, m_comboBox->sizePolicy().verticalPolicy());
@@ -38,13 +40,10 @@ public:
PythonKitAspect::setPython(m_kit, m_comboBox->currentData().toString());
});
m_manageButton = createManageButton(Constants::C_PYTHONOPTIONS_PAGE_ID);
}
void makeReadOnly() override
{
m_manageButton->setEnabled(false);
m_comboBox->setEnabled(false);
}
@@ -71,13 +70,11 @@ protected:
{
addMutableAction(m_comboBox);
parent.addItem(m_comboBox);
parent.addItem(m_manageButton);
}
private:
Guard m_ignoreChanges;
QComboBox *m_comboBox = nullptr;
QWidget *m_manageButton = nullptr;
};
class PythonKitAspectFactory : public KitAspectFactory