feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Normalize some state handling

Browse Source 
Remove some now-unusual connection to RunControl::finished
and use a finished() callback in the ToolRunner implementation
instead.

Change-Id: Ieddf05a2258d9a300ac50a739d77d9cfaee10ca6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2017-05-04 08:11:04 +02:00
parent 0e5fdb7fe3
commit fcdc9342b5
5 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/debugger/debuggerruncontrol.cpp
View File

@@ -538,9 +538,6 @@ void DebuggerRunTool::setRunParameters(const DebuggerRunParameters &rp, QString
}
m_engine->setRunTool(this);
connect(runControl(), &RunControl::finished,
this, &DebuggerRunTool::handleFinished);
}
DebuggerRunTool::~DebuggerRunTool()
@@ -554,11 +551,9 @@ DebuggerRunTool::~DebuggerRunTool()
}
}
void DebuggerRunTool::handleFinished()
void DebuggerRunTool::onFinished()
{
appendMessage(tr("Debugging has finished") + '\n', NormalMessageFormat);
if (m_engine)
m_engine->handleFinished();
runControlFinished(m_engine);
}