feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppTools: Do not wait for QFuture in ~BuiltinEditorDocumentProcessor()

Browse Source 
This seems safe, as the arguments to the async function that the future
results from are values and shared pointers, so there does not appear to
be a need for this object to stay around while it finishes.

Fixes: QTCREATORBUG-25121
Change-Id: Ib498551856942bf7c3d05c3013e12ad6d90fd762
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2021-01-13 14:23:25 +01:00
parent 206e9f95fb
commit fd22787a69
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/cpptools/builtineditordocumentprocessor.cpp
View File

@@ -202,7 +202,6 @@ BuiltinEditorDocumentProcessor::BuiltinEditorDocumentProcessor(
BuiltinEditorDocumentProcessor::~BuiltinEditorDocumentProcessor() BuiltinEditorDocumentProcessor::~BuiltinEditorDocumentProcessor()
{ {
m_parserFuture.cancel(); m_parserFuture.cancel();
m_parserFuture.waitForFinished();
} }
void BuiltinEditorDocumentProcessor::runImpl( void BuiltinEditorDocumentProcessor::runImpl(