Remove Core::Id

Moved to Utils in 4.13, and the compatibility typedef is ugly.
Remove it now.

Change-Id: I0d80165b427448eaf7ee6cc1c0a6a34a85b7083b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/coreplugin/CMakeLists.txt

@@ -85,7 +85,6 @@ add_qtc_plugin(Core
     helpmanager.cpp helpmanager.h helpmanager_implementation.h
     icontext.cpp icontext.h
     icore.cpp icore.h
-    id.cpp id.h
     idocument.cpp idocument.h
     idocumentfactory.cpp idocumentfactory.h
     ifilewizardextension.h

src/plugins/coreplugin/coreplugin.pro

@@ -20,7 +20,6 @@ SOURCES += corejsextensions.cpp \
     fancytabwidget.cpp \
     generalsettings.cpp \
     themechooser.cpp \
-    id.cpp \
     icontext.cpp \
     jsexpander.cpp \
     messagemanager.cpp \
@@ -124,7 +123,6 @@ HEADERS += corejsextensions.h \
     fancytabwidget.h \
     generalsettings.h \
     themechooser.h \
-    id.h \
     jsexpander.h \
     messagemanager.h \
     messageoutputwindow.h \

src/plugins/coreplugin/coreplugin.qbs

@@ -92,8 +92,6 @@ Project {
                 "icontext.h",
                 "icore.cpp",
                 "icore.h",
-                "id.cpp",
-                "id.h",
                 "idocument.cpp",
                 "idocument.h",
                 "idocumentfactory.cpp",

src/plugins/coreplugin/id.cpp

@@ -1,32 +0,0 @@
-/****************************************************************************
-**
-** Copyright (C) 2020 The Qt Company Ltd.
-** Contact: https://www.qt.io/licensing/
-**
-** This file is part of Qt Creator.
-**
-** Commercial License Usage
-** Licensees holding valid commercial Qt licenses may use this file in
-** accordance with the commercial license agreement provided with the
-** Software or, alternatively, in accordance with the terms contained in
-** a written agreement between you and The Qt Company. For licensing terms
-** and conditions see https://www.qt.io/terms-conditions. For further
-** information use the contact form at https://www.qt.io/contact-us.
-**
-** GNU General Public License Usage
-** Alternatively, this file may be used under the terms of the GNU
-** General Public License version 3 as published by the Free Software
-** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
-** included in the packaging of this file. Please review the following
-** information to ensure the GNU General Public License requirements will
-** be met: https://www.gnu.org/licenses/gpl-3.0.html.
-**
-****************************************************************************/
-
-#include "id.h"
-
-/*!
-    \typedef Core::Id
-
-    Use Utils::Id instead.
-*/

src/plugins/coreplugin/id.h

@@ -1,34 +0,0 @@
-/****************************************************************************
-**
-** Copyright (C) 2020 The Qt Company Ltd.
-** Contact: https://www.qt.io/licensing/
-**
-** This file is part of Qt Creator.
-**
-** Commercial License Usage
-** Licensees holding valid commercial Qt licenses may use this file in
-** accordance with the commercial license agreement provided with the
-** Software or, alternatively, in accordance with the terms contained in
-** a written agreement between you and The Qt Company. For licensing terms
-** and conditions see https://www.qt.io/terms-conditions. For further
-** information use the contact form at https://www.qt.io/contact-us.
-**
-** GNU General Public License Usage
-** Alternatively, this file may be used under the terms of the GNU
-** General Public License version 3 as published by the Free Software
-** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
-** included in the packaging of this file. Please review the following
-** information to ensure the GNU General Public License requirements will
-** be met: https://www.gnu.org/licenses/gpl-3.0.html.
-**
-****************************************************************************/
-
-#pragma once
-
-#include <utils/id.h>
-
-namespace Core {
-
-using Id = Utils::Id;
-
-} // Core

tests/unit/unittest/CMakeLists.txt

@@ -428,7 +428,6 @@ extend_qtc_test(unittest
   DEFINES CORE_STATIC_LIBRARY
   SOURCES
     coreicons.cpp coreicons.h
-    id.h
     find/ifindfilter.cpp find/ifindfilter.h
     locator/ilocatorfilter.cpp locator/ilocatorfilter.h
 )