diff --git a/src/plugins/qt4projectmanager/qt-s60/qt-s60.pri b/src/plugins/qt4projectmanager/qt-s60/qt-s60.pri index 5f1fb95de6c..9d451e43727 100644 --- a/src/plugins/qt4projectmanager/qt-s60/qt-s60.pri +++ b/src/plugins/qt4projectmanager/qt-s60/qt-s60.pri @@ -70,7 +70,6 @@ HEADERS += $$PWD/s60manager.h \ FORMS += $$PWD/s60createpackagestep.ui \ $$PWD/s60certificatedetailsdialog.ui \ - $$PWD/rvcttoolchainconfigwidget.ui \ $$PWD/s60publishingbuildsettingspageovi.ui \ $$PWD/s60publishingresultspageovi.ui \ $$PWD/s60publishingsissettingspageovi.ui diff --git a/src/plugins/qt4projectmanager/qt-s60/rvcttoolchain.cpp b/src/plugins/qt4projectmanager/qt-s60/rvcttoolchain.cpp index 541d721dc71..a6530d4d09a 100644 --- a/src/plugins/qt4projectmanager/qt-s60/rvcttoolchain.cpp +++ b/src/plugins/qt4projectmanager/qt-s60/rvcttoolchain.cpp @@ -30,7 +30,6 @@ #include "rvcttoolchain.h" #include "rvctparser.h" -#include "ui_rvcttoolchainconfigwidget.h" #include "qt4projectmanager/qt4projectmanagerconstants.h" #include @@ -38,24 +37,30 @@ #include #include #include +#include #include +#include #include #include -#include +#include #include +#include +#include #include +#include +#include namespace Qt4ProjectManager { namespace Internal { #if defined Q_OS_WIN -static const char *const RVCT_BINARY = "armcc.exe"; +static const char RVCT_BINARY[] = "armcc.exe"; #else -static const char *const RVCT_BINARY = "armcc"; +static const char RVCT_BINARY[] = "armcc"; #endif -static const char *const RVCT_LICENSE_KEY = "ARMLMD_LICENSE_FILE"; +static const char RVCT_LICENSE_KEY[] = "ARMLMD_LICENSE_FILE"; static const char rvctPathKeyC[] = "Qt4ProjectManager.RvctToolChain.CompilerPath"; static const char rvctEnvironmentKeyC[] = "Qt4ProjectManager.RvctToolChain.Environment"; @@ -348,29 +353,45 @@ QString RvctToolChain::varName(const QString &postFix) const // RvctToolChainConfigWidget // ========================================================================== +class RvctToolChainConfigWidgetUi +{ +public: + QComboBox *versionComboBox; + Utils::PathChooser *compilerPath; + QTableView *environmentView; +}; + RvctToolChainConfigWidget::RvctToolChainConfigWidget(RvctToolChain *tc) : ProjectExplorer::ToolChainConfigWidget(tc), - m_ui(new Ui::RvctToolChainConfigWidget()), + m_ui(new RvctToolChainConfigWidgetUi), m_model(new Utils::EnvironmentModel(this)) { - m_ui->setupUi(this); + m_ui->versionComboBox = new QComboBox(this); + m_ui->versionComboBox->addItem(tr("Version 5")); + m_ui->versionComboBox->addItem(tr("Version 6")); + m_ui->compilerPath = new Utils::PathChooser(this); + m_ui->environmentView = new QTableView(this); + + m_mainLayout->addRow(tr("ARM &version:"), m_ui->versionComboBox); + m_mainLayout->addRow(tr("&Compiler path:"), m_ui->compilerPath); + m_mainLayout->addRow(tr("Environment Variables"), m_ui->environmentView); - m_ui->environmentView->setModel(m_model); m_ui->environmentView->horizontalHeader()->setResizeMode(QHeaderView::ResizeToContents); m_ui->environmentView->horizontalHeader()->setStretchLastSection(true); - m_ui->environmentView->setGridStyle(Qt::NoPen); m_ui->environmentView->horizontalHeader()->setHighlightSections(false); + m_ui->environmentView->setGridStyle(Qt::NoPen); m_ui->environmentView->verticalHeader()->hide(); QFontMetrics fm(font()); - m_ui->environmentView->verticalHeader()->setDefaultSectionSize(qMax(static_cast(fm.height() * 1.2), fm.height() + 4)); + m_ui->environmentView->verticalHeader()->setDefaultSectionSize(qMax(int(fm.height() * 1.2), fm.height() + 4)); + m_ui->environmentView->setModel(m_model); - connect(m_model, SIGNAL(userChangesChanged()), this, SLOT(emitDirty())); + connect(m_model, SIGNAL(userChangesChanged()), this, SIGNAL(dirty())); m_ui->compilerPath->setExpectedKind(Utils::PathChooser::ExistingCommand); m_ui->compilerPath->setFileName(tc->compilerCommand()); - connect(m_ui->compilerPath, SIGNAL(changed(QString)), this, SLOT(emitDirty())); + connect(m_ui->compilerPath, SIGNAL(changed(QString)), this, SIGNAL(dirty())); m_ui->versionComboBox->setCurrentIndex(static_cast(tc->armVersion())); - connect(m_ui->versionComboBox, SIGNAL(currentIndexChanged(int)), this, SLOT(emitDirty())); + connect(m_ui->versionComboBox, SIGNAL(currentIndexChanged(int)), this, SIGNAL(dirty())); setFromToolChain(); } diff --git a/src/plugins/qt4projectmanager/qt-s60/rvcttoolchain.h b/src/plugins/qt4projectmanager/qt-s60/rvcttoolchain.h index cdd8b475059..362d58b22e3 100644 --- a/src/plugins/qt4projectmanager/qt-s60/rvcttoolchain.h +++ b/src/plugins/qt4projectmanager/qt-s60/rvcttoolchain.h @@ -43,10 +43,7 @@ class PathChooser; namespace Qt4ProjectManager { namespace Internal { -namespace Ui { -class RvctToolChainConfigWidget; -} - +class RvctToolChainConfigWidgetUi; class RvctToolChainFactory; // ========================================================================== @@ -149,7 +146,7 @@ private: void setFromToolChain(); QList environmentChanges() const; - Ui::RvctToolChainConfigWidget *m_ui; + RvctToolChainConfigWidgetUi *m_ui; Utils::EnvironmentModel *m_model; }; diff --git a/src/plugins/qt4projectmanager/qt-s60/rvcttoolchainconfigwidget.ui b/src/plugins/qt4projectmanager/qt-s60/rvcttoolchainconfigwidget.ui deleted file mode 100644 index 0e06f1d3955..00000000000 --- a/src/plugins/qt4projectmanager/qt-s60/rvcttoolchainconfigwidget.ui +++ /dev/null @@ -1,97 +0,0 @@ - - - Qt4ProjectManager::Internal::RvctToolChainConfigWidget - - - - 0 - 0 - 399 - 318 - - - - Form - - - - - - - - ARM &version: - - - versionComboBox - - - - - - - - Version 5 - - - - - Version 6 - - - - - - - - &Compiler path: - - - compilerPath - - - - - - - - - - - - Qt::Vertical - - - QSizePolicy::Fixed - - - - 0 - 3 - - - - - - - - Environment Variables - - - - - - - - - - - - - Utils::PathChooser - QWidget -
utils/pathchooser.h
-
-
- - -
diff --git a/src/plugins/qt4projectmanager/qt4projectmanager.qbs b/src/plugins/qt4projectmanager/qt4projectmanager.qbs index ea91d90f7c0..836195851a0 100644 --- a/src/plugins/qt4projectmanager/qt4projectmanager.qbs +++ b/src/plugins/qt4projectmanager/qt4projectmanager.qbs @@ -139,7 +139,6 @@ QtcPlugin { "qt-desktop/simulatorqtversion.h", "qt-desktop/simulatorqtversionfactory.cpp", "qt-desktop/simulatorqtversionfactory.h", - "qt-s60/rvcttoolchainconfigwidget.ui", "qt-s60/abldparser.cpp", "qt-s60/abldparser.h", "qt-s60/certificatepathchooser.cpp",