feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditorActionHandler: Use configuration instead of inheritance

Browse Source 
Avoids creating subclasses just for implementing a single method.

Change-Id: I813a0a20eaba8fefa004b74f92d48a9a9c4bfcc1
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2017-05-08 13:52:34 +02:00
parent 2684254fad
commit fd7edcb826
3 changed files with 19 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/texteditor/texteditoractionhandler.h
View File

@@ -29,6 +29,8 @@
#include <QObject>
#include <functional>
namespace Core {
class Id;
class IEditor;
@@ -54,13 +56,13 @@ public:
FollowSymbolUnderCursor = 8,
JumpToFileUnderCursor = 16
};
using TextEditorWidgetResolver = std::function<TextEditorWidget *(Core::IEditor *)>;
explicit TextEditorActionHandler(QObject *parent, Core::Id editorId, Core::Id contextId,
uint optionalActions = None);
~TextEditorActionHandler();
protected:
virtual TextEditorWidget *resolveTextEditorWidget(Core::IEditor *editor) const;
void setTextEditorWidgetResolver(const TextEditorWidgetResolver &resolver);
private:
friend class Internal::TextEditorActionHandlerPrivate;