From fd8fcd29a1d70a10864fc5a6e5c6dc5cf1c96ecf Mon Sep 17 00:00:00 2001
From: hjk <hjk121@nokiamail.com>
Date: Wed, 15 Oct 2014 15:14:24 +0200
Subject: [PATCH] Lay down current namespace practices

Change-Id: I16e6e292097f3f7289bda8d9c6c23b6827ee54b9
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
---
 doc/api/coding-style.qdoc | 64 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/doc/api/coding-style.qdoc b/doc/api/coding-style.qdoc
index fedd9a06808..c384d7b4e1d 100644
--- a/doc/api/coding-style.qdoc
+++ b/doc/api/coding-style.qdoc
@@ -569,6 +569,70 @@
         \code
         namespace MyPlugin { class MyClass; }
         \endcode
+
+        \li Do not use using-directives in header files.
+
+        \li Do not rely on using-directives when defining classes and
+        functions, instead define it in a properly named declarative region.
+
+        \li Do not rely on using-directives when accessing global functions.
+
+        \li In other cases, you are encouraged to use using-directives,
+        as they help you avoid cluttering the code. Prefer putting all
+        using-directives near the top of the file, after all includes.
+
+        \code
+        [in foo.cpp]
+        ...
+        #include "foos.h"
+        ...
+        #include <utils/filename.h>
+        ...
+        using namespace Utils;
+
+        namespace Foo {
+        namespace Internal {
+
+        void SomeThing::bar()
+        {
+            FileName f;              // or Utils::FileName f
+            ...
+        }
+        ...
+        } // namespace Internal      // or only // Internal
+        } // namespace Foo           // or only // Foo
+
+        -NOT-
+
+        [in foo.h]
+        ...
+        using namespace Utils;       // Wrong: no using-directives in headers
+
+        class SomeThing
+        {
+            ...
+        };
+
+        -NOT-
+
+        [in foo.cpp]
+        ...
+        using namespace Utils;
+
+        #include "bar.h"             // Wrong: #include after using-directive
+
+        -NOT-
+
+        [in foo.cpp]
+        ...
+        using namepace Foo;
+
+        void SomeThing::bar()        // Wrong if Something is in namespace Foo
+        {
+            ...
+        }
+        \endcode
+
     \endlist
 
     \section1 Patterns and Practices