From fdb0ba038942acad8127edb882445c1bacda88c5 Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Wed, 24 Jan 2024 12:40:50 +0100
Subject: [PATCH] CppProjectUpdater: Simplify done handler

Call it only on success.

Change-Id: I8a9bea3768c1bd1d1f68ec852519b6e6dda1a2e9
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
---
 src/plugins/cppeditor/cppprojectupdater.cpp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/plugins/cppeditor/cppprojectupdater.cpp b/src/plugins/cppeditor/cppprojectupdater.cpp
index 9b9cbf5c9b3..e93d0f94c28 100644
--- a/src/plugins/cppeditor/cppprojectupdater.cpp
+++ b/src/plugins/cppeditor/cppprojectupdater.cpp
@@ -66,9 +66,7 @@ void CppProjectUpdater::update(const ProjectUpdateInfo &projectUpdateInfo,
             tasks.append(compiler->compileFileItem());
     }
 
-    const auto onDone = [this, storage, compilers](DoneWith result) {
-        if (result != DoneWith::Success)
-            return;
+    const auto onDone = [this, storage, compilers] {
         QList<ExtraCompiler *> extraCompilers;
         QSet<FilePath> compilerFiles;
         for (const QPointer<ExtraCompiler> &compiler : compilers) {
@@ -85,7 +83,7 @@ void CppProjectUpdater::update(const ProjectUpdateInfo &projectUpdateInfo,
     const Group root {
         storage,
         Group(tasks),
-        onGroupDone(onDone)
+        onGroupDone(onDone, CallDoneIf::Success)
     };
     m_taskTreeRunner.start(root, [](TaskTree *taskTree) {
         auto progress = new Core::TaskProgress(taskTree);