From fe24faa12b92c75e819d8b20e4c5699a10dd14ea Mon Sep 17 00:00:00 2001
From: Marcus Tillmanns <marcus.tillmanns@qt.io>
Date: Thu, 28 Sep 2023 11:59:05 +0200
Subject: [PATCH] Fix issues found by coverity

Change-Id: I1eba9b800fed419bea4169ec6d6042c2f99b505d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
---
 src/libs/utils/aspects.cpp                            | 10 +++++-----
 src/plugins/compilerexplorer/compilerexplorereditor.h |  4 ----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/src/libs/utils/aspects.cpp b/src/libs/utils/aspects.cpp
index 13e8d0df49f..27628402423 100644
--- a/src/libs/utils/aspects.cpp
+++ b/src/libs/utils/aspects.cpp
@@ -595,7 +595,7 @@ void BaseAspect::registerSubWidget(QWidget *widget)
 
 void BaseAspect::forEachSubWidget(const std::function<void(QWidget *)> &func)
 {
-    for (auto w : d->m_subWidgets)
+    for (const QPointer<QWidget> &w : d->m_subWidgets)
         func(w);
 }
 
@@ -3074,7 +3074,7 @@ QVariantList AspectList::toList(bool v) const
     QVariantList list;
     const auto &items = v ? d->volatileItems : d->items;
 
-    for (const auto &item : items) {
+    for (const std::shared_ptr<BaseAspect> &item : items) {
         Utils::Store childStore;
         if (v)
             item->volatileToMap(childStore);
@@ -3157,12 +3157,12 @@ void AspectList::clear()
     if (undoStack()) {
         undoStack()->beginMacro("Clear");
 
-        for (auto item : volatileItems())
+        for (const std::shared_ptr<BaseAspect> &item : volatileItems())
             undoStack()->push(new RemoveItemCommand(this, item));
 
         undoStack()->endMacro();
     } else {
-        for (auto item : volatileItems())
+        for (const std::shared_ptr<BaseAspect> &item : volatileItems())
             actualRemoveItem(item);
     }
 }
@@ -3198,7 +3198,7 @@ bool AspectList::isDirty()
     if (d->items != d->volatileItems)
         return true;
 
-    for (const auto &item : d->volatileItems) {
+    for (const std::shared_ptr<BaseAspect> &item : d->volatileItems) {
         if (item->isDirty())
             return true;
     }
diff --git a/src/plugins/compilerexplorer/compilerexplorereditor.h b/src/plugins/compilerexplorer/compilerexplorereditor.h
index c2dcfdaebe4..c404ea40552 100644
--- a/src/plugins/compilerexplorer/compilerexplorereditor.h
+++ b/src/plugins/compilerexplorer/compilerexplorereditor.h
@@ -207,14 +207,10 @@ protected:
     QVariantMap windowStateCallback();
 
 private:
-    QSplitter *m_mainSplitter;
-    int m_compilerCount{0};
     QSharedPointer<JsonSettingsDocument> m_document;
     QUndoStack *m_undoStack;
     TextEditor::TextEditorActionHandler &m_actionHandler;
 
-    Core::IContext *m_context;
-
     QList<QDockWidget *> m_compilerWidgets;
     QList<QDockWidget *> m_sourceWidgets;
 };