feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Remove QmlProfilerClientManager::serverRecordingChanged

Browse Source 
It doesn't do anything useful. Also the qmlDataReady member is
write-only and can be removed.

Change-Id: I667b05611cfc5960eb2fd73254a7b3c621ae98a3
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
This commit is contained in:
Ulf Hermann
2015-09-11 13:05:04 +02:00
parent fdbed834fa
commit fe2d9e2a3b
2 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp
View File

@@ -64,8 +64,6 @@ public:
QString sysroot; QString sysroot;
quint32 flushInterval; quint32 flushInterval;
bool qmlDataReady;
QmlProfilerModelManager *modelManager; QmlProfilerModelManager *modelManager;
}; };
@@ -78,7 +76,6 @@ QmlProfilerClientManager::QmlProfilerClientManager(QObject *parent) :
d->connection = 0; d->connection = 0;
d->connectionAttempts = 0; d->connectionAttempts = 0;
d->qmlDataReady = false;
d->flushInterval = 0; d->flushInterval = 0;
d->modelManager = 0; d->modelManager = 0;
@@ -310,11 +307,8 @@ void QmlProfilerClientManager::retryMessageBoxFinished(int result)
void QmlProfilerClientManager::qmlComplete(qint64 maximumTime) void QmlProfilerClientManager::qmlComplete(qint64 maximumTime)
{ {
d->modelManager->traceTime()->increaseEndTime(maximumTime); d->modelManager->traceTime()->increaseEndTime(maximumTime);
d->qmlDataReady = true;
if (d->modelManager) if (d->modelManager)
d->modelManager->acquiringDone(); d->modelManager->acquiringDone();
// once complete is sent, reset the flags
d->qmlDataReady = false;
} }
void QmlProfilerClientManager::stopClientsRecording() void QmlProfilerClientManager::stopClientsRecording()
@@ -330,8 +324,6 @@ void QmlProfilerClientManager::registerProfilerStateManager( QmlProfilerStateMan
this, SLOT(profilerStateChanged())); this, SLOT(profilerStateChanged()));
disconnect(d->profilerState, SIGNAL(clientRecordingChanged()), disconnect(d->profilerState, SIGNAL(clientRecordingChanged()),
this, SLOT(clientRecordingChanged())); this, SLOT(clientRecordingChanged()));
disconnect(d->profilerState, SIGNAL(serverRecordingChanged()),
this, SLOT(serverRecordingChanged()));
} }
d->profilerState = profilerState; d->profilerState = profilerState;
@@ -342,8 +334,6 @@ void QmlProfilerClientManager::registerProfilerStateManager( QmlProfilerStateMan
this, SLOT(profilerStateChanged())); this, SLOT(profilerStateChanged()));
connect(d->profilerState, SIGNAL(clientRecordingChanged()), connect(d->profilerState, SIGNAL(clientRecordingChanged()),
this, SLOT(clientRecordingChanged())); this, SLOT(clientRecordingChanged()));
connect(d->profilerState, SIGNAL(serverRecordingChanged()),
this, SLOT(serverRecordingChanged()));
} }
} }
@@ -371,11 +361,5 @@ void QmlProfilerClientManager::clientRecordingChanged()
} }
} }
void QmlProfilerClientManager::serverRecordingChanged()
{
if (d->profilerState->serverRecording())
d->qmlDataReady = false;
}
} // namespace Internal } // namespace Internal
} // namespace QmlProfiler } // namespace QmlProfiler

1
src/plugins/qmlprofiler/qmlprofilerclientmanager.h
View File

@@ -79,7 +79,6 @@ private slots:
void profilerStateChanged(); void profilerStateChanged();
void clientRecordingChanged(); void clientRecordingChanged();
void serverRecordingChanged();
private: private:
class QmlProfilerClientManagerPrivate; class QmlProfilerClientManagerPrivate;