feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Drop QProcess specific parameters from QtcProcess::finished()

Browse Source 
Mid-term plan is to concentrate on use of QtcProcess::result()
instead which is a bit more system-agnostic.

There's quite a bit of potential for downstream cleanup by
re-using QtcProcess::exitMessage() now.

Change-Id: I3806b3f5933d96e64b7cfb18cc6c52823fddcbcd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2021-05-28 14:48:25 +02:00
parent 9426ce99a1
commit fe7d6f0def
31 changed files with 72 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cppcheck/cppcheckrunner.cpp
View File

@@ -170,7 +170,7 @@ void CppcheckRunner::handleStarted()
m_tool.startParsing();
}
void CppcheckRunner::handleFinished(int)
void CppcheckRunner::handleFinished()
{
if (m_process->error() != QProcess::FailedToStart) {
m_tool.finishParsing();

2
src/plugins/cppcheck/cppcheckrunner.h
View File

@@ -61,7 +61,7 @@ private:
void readOutput();
void readError();
void handleStarted();
void handleFinished(int);
void handleFinished();
CppcheckTool &m_tool;
Utils::QtcProcess *m_process = nullptr;