From feb3d6a864638cb9e95c43df13aa21f5f2c0314a Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Wed, 3 Aug 2016 08:49:53 +0300 Subject: [PATCH] ProjectExplorer: Load images lazily in mini target selector Change-Id: Ifbaca8dc6d94327ab30c1ddbe99246131e06f3c0 Reviewed-by: Alessandro Portale --- src/plugins/projectexplorer/miniprojecttargetselector.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/plugins/projectexplorer/miniprojecttargetselector.cpp b/src/plugins/projectexplorer/miniprojecttargetselector.cpp index 0622f60b9c4..e069eb67221 100644 --- a/src/plugins/projectexplorer/miniprojecttargetselector.cpp +++ b/src/plugins/projectexplorer/miniprojecttargetselector.cpp @@ -110,7 +110,6 @@ private: void paint(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index) const; - mutable QImage selectionGradient; ListWidget *m_listWidget; }; @@ -128,9 +127,6 @@ void TargetSelectorDelegate::paint(QPainter *painter, painter->save(); painter->setClipping(false); - if (selectionGradient.isNull()) - selectionGradient.load(QLatin1String(":/projectexplorer/images/targetpanel_gradient.png")); - if (option.state & QStyle::State_Selected) { const QColor color = (option.state & QStyle::State_HasFocus) ? option.palette.highlight().color() : @@ -139,6 +135,7 @@ void TargetSelectorDelegate::paint(QPainter *painter, painter->fillRect(option.rect, color); } else { painter->fillRect(option.rect, color.darker(140)); + static const QImage selectionGradient(":/projectexplorer/images/targetpanel_gradient.png"); StyleHelper::drawCornerImage(selectionGradient, painter, option.rect.adjusted(0, 0, 0, -1), 5, 5, 5, 5); const QRectF borderRect = QRectF(option.rect).adjusted(0.5, 0.5, -0.5, -0.5); painter->setPen(QColor(255, 255, 255, 60)); @@ -1605,7 +1602,7 @@ void MiniProjectTargetSelector::paintEvent(QPaintEvent *) if (creatorTheme()->flag(Theme::DrawTargetSelectorBottom)) { // draw thicker border on the bottom QRect bottomRect(0, rect().height() - 8, rect().width(), 8); - static QImage image(QLatin1String(":/projectexplorer/images/targetpanel_bottom.png")); + static const QImage image(":/projectexplorer/images/targetpanel_bottom.png"); StyleHelper::drawCornerImage(image, &painter, bottomRect, 1, 1, 1, 1); } }