feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Help: Do not try to open folder

Browse Source 
We end up using a system editor or the question which tool
to use when trying to open a fake help item.

Fixes: QTCREATORBUG-31178
Change-Id: I21b7c98a7ea0c2b442ad8b733477c725f96e80e1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Christian Stenger
2024-07-03 14:27:24 +02:00
parent a1f1451ed1
commit fedb43a5f0
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/help/helpviewer.cpp
View File

@@ -136,6 +136,9 @@ bool HelpViewer::launchWithExternalApp(const QUrl &url)
// QHelpEngineCore::findFile returns a valid url even though the file does not exist // QHelpEngineCore::findFile returns a valid url even though the file does not exist
if (resolvedUrl.scheme() == "about" && resolvedUrl.path() == "blank") if (resolvedUrl.scheme() == "about" && resolvedUrl.path() == "blank")
return false; return false;
// fake items have no associated file - they are kind of virtual folders
if (resolvedUrl.fileName().isEmpty())
return false;
const QString& path = resolvedUrl.path(); const QString& path = resolvedUrl.path();
if (!canOpenPage(path)) { if (!canOpenPage(path)) {