TextEditor: Remove QuickFixAssistProvider

It did not contain any functionality beyond the base IAssistProvider
anymore.

Change-Id: I0198b3d629f81be8c994ffed3904b5f12ee7f9b9
Reviewed-by: David Schulz <david.schulz@qt.io>

src/plugins/cppeditor/cppeditordocument.cpp

@@ -133,7 +133,7 @@ TextEditor::CompletionAssistProvider *CppEditorDocument::completionAssistProvide
     return m_completionAssistProvider;
 }
 
-TextEditor::QuickFixAssistProvider *CppEditorDocument::quickFixAssistProvider() const
+TextEditor::IAssistProvider *CppEditorDocument::quickFixAssistProvider() const
 {
     return CppEditorPlugin::instance()->quickFixProvider();
 }

src/plugins/cppeditor/cppeditordocument.h

@@ -53,7 +53,7 @@ public:
 
     bool isObjCEnabled() const;
     TextEditor::CompletionAssistProvider *completionAssistProvider() const override;
-    TextEditor::QuickFixAssistProvider *quickFixAssistProvider() const override;
+    TextEditor::IAssistProvider *quickFixAssistProvider() const override;
 
     void recalculateSemanticInfoDetached();
     CppTools::SemanticInfo recalculateSemanticInfo(); // TODO: Remove me

src/plugins/cppeditor/cppquickfixassistant.h

@@ -26,8 +26,9 @@
 #pragma once
 
 #include <cpptools/cppsemanticinfo.h>
+
 #include <texteditor/codeassist/assistinterface.h>
-#include <texteditor/codeassist/quickfixassistprovider.h>
+#include <texteditor/codeassist/iassistprovider.h>
 #include <texteditor/codeassist/quickfixassistprocessor.h>
 
 #include <cplusplus/LookupContext.h>
@@ -68,10 +69,10 @@ private:
     QList<CPlusPlus::AST *> m_path;
 };
 
-class CppQuickFixAssistProvider : public TextEditor::QuickFixAssistProvider
+class CppQuickFixAssistProvider : public TextEditor::IAssistProvider
 {
 public:
-    CppQuickFixAssistProvider(QObject *parent = 0) : TextEditor::QuickFixAssistProvider(parent) {}
+    CppQuickFixAssistProvider(QObject *parent = nullptr) : TextEditor::IAssistProvider(parent) {}
     IAssistProvider::RunType runType() const override;
     TextEditor::IAssistProcessor *createProcessor() const override;
 };

src/plugins/qmljseditor/qmljseditordocument.cpp

@@ -621,7 +621,7 @@ Internal::QmlOutlineModel *QmlJSEditorDocument::outlineModel() const
     return d->m_outlineModel;
 }
 
-TextEditor::QuickFixAssistProvider *QmlJSEditorDocument::quickFixAssistProvider() const
+TextEditor::IAssistProvider *QmlJSEditorDocument::quickFixAssistProvider() const
 {
     return Internal::QmlJSEditorPlugin::instance()->quickFixAssistProvider();
 }

src/plugins/qmljseditor/qmljseditordocument.h

@@ -52,7 +52,7 @@ public:
     void setDiagnosticRanges(const QVector<QTextLayout::FormatRange> &ranges);
     Internal::QmlOutlineModel *outlineModel() const;
 
-    TextEditor::QuickFixAssistProvider *quickFixAssistProvider() const override;
+    TextEditor::IAssistProvider *quickFixAssistProvider() const override;
 
 signals:
     void updateCodeWarnings(QmlJS::Document::Ptr doc);

src/plugins/qmljseditor/qmljsquickfixassist.cpp

@@ -67,7 +67,7 @@ QmlJSRefactoringFilePtr QmlJSQuickFixAssistInterface::currentFile() const
 // QmlJSQuickFixAssistProvider
 // ---------------------------
 QmlJSQuickFixAssistProvider::QmlJSQuickFixAssistProvider(QObject *parent)
-    : TextEditor::QuickFixAssistProvider(parent)
+    : IAssistProvider(parent)
 {}
 
 QmlJSQuickFixAssistProvider::~QmlJSQuickFixAssistProvider()

src/plugins/qmljseditor/qmljsquickfixassist.h

@@ -30,7 +30,7 @@
 #include <qmljstools/qmljsrefactoringchanges.h>
 
 #include <texteditor/codeassist/assistinterface.h>
-#include <texteditor/codeassist/quickfixassistprovider.h>
+#include <texteditor/codeassist/iassistprovider.h>
 #include <texteditor/codeassist/quickfixassistprocessor.h>
 
 
@@ -52,10 +52,10 @@ private:
 };
 
 
-class QmlJSQuickFixAssistProvider : public TextEditor::QuickFixAssistProvider
+class QmlJSQuickFixAssistProvider : public TextEditor::IAssistProvider
 {
 public:
-    QmlJSQuickFixAssistProvider(QObject *parent = 0);
+    QmlJSQuickFixAssistProvider(QObject *parent = nullptr);
     ~QmlJSQuickFixAssistProvider();
 
     IAssistProvider::RunType runType() const override;

src/plugins/texteditor/codeassist/codeassistant.cpp

@@ -25,7 +25,6 @@
 
 #include "codeassistant.h"
 #include "completionassistprovider.h"
-#include "quickfixassistprovider.h"
 #include "iassistprocessor.h"
 #include "textdocument.h"
 #include "iassistproposal.h"

src/plugins/texteditor/codeassist/quickfixassistprocessor.cpp

@@ -24,7 +24,6 @@
 ****************************************************************************/
 
 #include "quickfixassistprocessor.h"
-#include "quickfixassistprovider.h"
 #include "assistinterface.h"
 #include "genericproposalmodel.h"
 #include "assistproposalitem.h"

src/plugins/texteditor/codeassist/quickfixassistprovider.cpp

@@ -1,35 +0,0 @@
-/****************************************************************************
-**
-** Copyright (C) 2016 The Qt Company Ltd.
-** Contact: https://www.qt.io/licensing/
-**
-** This file is part of Qt Creator.
-**
-** Commercial License Usage
-** Licensees holding valid commercial Qt licenses may use this file in
-** accordance with the commercial license agreement provided with the
-** Software or, alternatively, in accordance with the terms contained in
-** a written agreement between you and The Qt Company. For licensing terms
-** and conditions see https://www.qt.io/terms-conditions. For further
-** information use the contact form at https://www.qt.io/contact-us.
-**
-** GNU General Public License Usage
-** Alternatively, this file may be used under the terms of the GNU
-** General Public License version 3 as published by the Free Software
-** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
-** included in the packaging of this file. Please review the following
-** information to ensure the GNU General Public License requirements will
-** be met: https://www.gnu.org/licenses/gpl-3.0.html.
-**
-****************************************************************************/
-
-#include "quickfixassistprovider.h"
-
-using namespace TextEditor;
-
-QuickFixAssistProvider::QuickFixAssistProvider(QObject *parent)
-    : IAssistProvider(parent)
-{}
-
-QuickFixAssistProvider::~QuickFixAssistProvider()
-{}

src/plugins/texteditor/codeassist/quickfixassistprovider.h

@@ -1,41 +0,0 @@
-/****************************************************************************
-**
-** Copyright (C) 2016 The Qt Company Ltd.
-** Contact: https://www.qt.io/licensing/
-**
-** This file is part of Qt Creator.
-**
-** Commercial License Usage
-** Licensees holding valid commercial Qt licenses may use this file in
-** accordance with the commercial license agreement provided with the
-** Software or, alternatively, in accordance with the terms contained in
-** a written agreement between you and The Qt Company. For licensing terms
-** and conditions see https://www.qt.io/terms-conditions. For further
-** information use the contact form at https://www.qt.io/contact-us.
-**
-** GNU General Public License Usage
-** Alternatively, this file may be used under the terms of the GNU
-** General Public License version 3 as published by the Free Software
-** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
-** included in the packaging of this file. Please review the following
-** information to ensure the GNU General Public License requirements will
-** be met: https://www.gnu.org/licenses/gpl-3.0.html.
-**
-****************************************************************************/
-
-#pragma once
-
-#include "iassistprovider.h"
-
-namespace TextEditor {
-
-class TEXTEDITOR_EXPORT QuickFixAssistProvider : public IAssistProvider
-{
-    Q_OBJECT
-
-public:
-    QuickFixAssistProvider(QObject *parent = 0);
-    ~QuickFixAssistProvider();
-};
-
-} // TextEditor

src/plugins/texteditor/textdocument.cpp

@@ -392,9 +392,9 @@ CompletionAssistProvider *TextDocument::completionAssistProvider() const
     return d->m_completionAssistProvider;
 }
 
-QuickFixAssistProvider *TextDocument::quickFixAssistProvider() const
+IAssistProvider *TextDocument::quickFixAssistProvider() const
 {
-    return 0;
+    return nullptr;
 }
 
 void TextDocument::applyFontSettings()

src/plugins/texteditor/textdocument.h

@@ -48,7 +48,7 @@ class CompletionAssistProvider;
 class ExtraEncodingSettings;
 class FontSettings;
 class Indenter;
-class QuickFixAssistProvider;
+class IAssistProvider;
 class StorageSettings;
 class SyntaxHighlighter;
 class TabSettings;
@@ -136,7 +136,7 @@ public:
 
     void setCompletionAssistProvider(CompletionAssistProvider *provider);
     virtual CompletionAssistProvider *completionAssistProvider() const;
-    virtual QuickFixAssistProvider *quickFixAssistProvider() const;
+    virtual IAssistProvider *quickFixAssistProvider() const;
 
     void setTabSettings(const TextEditor::TabSettings &tabSettings);
     void setFontSettings(const TextEditor::FontSettings &fontSettings);

src/plugins/texteditor/texteditor.pro

@@ -80,7 +80,6 @@ SOURCES += texteditorplugin.cpp \
     codeassist/runner.cpp \
     codeassist/completionassistprovider.cpp \
     codeassist/genericproposalmodel.cpp \
-    codeassist/quickfixassistprovider.cpp \
     codeassist/quickfixassistprocessor.cpp \
     codeassist/genericproposal.cpp \
     codeassist/genericproposalwidget.cpp \
@@ -191,7 +190,6 @@ HEADERS += texteditorplugin.h \
     codeassist/assistproposaliteminterface.h \
     codeassist/completionassistprovider.h \
     codeassist/genericproposalmodel.h \
-    codeassist/quickfixassistprovider.h \
     codeassist/quickfixassistprocessor.h \
     codeassist/genericproposal.h \
     codeassist/genericproposalwidget.h \

src/plugins/texteditor/texteditor.qbs

@@ -186,8 +186,6 @@ Project {
                 "keywordscompletionassist.h",
                 "quickfixassistprocessor.cpp",
                 "quickfixassistprocessor.h",
-                "quickfixassistprovider.cpp",
-                "quickfixassistprovider.h",
                 "runner.cpp",
                 "runner.h",
                 "textdocumentmanipulator.cpp",