From ff0ff1a3b52b8b4bb15b077a33e1e0d9b6af4ab4 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Wed, 26 May 2021 17:15:53 +0200 Subject: [PATCH] Don't derive ProFileReader from QObject There are no real reasons for doing this. In addition, QmakeBuildSystem::destroyProFileReader() destroys it in different thread that it was created in - for QObject it could be a potential issue. Change-Id: Ib958ea0f4ef3a9aeee92045eb430183207afe6c9 Reviewed-by: Eike Ziller Reviewed-by: Qt CI Bot --- src/plugins/qtsupport/profilereader.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plugins/qtsupport/profilereader.h b/src/plugins/qtsupport/profilereader.h index cf7da8c8763..e16572be3c2 100644 --- a/src/plugins/qtsupport/profilereader.h +++ b/src/plugins/qtsupport/profilereader.h @@ -61,10 +61,8 @@ private: QStringList m_messages; }; -class QTSUPPORT_EXPORT ProFileReader : public QObject, public ProMessageHandler, public QMakeParser, public ProFileEvaluator +class QTSUPPORT_EXPORT ProFileReader : public ProMessageHandler, public QMakeParser, public ProFileEvaluator { - Q_OBJECT - public: ProFileReader(QMakeGlobals *option, QMakeVfs *vfs); ~ProFileReader() override;