From ff25fa6ca741670005dcfe971144f1d2b494ed4f Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Tue, 23 Jan 2024 08:44:54 +0100
Subject: [PATCH] CppEditor: Make some settings accesses more direct

Change-Id: Ib7768462bcf50b5321323b27f0d2837444160162
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
---
 .../cppeditor/abstracteditorsupport.cpp       |  5 ++--
 src/plugins/cppeditor/cppeditorplugin.cpp     | 25 ++++---------------
 src/plugins/cppeditor/cppeditorplugin.h       |  3 ---
 3 files changed, 7 insertions(+), 26 deletions(-)

diff --git a/src/plugins/cppeditor/abstracteditorsupport.cpp b/src/plugins/cppeditor/abstracteditorsupport.cpp
index ff43c5895aa..a61146ee87e 100644
--- a/src/plugins/cppeditor/abstracteditorsupport.cpp
+++ b/src/plugins/cppeditor/abstracteditorsupport.cpp
@@ -3,7 +3,6 @@
 
 #include "abstracteditorsupport.h"
 
-#include "cppeditorplugin.h"
 #include "cppeditortr.h"
 #include "cppfilesettingspage.h"
 #include "cppmodelmanager.h"
@@ -42,7 +41,7 @@ void AbstractEditorSupport::notifyAboutUpdatedContents() const
 QString AbstractEditorSupport::licenseTemplate(ProjectExplorer::Project *project,
                                                const FilePath &filePath, const QString &className)
 {
-    const QString license = Internal::CppEditorPlugin::licenseTemplate(project);
+    const QString license = Internal::cppFileSettingsForProject(project).licenseTemplate();
     Utils::MacroExpander expander;
     expander.registerVariable("Cpp:License:FileName", Tr::tr("The file name."),
                               [filePath] { return filePath.fileName(); });
@@ -54,7 +53,7 @@ QString AbstractEditorSupport::licenseTemplate(ProjectExplorer::Project *project
 
 bool AbstractEditorSupport::usePragmaOnce(ProjectExplorer::Project *project)
 {
-    return Internal::CppEditorPlugin::usePragmaOnce(project);
+    return Internal::cppFileSettingsForProject(project).headerPragmaOnce;
 }
 
 } // CppEditor
diff --git a/src/plugins/cppeditor/cppeditorplugin.cpp b/src/plugins/cppeditor/cppeditorplugin.cpp
index 80b25fef8c2..fee996bacc7 100644
--- a/src/plugins/cppeditor/cppeditorplugin.cpp
+++ b/src/plugins/cppeditor/cppeditorplugin.cpp
@@ -477,15 +477,15 @@ void CppEditorPlugin::registerVariables()
 
     // TODO: Per-project variants of these three?
     expander->registerVariable("Cpp:LicenseTemplate",
-                               Tr::tr("The license template."),
-                               []() { return CppEditorPlugin::licenseTemplate(nullptr); });
+        Tr::tr("The license template."),
+        [] { return globalCppFileSettings().licenseTemplate(); });
     expander->registerFileVariables("Cpp:LicenseTemplatePath",
-                                    Tr::tr("The configured path to the license template"),
-                                    []() { return CppEditorPlugin::licenseTemplatePath(nullptr); });
+        Tr::tr("The configured path to the license template"),
+        [] { return FilePath::fromUserInput(globalCppFileSettings().licenseTemplatePath); });
     expander->registerVariable(
         "Cpp:PragmaOnce",
         Tr::tr("Insert \"#pragma once\" instead of \"#ifndef\" include guards into header file"),
-        [] { return usePragmaOnce(nullptr) ? QString("true") : QString(); });
+        [] { return globalCppFileSettings().headerPragmaOnce ? QString("true") : QString(); });
 }
 
 void CppEditorPlugin::registerTests()
@@ -599,21 +599,6 @@ void CppEditorPlugin::clearHeaderSourceCache()
     m_headerSourceMapping.clear();
 }
 
-FilePath CppEditorPlugin::licenseTemplatePath(Project *project)
-{
-    return FilePath::fromString(cppFileSettingsForProject(project).licenseTemplatePath);
-}
-
-QString CppEditorPlugin::licenseTemplate(Project *project)
-{
-    return cppFileSettingsForProject(project).licenseTemplate();
-}
-
-bool CppEditorPlugin::usePragmaOnce(Project *project)
-{
-    return cppFileSettingsForProject(project).headerPragmaOnce;
-}
-
 static FilePaths findFilesInProject(const QStringList &names, const Project *project,
                                       FileType fileType)
 {
diff --git a/src/plugins/cppeditor/cppeditorplugin.h b/src/plugins/cppeditor/cppeditorplugin.h
index 297a73ae24b..d208a5cd1ab 100644
--- a/src/plugins/cppeditor/cppeditorplugin.h
+++ b/src/plugins/cppeditor/cppeditorplugin.h
@@ -24,9 +24,6 @@ public:
     static CppEditorPlugin *instance();
 
     static void clearHeaderSourceCache();
-    static Utils::FilePath licenseTemplatePath(ProjectExplorer::Project *project);
-    static QString licenseTemplate(ProjectExplorer::Project *project);
-    static bool usePragmaOnce(ProjectExplorer::Project *project);
 
     void openDeclarationDefinitionInNextSplit();
     void openTypeHierarchy();