feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Only enable error on warnings as you compile with tests or in debug

Browse Source 
There is no advantage for an enduser to get errors on warnings because
he cannot do much about it. It is still nudging the developers to fix
the warnings.

Task-number: QTCREATORBUG-29238
Change-Id: If9f73f2766d686b119cd264ee7b3c3c9afa2c70d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2023-06-02 09:38:40 +02:00
parent 898a7cbc88
commit ff2a14917f
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/qmldesigner/CMakeLists.txt
View File

@@ -31,7 +31,7 @@ add_qtc_library(QmlDesignerUtils STATIC
) )
extend_qtc_library(QmlDesignerUtils extend_qtc_library(QmlDesignerUtils
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )
@@ -84,7 +84,7 @@ endif()
extend_qtc_library(QmlDesignerCore extend_qtc_library(QmlDesignerCore
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )
@@ -484,7 +484,7 @@ add_qtc_plugin(QmlDesigner
) )
extend_qtc_plugin(QmlDesigner extend_qtc_plugin(QmlDesigner
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )
@@ -1085,7 +1085,7 @@ add_qtc_plugin(assetexporterplugin
) )
extend_qtc_plugin(assetexporterplugin extend_qtc_plugin(assetexporterplugin
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )
@@ -1118,7 +1118,7 @@ add_qtc_plugin(componentsplugin
) )
extend_qtc_plugin(componentsplugin extend_qtc_plugin(componentsplugin
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )
@@ -1143,7 +1143,7 @@ add_qtc_plugin(qmlpreviewplugin
) )
extend_qtc_plugin(qmlpreviewplugin extend_qtc_plugin(qmlpreviewplugin
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )
@@ -1165,7 +1165,7 @@ add_qtc_plugin(qtquickplugin
) )
extend_qtc_plugin(qtquickplugin extend_qtc_plugin(qtquickplugin
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )

2
src/plugins/qmldesignerbase/CMakeLists.txt
View File

@@ -12,7 +12,7 @@ add_qtc_plugin(QmlDesignerBase
) )
extend_qtc_plugin(QmlDesignerBase extend_qtc_plugin(QmlDesignerBase
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )

2
src/plugins/qmlprojectmanager/CMakeLists.txt
View File

@@ -25,7 +25,7 @@ add_qtc_plugin(QmlProjectManager
) )
extend_qtc_plugin(QmlProjectManager extend_qtc_plugin(QmlProjectManager
CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR CONDITION (NOT DISABLE_COMPILE_WARNING_AS_ERROR) AND ($<CONFIG:Debug> OR WITH_TESTS)
PROPERTIES COMPILE_WARNING_AS_ERROR ON PROPERTIES COMPILE_WARNING_AS_ERROR ON
) )