feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Make IOutputPane behaviour more granular

Browse Source 
The commit looks big, but it's mostly trivial. Also any build/run
related popups are now "flashes" if the current mode has no placeholder.

Task-number: QTCREATORBUG-7875
Change-Id: I3af40557f7af01798f905c0d1829423c80058cb6
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
Daniel Teske
2012-09-13 15:50:06 +02:00
parent aafac06a24
commit ff6e9333ad
19 changed files with 69 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/vcsbase/vcsbaseoutputwindow.cpp
View File

@@ -370,23 +370,22 @@ void VcsBaseOutputWindow::appendSilently(const QString &text)
void VcsBaseOutputWindow::append(const QString &text)
{
appendSilently(text);
// Pop up without focus
if (!d->plainTextEdit()->isVisible())
popup(false);
popup(Core::IOutputPane::NoModeSwitch);
}
void VcsBaseOutputWindow::appendError(const QString &text)
{
d->plainTextEdit()->appendError(text);
if (!d->plainTextEdit()->isVisible())
popup(false); // Pop up without focus
popup(Core::IOutputPane::NoModeSwitch);
}
void VcsBaseOutputWindow::appendWarning(const QString &text)
{
d->plainTextEdit()->appendWarning(text);
if (!d->plainTextEdit()->isVisible())
popup(false); // Pop up without focus
popup(Core::IOutputPane::NoModeSwitch);
}
// Helper to format arguments for log windows hiding common password
@@ -441,7 +440,7 @@ void VcsBaseOutputWindow::appendData(const QByteArray &data)
{
appendDataSilently(data);
if (!d->plainTextEdit()->isVisible())
popup(false); // Pop up without focus
popup(Core::IOutputPane::NoModeSwitch);
}
void VcsBaseOutputWindow::appendDataSilently(const QByteArray &data)