From ffd58c577a273cd650180e527a2abcff4d8c7df2 Mon Sep 17 00:00:00 2001
From: Francois Ferrand <thetypz@gmail.com>
Date: Fri, 16 Mar 2012 14:06:09 +0100
Subject: [PATCH] Preprocessor: Handle variadic arguments (__VA_ARGS__).

Change-Id: I69aa6c5e01ea97a4413f77f20ebbb4d4beb971aa
Reviewed-by: Erik Verbruggen <erik.verbruggen@nokia.com>
---
 src/libs/cplusplus/Macro.cpp                  |  3 +-
 src/libs/cplusplus/pp-engine.cpp              |  8 ++++-
 .../preprocessor/tst_preprocessor.cpp         | 36 +++++++++++++++++++
 3 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/src/libs/cplusplus/Macro.cpp b/src/libs/cplusplus/Macro.cpp
index 802f126e2a5..7020f5f01c0 100644
--- a/src/libs/cplusplus/Macro.cpp
+++ b/src/libs/cplusplus/Macro.cpp
@@ -78,7 +78,8 @@ QString Macro::decoratedName() const
                 text += QLatin1String(", ");
             else
                 first = false;
-            text += QString::fromUtf8(formal.constData(), formal.size());
+            if (formal != "__VA_ARGS__")
+                text += QString::fromUtf8(formal.constData(), formal.size());
         }
         if (f._variadic)
             text += QLatin1String("...");
diff --git a/src/libs/cplusplus/pp-engine.cpp b/src/libs/cplusplus/pp-engine.cpp
index af27609f846..dbdd5e0b6b8 100644
--- a/src/libs/cplusplus/pp-engine.cpp
+++ b/src/libs/cplusplus/pp-engine.cpp
@@ -1178,18 +1178,22 @@ void Preprocessor::processDefine(TokenIterator firstToken, TokenIterator lastTok
     macro.setLength(endOfToken(lastToken[- 1]) - startOfToken(*firstToken));
     ++tk; // skip T_IDENTIFIER
 
+    bool hasIdentifier = false;
     if (tk->is(T_LPAREN) && ! tk->f.whitespace) {
         // a function-like macro definition
         macro.setFunctionLike(true);
 
         ++tk; // skip T_LPAREN
         if (tk->is(T_IDENTIFIER)) {
+            hasIdentifier = true;
             macro.addFormal(tokenText(*tk));
             ++tk; // skip T_IDENTIFIER
             while (tk->is(T_COMMA)) {
                 ++tk;// skip T_COMMA
-                if (tk->isNot(T_IDENTIFIER))
+                if (tk->isNot(T_IDENTIFIER)) {
+                    hasIdentifier = false;
                     break;
+                }
                 macro.addFormal(tokenText(*tk));
                 ++tk; // skip T_IDENTIFIER
             }
@@ -1197,6 +1201,8 @@ void Preprocessor::processDefine(TokenIterator firstToken, TokenIterator lastTok
 
         if (tk->is(T_DOT_DOT_DOT)) {
             macro.setVariadic(true);
+            if (!hasIdentifier)
+                macro.addFormal("__VA_ARGS__");
             ++tk; // skip T_DOT_DOT_DOT
         }
 
diff --git a/tests/auto/cplusplus/preprocessor/tst_preprocessor.cpp b/tests/auto/cplusplus/preprocessor/tst_preprocessor.cpp
index 6d08d46f5a1..1c5d6fd320f 100644
--- a/tests/auto/cplusplus/preprocessor/tst_preprocessor.cpp
+++ b/tests/auto/cplusplus/preprocessor/tst_preprocessor.cpp
@@ -41,11 +41,47 @@ class tst_Preprocessor: public QObject
 Q_OBJECT
 
 private Q_SLOTS:
+    void va_args();
+    void named_va_args();
     void unfinished_function_like_macro_call();
     void nasty_macro_expansion();
     void tstst();
 };
 
+void tst_Preprocessor::va_args()
+{
+    Client *client = 0; // no client.
+    Environment env;
+
+    Preprocessor preprocess(client, &env);
+    QByteArray preprocessed = preprocess(QLatin1String("<stdin>"),
+                                         QByteArray("\n#define foo(...) int f(__VA_ARGS__);"
+                                                    "\nfoo(  )\n"
+                                                    "\nfoo(int a)\n"
+                                                    "\nfoo(int a,int b)\n"));
+
+    QVERIFY(preprocessed.contains("int f();"));
+    QVERIFY(preprocessed.contains("int f(int a);"));
+    QVERIFY(preprocessed.contains("int f(int a,int b);"));
+}
+
+void tst_Preprocessor::named_va_args()
+{
+    Client *client = 0; // no client.
+    Environment env;
+
+    Preprocessor preprocess(client, &env);
+    QByteArray preprocessed = preprocess(QLatin1String("<stdin>"),
+                                         QByteArray("\n#define foo(ARGS...) int f(ARGS);"
+                                                    "\nfoo(  )\n"
+                                                    "\nfoo(int a)\n"
+                                                    "\nfoo(int a,int b)\n"));
+
+    QVERIFY(preprocessed.contains("int f();"));
+    QVERIFY(preprocessed.contains("int f(int a);"));
+    QVERIFY(preprocessed.contains("int f(int a,int b);"));
+}
+
 void tst_Preprocessor::unfinished_function_like_macro_call()
 {
     Client *client = 0; // no client.