feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

pluginerroroverview: remove one unneeded level of indirection

Browse Source 
Change-Id: I61395260023829c7e295cfbe3f891195c7945428
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
hjk
2012-11-02 09:44:53 +01:00
parent 82a55d4b9e
commit ffd5cc6f82
2 changed files with 16 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/libs/extensionsystem/pluginerroroverview.cpp
View File

@@ -35,43 +35,12 @@
Q_DECLARE_METATYPE(ExtensionSystem::PluginSpec*)
namespace ExtensionSystem {
namespace Internal {
class PluginErrorOverviewPrivate : public QObject
{
Q_OBJECT
public:
PluginErrorOverviewPrivate(QDialog *dialog);
~PluginErrorOverviewPrivate();
private slots:
void showDetails(QListWidgetItem *item);
private:
Ui::PluginErrorOverview *m_ui;
};
} // Internal
} // ExtensionSystem
using namespace ExtensionSystem;
using namespace ExtensionSystem::Internal;
PluginErrorOverview::PluginErrorOverview(QWidget *parent) :
QDialog(parent),
d(new PluginErrorOverviewPrivate(this))
m_ui(new Internal::Ui::PluginErrorOverview)
{
}
PluginErrorOverview::~PluginErrorOverview()
{
delete d;
}
PluginErrorOverviewPrivate::PluginErrorOverviewPrivate(QDialog *dialog)
: m_ui(new Ui::PluginErrorOverview)
{
m_ui->setupUi(dialog);
m_ui->setupUi(this);
m_ui->buttonBox->addButton(tr("Continue"), QDialogButtonBox::AcceptRole);
foreach (PluginSpec *spec, PluginManager::plugins()) {
@@ -90,12 +59,12 @@ PluginErrorOverviewPrivate::PluginErrorOverviewPrivate(QDialog *dialog)
m_ui->pluginList->setCurrentRow(0);
}
PluginErrorOverviewPrivate::~PluginErrorOverviewPrivate()
PluginErrorOverview::~PluginErrorOverview()
{
delete m_ui;
}
void PluginErrorOverviewPrivate::showDetails(QListWidgetItem *item)
void PluginErrorOverview::showDetails(QListWidgetItem *item)
{
if (item) {
PluginSpec *spec = item->data(Qt::UserRole).value<PluginSpec *>();
@@ -105,4 +74,6 @@ void PluginErrorOverviewPrivate::showDetails(QListWidgetItem *item)
}
}
} // namespace ExtensionSystem
#include "pluginerroroverview.moc"