Fix lupdate issues

When updating translations with
cmake --build . --target ts_de
(or other language ID)

- Qualifying with unknown namespace/class ::PluginSpecPrivate
- <class> lacks Q_OBJECT macro

Change-Id: Ic42d8dffea935e6b10e59223bdedb9a8a4dcf446
Reviewed-by: hjk <hjk@qt.io>

src/libs/extensionsystem/pluginspec.cpp

@@ -723,8 +723,10 @@ bool PluginSpecPrivate::readMetaData(const QJsonObject &pluginMetaData)
     }
 
     value = pluginMetaData.value(QLatin1String(PLUGIN_METADATA));
-    if (!value.isObject())
+    if (!value.isObject()) {
-        return reportError(tr("Plugin meta data not found"));
+        return reportError(
+            ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Plugin meta data not found"));
+    }
     metaData = value.toObject();
 
     value = metaData.value(QLatin1String(PLUGIN_NAME));
@@ -806,10 +808,12 @@ bool PluginSpecPrivate::readMetaData(const QJsonObject &pluginMetaData)
     const QString platformSpec = value.toString().trimmed();
     if (!platformSpec.isEmpty()) {
         platformSpecification.setPattern(platformSpec);
-        if (!platformSpecification.isValid())
+        if (!platformSpecification.isValid()) {
-            return reportError(tr("Invalid platform specification \"%1\": %2")
+            return reportError(::ExtensionSystem::Internal::PluginSpecPrivate::tr(
+                                   "Invalid platform specification \"%1\": %2")
                                    .arg(platformSpec, platformSpecification.errorString()));
         }
+    }
 
     value = metaData.value(QLatin1String(DEPENDENCIES));
     if (!value.isUndefined() && !value.isArray())
@@ -822,22 +826,36 @@ bool PluginSpecPrivate::readMetaData(const QJsonObject &pluginMetaData)
             QJsonObject dependencyObject = v.toObject();
             PluginDependency dep;
             value = dependencyObject.value(QLatin1String(DEPENDENCY_NAME));
-            if (value.isUndefined())
+            if (value.isUndefined()) {
-                return reportError(tr("Dependency: %1").arg(msgValueMissing(DEPENDENCY_NAME)));
+                return reportError(
-            if (!value.isString())
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Dependency: %1")
-                return reportError(tr("Dependency: %1").arg(msgValueIsNotAString(DEPENDENCY_NAME)));
+                        .arg(msgValueMissing(DEPENDENCY_NAME)));
+            }
+            if (!value.isString()) {
+                return reportError(
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Dependency: %1")
+                        .arg(msgValueIsNotAString(DEPENDENCY_NAME)));
+            }
             dep.name = value.toString();
             value = dependencyObject.value(QLatin1String(DEPENDENCY_VERSION));
-            if (!value.isUndefined() && !value.isString())
+            if (!value.isUndefined() && !value.isString()) {
-                return reportError(tr("Dependency: %1").arg(msgValueIsNotAString(DEPENDENCY_VERSION)));
+                return reportError(
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Dependency: %1")
+                        .arg(msgValueIsNotAString(DEPENDENCY_VERSION)));
+            }
             dep.version = value.toString();
-            if (!isValidVersion(dep.version))
+            if (!isValidVersion(dep.version)) {
-                return reportError(tr("Dependency: %1").arg(msgInvalidFormat(DEPENDENCY_VERSION,
+                return reportError(
-                                                                             dep.version)));
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Dependency: %1")
+                        .arg(msgInvalidFormat(DEPENDENCY_VERSION, dep.version)));
+            }
             dep.type = PluginDependency::Required;
             value = dependencyObject.value(QLatin1String(DEPENDENCY_TYPE));
-            if (!value.isUndefined() && !value.isString())
+            if (!value.isUndefined() && !value.isString()) {
-                return reportError(tr("Dependency: %1").arg(msgValueIsNotAString(DEPENDENCY_TYPE)));
+                return reportError(
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Dependency: %1")
+                        .arg(msgValueIsNotAString(DEPENDENCY_TYPE)));
+            }
             if (!value.isUndefined()) {
                 const QString typeValue = value.toString();
                 if (typeValue.toLower() == QLatin1String(DEPENDENCY_TYPE_HARD)) {
@@ -847,7 +865,9 @@ bool PluginSpecPrivate::readMetaData(const QJsonObject &pluginMetaData)
                 } else if (typeValue.toLower() == QLatin1String(DEPENDENCY_TYPE_TEST)) {
                     dep.type = PluginDependency::Test;
                 } else {
-                    return reportError(tr("Dependency: \"%1\" must be \"%2\" or \"%3\" (is \"%4\").")
+                    return reportError(
+                        ::ExtensionSystem::Internal::PluginSpecPrivate::tr(
+                            "Dependency: \"%1\" must be \"%2\" or \"%3\" (is \"%4\").")
                             .arg(QLatin1String(DEPENDENCY_TYPE),
                                  QLatin1String(DEPENDENCY_TYPE_HARD),
                                  QLatin1String(DEPENDENCY_TYPE_SOFT),
@@ -869,20 +889,35 @@ bool PluginSpecPrivate::readMetaData(const QJsonObject &pluginMetaData)
             QJsonObject argumentObject = v.toObject();
             PluginArgumentDescription arg;
             value = argumentObject.value(QLatin1String(ARGUMENT_NAME));
-            if (value.isUndefined())
+            if (value.isUndefined()) {
-                return reportError(tr("Argument: %1").arg(msgValueMissing(ARGUMENT_NAME)));
+                return reportError(
-            if (!value.isString())
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Argument: %1")
-                return reportError(tr("Argument: %1").arg(msgValueIsNotAString(ARGUMENT_NAME)));
+                        .arg(msgValueMissing(ARGUMENT_NAME)));
+            }
+            if (!value.isString()) {
+                return reportError(
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Argument: %1")
+                        .arg(msgValueIsNotAString(ARGUMENT_NAME)));
+            }
             arg.name = value.toString();
-            if (arg.name.isEmpty())
+            if (arg.name.isEmpty()) {
-                return reportError(tr("Argument: \"%1\" is empty").arg(QLatin1String(ARGUMENT_NAME)));
+                return reportError(
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Argument: \"%1\" is empty")
+                        .arg(QLatin1String(ARGUMENT_NAME)));
+            }
             value = argumentObject.value(QLatin1String(ARGUMENT_DESCRIPTION));
-            if (!value.isUndefined() && !value.isString())
+            if (!value.isUndefined() && !value.isString()) {
-                return reportError(tr("Argument: %1").arg(msgValueIsNotAString(ARGUMENT_DESCRIPTION)));
+                return reportError(
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Argument: %1")
+                        .arg(msgValueIsNotAString(ARGUMENT_DESCRIPTION)));
+            }
             arg.description = value.toString();
             value = argumentObject.value(QLatin1String(ARGUMENT_PARAMETER));
-            if (!value.isUndefined() && !value.isString())
+            if (!value.isUndefined() && !value.isString()) {
-                return reportError(tr("Argument: %1").arg(msgValueIsNotAString(ARGUMENT_PARAMETER)));
+                return reportError(
+                    ::ExtensionSystem::Internal::PluginSpecPrivate::tr("Argument: %1")
+                        .arg(msgValueIsNotAString(ARGUMENT_PARAMETER)));
+            }
             arg.parameter = value.toString();
             argumentDescriptions.append(arg);
             qCDebug(pluginLog) << "Argument:" << arg.name << "Parameter:" << arg.parameter

src/libs/utils/qtcprocess.cpp

@@ -638,7 +638,7 @@ public:
             start(commandString, QStringList(), workingDirectory, m_writeData);
         } else {
             if (!success) {
-                q->setErrorString(tr("Error in command line."));
+                q->setErrorString(QtcProcess::tr("Error in command line."));
                 // Should be FailedToStart, but we cannot set the process error from the outside,
                 // so it would be inconsistent.
                 emit q->errorOccurred(QProcess::UnknownError);

src/plugins/android/androiddevice.cpp

@@ -639,7 +639,8 @@ void AndroidDeviceManager::HandleAvdsListChange()
             // of the device has changed, remove it and register it again with the new name.
             // Also account for the case of an AVD registered through old QC which might have
             // invalid data by checking the sdcard size value.
-            if (dev->displayName() != displayName || androidDev->sdcardSize() == tr("Unknown")) {
+            if (dev->displayName() != displayName
+                || androidDev->sdcardSize() == AndroidDevice::tr("Unknown")) {
                 devMgr->removeDevice(dev->id());
             } else {
                 // Find the state of the AVD retrieved from the AVD watcher

src/plugins/clangcodemodel/clangdclient.cpp

@@ -4021,7 +4021,7 @@ class MemoryTreeModel : public Utils::BaseTreeModel
 public:
     MemoryTreeModel(QObject *parent) : BaseTreeModel(parent)
     {
-        setHeader({tr("Component"), tr("Total Memory")});
+        setHeader({MemoryUsageWidget::tr("Component"), MemoryUsageWidget::tr("Total Memory")});
     }
 
     void update(const MemoryTree &tree)

src/plugins/studiowelcome/studiowelcomeplugin.h

@@ -38,6 +38,8 @@ namespace Internal {
 
 class StudioSettingsPage : public Core::IOptionsPageWidget
 {
+    Q_OBJECT
+
 public:
     void apply() final;
 

src/plugins/welcome/welcomeplugin.cpp

@@ -110,6 +110,8 @@ void ResizeSignallingWidget::resizeEvent(QResizeEvent *event)
 
 class WelcomeMode : public IMode
 {
+    Q_OBJECT
+
 public:
     WelcomeMode();
     ~WelcomeMode();