Macros are used like identifiers; there is no reason why they should need
to have the same highlighting as a preprocessor directive.
Fixes: QTCREATORBUG-23548
Change-Id: I186befc06ccb36a00451fd707c41e3687a84af14
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
To display the parent function, first we find it in displayResults and
store the information to SearchResultItem, then
SearchResultTreeItemDelegate gets the information and renders it.
Similar approach is applied to ClangdClient, in addSearchResultsForFile.
This change also adds default style for containing function highlight in
the search.
Default foreground and background colors are same as usual text colors.
Task-number: QTCREATORBUG-27550
Change-Id: Id1251afa192f8d1232524742b7c211770bcb83fb
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and make use of it in the built-in code model and with clangd.
Task-number: QTCREATORBUG-16580
Change-Id: I8c331f56aa1bbf91c9f768be82a779a72f40c4c7
Reviewed-by: David Schulz <david.schulz@qt.io>
This is already built into clang, so we just need to expose it to the
highlighter and the UI.
Fixes: QTCREATORBUG-24880
Change-Id: I6d0595af2589a9b69eb954aafad46457ab2c5752
Reviewed-by: David Schulz <david.schulz@qt.io>
Just use the defaults.
Change-Id: Iad655becbfc13dc793b336ea9d661ad861ef695a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... and make use of that in CppTool's "Find Usages" by assigning
different colors to read and write accesses.
Fixes: QTCREATORBUG-12734
Change-Id: I067db2c8d693bb2c5be44249931ee4f0269f7e52
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Replace all three occurrences of #d64564 with #ff6aad
Otherwise it is hard to read preprocessor code, qml bindings or
mismatched parentheses.
Change-Id: I2812f3d10a1b1d4d2206cc4c19e97b81391e4ce4
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Set the selection color back to the previous one.
Task-number: QTCREATORBUG-16682
Change-Id: I13a00bde7fcceda5d911802e65afd3593b1630f5
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Selected preprocessor code was unreadble: unsaturated red on turquese.
The selection color now defines a foreground color (the same as the
line number color).
Task-number: QTCREATORBUG-16682
Change-Id: Ibb213010557da5bd68fb5a22822cad467fd03092
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
* Make comments lighter
* Add background to disabled code
* Use the same "Value" for red and green shades in diff.
Change-Id: I075974098d8a88b21864483accabeba38b3b6063
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
This is a new dark theme for syntax highlighting,
that works well with the new dark theme.
Change-Id: I10df9cd2f9925687d30f6f621e252459c30e12f8
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Use solarized yellow and red for warnings and errors.
Change-Id: I5164b1184e397eaaca68e06db74b43f6e59edfdd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
These color schemes are based on the Solarized color schemes, originally
created by Ethan Schoonover:
http://ethanschoonover.com/solarized/
Change-Id: I75848608f59bbb32a78520e7b1a1a2554f2eca44
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This gives a clear hint that something has changed.
And gets the attention of the author in the case he didn't
expect some kind of automatic brace or quote completion.
Change-Id: I33e383db9a1e797ecb285a407e46671f41be7051
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>
Underlines colors was hard coded to the foreground color of some settings.
With this patch you can set the underline color and the underline style
to your taste.
Change-Id: Ibc64c2d2c89bf1827a2cadaf6aee9d50d08cd1ee
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
The darkness has not much to do with vim, and people stay
confused about the relation of the color scheme and FakeVim.
Change-Id: Ie04089045314321a60ac284551367d0b637b2e7d
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
Syntax highlight rules for keywords are changed to highlight control
keywords and primitive data types separately.
Change-Id: Ifb25be7a97b92589030aa190641320c233dc7f2d
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
- Highlight all function/methods (not just virtual methods).
- Highlight as a function even if number of arguments does not match. In
that case, add a diagnostic message to indicate there are too many/too
few arguments.
- Fix highlighting of parameters in function declarations.
These used to be handled indiferently, and they could be mistaken for
type or field references.
- Properly highlight template method calls.
Change-Id: I6e61c9ee47763db95c62314f9cc1c4d398df38b3
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
This reverts commit e3e67467cfea5934f16a95385761455b0c495a0d
Reason is that it shows errors for calls to function-like macros. For example, any use of Q_DISABLE_COPY results in invalid errors.
Change-Id: I1fd1473ac5a30da5b9aebf6a3f0f11055bdbe8ad
Reviewed-by: Erik Verbruggen <erik.verbruggen@nokia.com>
- Highlight all function/methods (not just virtual methods).
- Highlight as a function even if number of arguments does not match. In
that case, add a diagnostic message to indicate there are too many/too
few arguments.
- Fix highlighting of parameters in function declarations.
These used to be handled indiferently, and they could be mistaken for
type or field references.
- Properly highlight template method calls.
Change-Id: I6ab463996dda47554839f482da47f561f76663a7
Reviewed-by: Erik Verbruggen <erik.verbruggen@nokia.com>
- numbers were blue, should be yellow
- preprocessor used wrong shade of green
- bracket matching was missing background color.
- operators were green, when this isn't so for the vim original.
reference
https://github.com/ciaranm/inkpot/
Change-Id: I9bd8357d4f2473fa769aae995e795ded05f970a6
Reviewed-by: hjk <qthjk@ovi.com>
In addition for the report below, the cmake highlighter
now uses the keyword color for functions. This was done
in the previous commit: 5ecd885af3d25acfd8f688428268da2d9198a1bd
Task-number: QTCREATORBUG-5037
Change-Id: I7cdf11d0b13cdf7fbd6fac9bfbe715944c57c5a2
Reviewed-on: http://codereview.qt.nokia.com/274
Reviewed-by: Thorbjørn Lindeijer <thorbjorn.lindeijer@nokia.com>
Added missing categories with customized colors for Field, Occurences,
Static and VisualWhitespace.
Removed highlighting for the 'Local' category, since at least I consider
the white names a little messy. In general we've considered the
highlighting of locals less useful than highlighting the members.
Task-number: QTCREATORBUG-2490
This color scheme is based on the vim Inkpot color scheme, originally
created by Ciaran McCreesh:
http://www.vim.org/scripts/script.php?script_id=1143
It was adapted for use by Qt Creator by Jan Kundrát and subsequently
updated by Campbell Barton.
Task-number: QTCREATORBUG-2490
