Commit Graph

61421 Commits

Author SHA1 Message Date
Christian Kandeler
ca7e6bd1b1 ProjectExplorer: Fix restoring the issues pane warning button state
The wrong button function was called.
This does not fully fix the linked problem for the default session,
because there is the additional issue of TaskView::loadSettings() not
getting called at all.

Task-number: QTCREATORBUG-19388
Change-Id: I64dcec9c6d07c8ac614c9a2ecd783e7eaa1a204c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-08-26 13:59:58 +00:00
hjk
5ba05d9f79 Android: Remove unused enum AndroidQemuStatus
Change-Id: I951da00d4f802c0a130c617aa34ddaf2ac9aad4c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-08-26 13:04:41 +00:00
hjk
2231080678 QmlDesigner: Work around yet another Qt deprecation warning
Change-Id: I9a0bce549fac39b1aa180782ccb20bbe69967163
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-08-26 12:01:14 +00:00
Christian Kandeler
5e6c9947ad Update qbs submodule
To HEAD of 1.14 branch.

Change-Id: I11b99311234f981c3f6917079c6119b475396d0a
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
2019-08-26 12:01:04 +00:00
Eike Ziller
10d3772b7a CMake: Fix regression that a "Build" build configuration was available
And the default selected when configuring a project, since it was the
first.

Broke with 5dbfd46bcf which merged
"availableBuilds" and "availableSetups".

Change-Id: Ibc8c241595f3fee6f35e08fa83e499550eff869b
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-08-26 11:40:12 +00:00
Tobias Hunger
14b1b3137b ProjectExplorer: Assert that the filter passed to Project::files is valid
QTC_ASSERT that the filter passed to Project::files is valid before
calling it.

Change-Id: I17776fa4ab3e2aa21ac34db015fdbbb382439669
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-08-26 11:10:15 +00:00
Alessandro Portale
b98596490e Utils/Android: Add themable, DPI-endabled Download icon to Utils::Icons
And use it in AdroidSettingsDialog

Change-Id: Ia847b6df0e5ab26fc02157f888565a3e6d86bb34
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-08-26 10:27:28 +00:00
Christian Kandeler
2cad0733c2 ProjectExplorer: Do not reset kit selection in target setup widget
... on kit update. We don't know why the kit was originally selected,
and keeping track of this information would add unreasonable book-
keeping effort. Plus, the user probably does not expect the selection to
change anyway.

Change-Id: I341e1727a3f1fdd481c3a1670f821aee0e6b9cdd
Reviewed-by: hjk <hjk@qt.io>
2019-08-26 09:04:10 +00:00
hjk
dca7edbeef Let PortsGatherer produce full URLs instead of ports only
This is what the consuming code expects in most cases.

Change-Id: I135592039e28b994996186f627215ab1d2f8d6dc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2019-08-26 08:16:03 +00:00
Eike Ziller
89f3b32104 Merge remote-tracking branch 'origin/4.10'
Change-Id: I0d4655b195d0615719d5d391aa69e682f8c6f78f
2019-08-26 09:45:01 +02:00
Andre Hartmann
a1db400e65 CppLocatorFilterTest: De-noise
Change-Id: Ie7c8bdb55764a229b24a9acf68d1e93d82f5edef
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2019-08-25 19:18:57 +00:00
Henning Gruendl
b4d8e67e0d QmlDesigner: Fix UrlChooser reset behavior
* Cleanup ColorLogic (imports and source)
 * Shifting a value from Constants.js to Values.qml
 * Add a property alias on AbstractButton to allow changing the font
   family

Change-Id: I51542f69f8f2190030a97164167d71d277147391
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-08-23 14:30:16 +00:00
Nikolai Kosjar
4c9ef26817 Clang: Fix clang installation macros
LLVMConfig.cmake (version 8 at least) does not set

  CLANG_VERSION
  CLANG_RESOURCE_DIR
  CLANG_BINDIR

Task-number: QTCREATORBUG-22825
Change-Id: I83de1b73fd777df1ee980cb3189fd3be2e4a9f3b
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-08-23 13:56:01 +00:00
Henning Gruendl
9f7fe2fb82 QmlDesigner: Add AbstractButton wrapper
Add AbstractButton wrapper to HelperWidgets this enables tooltips
on Buttons again.

Change-Id: If82bfcf3097f9e09d5cc19e4363b2428ad0ca872
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-08-23 13:37:03 +00:00
Henning Gruendl
995f09d6dc QmlDesigner: Set reasonable padding range
Change-Id: I84b9e0e2286aaf1574a7a8b68689540e0ca54bc5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-08-23 13:36:47 +00:00
Henning Gruendl
4ff0ee4ab1 QmlDesigner: Swap unicode of alignment icons
Change-Id: I1d40f2c25843d90c20569c349c586ad7393b2255
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-08-23 13:36:35 +00:00
Henning Gruendl
e817b95b8a QmlDesigner: Remove redundant backend value call
Change-Id: I9e0701da02a694d83ab4ce5ed391da96d41c2edf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-08-23 13:35:23 +00:00
Henning Gruendl
fd160f7523 QmlDesigner: Add missing qsTr() to AnchorRow label
Change-Id: I8c5c164c5d66548d6e574360bc38991ccdc750fd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-08-23 13:34:09 +00:00
Nikolai Kosjar
abadd0f198 ClangTools: Tests: Fix tidy checks
Explicitly remove any by default enabled checks (e.g. static analyzer)
otherwise we get more diagnostics than expected.

Change-Id: I53e63a10001be8027e880dac01000bdca4a8f920
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-08-23 13:07:27 +00:00
David Schulz
c54a2aedbc TextEditor: skip painting refactor markers of invisible blocks
Task-number: QTCREATORBUG-21032
Change-Id: I43a91f6c4237bb923c09391bbc436bd617b4512d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-08-23 12:55:38 +00:00
hjk
f629278684 Doc: Describe unclaimed and claimed breakpoints
Change-Id: I56bca8fe51cc4de63ce2f0ac195c9014c8b6c5b9
Reviewed-by: hjk <hjk@qt.io>
2019-08-23 09:50:20 +00:00
hjk
b9d88d3966 QmakePM: Remove unused explicit shadow build flag
Looks like the information has been based derived from
 buildDirectory() != target()->project()->projectDirectory()
for a while.

Change-Id: Ieb64e72d8fd1d4a6a339b695422fff6355cd3969
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-08-23 09:23:43 +00:00
Christian Stenger
e7040f1abf AutoTest: Fix warning about type mismatch
Change-Id: If4b0f2171eafc81330acb8a544201f0d05a9f6ae
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-08-23 09:19:02 +00:00
Christoph Schlosser
4d6e041b73 sdktool: Mark fallthrough cases correctly
after f4d30a6798

Change-Id: Ic5ac727fa9cb2c097372c404a06e9f2a16d3f016
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-08-23 09:17:03 +00:00
Christian Kandeler
2822c4ff11 QmlDesigner: Fix warning about unused variable
Change-Id: Id12a240c5f5b72bc771847b0d255406df003fa35
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-23 09:10:35 +00:00
hjk
04eb17d57e Debugger: Display 'string' instread of 'NimStringDesc' for Nim strings
Change-Id: I2ecf09eb0b3d01c22b670a8dc642cf07eee2cede
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
2019-08-23 08:39:58 +00:00
Henning Gruendl
4cd3b10069 QmlDesigner: Layout and source cleanup
* Cleanup positioner specifics, mostly by adding ExpandingSpacer
 * Fix GridViewSpecifics SpinBox Label distance
 * Remove some semicolons
 * Add missing label (true/false) to CheckBoxes
 * Fix a few indentions

Change-Id: I2b86dde58ddfc1aa78ed3e11c41b0f4eedfc412b
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-23 08:06:56 +00:00
Henning Gruendl
49cde7aca0 QmlDesigner: Cleanup FlickableSection
* Add true/false label to CheckBoxes
 * Move and add missing tooltip
 * Remove redundancy by wrapping ExpandingSpacer from StudioControls

Change-Id: I6ec5d534ea9d71bda54a9f16359479d02d057511
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-23 08:06:46 +00:00
Thomas Hartmann
d83243fbe6 QmlDesigner: Do not jump to EOF
Task-number: QDS-739
Change-Id: I8594e30aad20494d89c748e7f848180bc9af862d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-23 08:06:10 +00:00
Thomas Hartmann
7393305b31 QmlDesigner: Do not use z-order for toFront/toBack
Task-number: QDS-370
Change-Id: I1cfff1b0f87e6dacb1f08c01a7b04d06eadb78e1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-23 08:05:51 +00:00
Christian Stenger
33a4f8ab3c Revert "Autotest: Fix warning about type mismatch"
This reverts commit 501df95d57.
Accidently moved to the wrong branch.

Change-Id: I845103df2e6fb00a2bc27923caffde2622464eba
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-08-23 07:52:47 +00:00
David Schulz
e5cfd9c563 SdkTool: Fix compile with msvc
after f4d30a6798

Change-Id: Ie8985470800b668c2b3ed834884dfad1008efddc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-08-23 06:06:16 +00:00
zarelaky
8fd89a9a34 fixed change variable of project environment cause qtcreator crash
NameValueValidator use const reference save tooltip content which
created by temp variable tr() return.

Change-Id: Ie76b14108e02d74f5c1ca686b349ce948ef88c14
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-08-22 15:40:16 +00:00
Christian Kandeler
5f924cea2a ProjectExplorer: Merge the two update functions in TargetSetupWidget
It was very confusing that we had two different functions that acted on
kit updates independently.

Change-Id: I4801b284c51cab1527324ac9a9f244d9fe9900c3
Reviewed-by: hjk <hjk@qt.io>
2019-08-22 13:52:13 +00:00
Christian Stenger
0d11d880ca AutoTest: Unify container usage in TestFrameworkManager
And provide an accessor for the framework's priority which
will be needed later on.

Change-Id: I5a2480699d9467ee50e2cc44b9d4ff58f9e8da88
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-08-22 13:34:23 +00:00
hjk
297410ba4e QtSupport: Remove unused BaseQtVersion::recheckDumper
Those were the days.

Change-Id: Ie2c0c2f394c9c2f881151c5c8d2b07181dc059fa
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-08-22 13:27:55 +00:00
Eike Ziller
5808ee9569 Disable GCC auto-detection on macOS
It is almost never what you want (it is totally outdated), but it is
found in /usr/bin anyhow.
People who want GCC can still register it of course, and people who used
it before will keep having it as manually registered.

Change-Id: If5722f6e9521bb74160da064bb4dee8db28efdb9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-08-22 13:09:48 +00:00
Christian Kandeler
501df95d57 Autotest: Fix warning about type mismatch
Change-Id: I1bb518292da73861745646ae13f8f1feab541fe9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-08-22 13:05:36 +00:00
Eike Ziller
7d014f0dbf CMake build: Add Boot2Qt
Change-Id: Ie915c09e4e71fb3b1f19711a5cba32f8c4a6aa11
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-08-22 13:03:01 +00:00
Christian Kandeler
ac37c5c950 QmakeProjectManager: Mark disabled source files in project tree
We show all source files in the project tree, including those which are
listed in scopes that evaluate to false in the current configuration.
This is intended, as we want users to be able to navigate to all files,
not just the ones that are part of the build for the current target.
However, it'd be nice for users to be able to tell which files are
"active" and which ones are not. Therefore, we now mark the non-active
ones as "disabled" in the project tree, just like the QbsProjectManager
does.

Task-number: QTCREATORBUG-22855
Change-Id: Icfb48d4f6a247de76fc109acb84b34f03866e754
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
2019-08-22 11:57:45 +00:00
Christoph Schlosser
f4d30a6798 Add addvalue operation to SDK Tool
Introduce the addvalue operation for the SDK tool.
The addvalue operation can be used to add new values
to an existing list in a config file without parsing
the output and then manually adding the new list back.

Change-Id: Iad6a0fb6178bff631424467850d73adc152ddbcf
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-08-22 11:41:11 +00:00
Thomas DeRensis
edad44f213 Parse the types registered with qmlRegisterUncreatableMetaObject()
Fixes: QTCREATORBUG-20569
Change-Id: I65fe8843b09aa127f0c564942b5b4e10a51342ba
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2019-08-22 11:34:12 +00:00
hjk
fb631cb258 ProjectExplorer: Set up hack to funnel information to buildstep ctors
For now, store most of BuildInfo in the BuildConfiguration. This will
allow accessing it in the BuildStep ctors so the BuildSteps can
be fully setup without polishing afterwards (as currently done
in the main build steps of the three buildsystems, and Nim)

This in meant to be temporary to a large degree.

Change-Id: If6ade6052f4b96670995399ae97ef7d2313f632a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-08-22 11:05:04 +00:00
hjk
02707ecdad ProjectExplorer: Compactify DeploymentDataView implementation
Change-Id: I30a4a772e9a54068566be0cab435044c073becf9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-08-22 11:04:37 +00:00
Tobias Hunger
0c062e5827 Locator: Do not consider generated files in the project-related searches
It is unlikely that a user will want to look at generated files --
and if she wants to, there is always file search.

Task-number: QTCREATORBUG-20176
Change-Id: Iefb0aece1dbd6b39aa8892388411c10162319102
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-08-22 10:34:55 +00:00
Tobias Hunger
550c51c75e QmlProject: Ignore generated files
Do not bother to look at generated files. Currently this makes no
big difference, considering that there usually are no generated files
in QmlProjects. That might change in the future with asset
conditioning though.

Change-Id: Ia773f09343efe5ebb006c69e4f41d724bba42d86
Reviewed-by: hjk <hjk@qt.io>
2019-08-22 10:34:48 +00:00
Christian Kandeler
567a0db6dd Utils::Environment: Consider target OS type when sorting
That is, use case-insensitive sorting on Windows, so that e.g. "Path"
will not appear after "PROCESSOR_REVISION".

Fixes: QTCREATORBUG-22786
Change-Id: I42d469b6079037d1062dbd5b273f5aa8ade25e79
Reviewed-by: hjk <hjk@qt.io>
2019-08-22 10:29:22 +00:00
Eike Ziller
c1e2720bed Boot2Qt plugin is disabled by default but not experimental
Change-Id: Ie962be78d62aa57e86c0bb8d45010b93e725ce97
Reviewed-by: hjk <hjk@qt.io>
2019-08-22 10:12:13 +00:00
Eike Ziller
30143478f3 Merge remote-tracking branch 'origin/4.10'
Conflicts:
	src/libs/utils/consoleprocess_win.cpp

Change-Id: Ibdc265eed2f7080726e11ff6f2931c8559943af2
2019-08-22 09:53:37 +02:00
Christian Stenger
8cd7a11926 AutoTest: Fix handling of unnamed QuickTests
..now that the parser understands multiple TestCase items
inside a single qml file.
As long a test function is located inside a different TestCase
it is considered as a different one, so treat test functions
even of unnamed test cases correct.

Change-Id: I5cbfe1f63f896317523d51bbf67ea59169481a71
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
2019-08-22 06:50:05 +00:00