Select a better fallback target when a buildstep's target is no longer defined.
Change-Id: I7ef27361793125258cd2a73448d91d2561db5901
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Update the target list in the build step list widget for CMakeBuildSteps,
even when "current executable" meta-target is selected.
Change-Id: Ifc1d8dc67894202eb38fe6088552797b198c7463
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Add a helper method to find the default build target for a CMakeBuildStep
based on the BuildStepList the step is part of. Use all/install/clean
targets as appropriate.
Change-Id: Idc0c5fae7dfd255039b87ace77c02688cdd76e8f
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Update screenshots using the Design theme.
Change-Id: Idb8911329fb9bb05e34d647f4deb0ad9d47402e2
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Combine host and port values in a url object which is elsewhere
typically used, and move the member to the base class as
all current providers have something like that.
Base typeDisplayName on a datamember, and provide a reusable base
implementation of channelString()
Change-Id: Iedac09bb80d0bc1818cd88b0de99794e951999b8
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Never overridden, and does not look safe to invoke more than once.
Change-Id: If5f3830f3fbf26badb6335443defd628c05cf65a
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
...since this passes by now:
XPASS : CppEditor::Internal::CppEditorPlugin::test_useSelections(macro
use 2) '!hasTimedOut' returned TRUE unexpectedly. () Loc:
[cppuseselections_test.cpp(105)]
Change-Id: I1cf1416831d258319865c5a58a98bae5538ae245
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Currently the only place that's using it and the scope is much smaller.
Change-Id: I1a43d14f0e2c69a16f76e6f83b82436bbeeac1c9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
... taking a QString for the executable.
This weakens the very explicit QString -> FileName conversion via the
named constructors for the special case of constructing a CommandLine.
I think that's worthwhile here, as it reduces the noise on the caller
site under circumstance where the nature of the thing is obvious.
Change-Id: I27b4a73639728893d053b2e7ba65cb745f0ffe83
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Because our project mode uses a fixed width for some reason, the file
path of an executable often does not fit on its label. Add a tool tip to
work around this.
Fixes: QTCREATORBUG-18991
Change-Id: I4ab7cd8812ae15bcef95c16a862361e24a28c259
Reviewed-by: hjk <hjk@qt.io>
FileName is now FilePath. Follow the approach that is used
internal to display the summary of the file path as the
content of its URL if non-empty and the content of the file
otherwise.
Keep the old approach as well as it can still be used,
even in new code thanks to a using declaration and fallback
to the old approach if debugging old source.
Change-Id: I37c621e451fea92ca34db9a63b5ca26b3bdc201c
Reviewed-by: hjk <hjk@qt.io>
Also move info about inspecting basic Qt objects to a separate
session.
Change-Id: I60b0da446ad23cb76549d9ccf56bd9313c9a7127
Reviewed-by: hjk <hjk@qt.io>
For some reason, Q_UNUSED includes already a semicolon, adding one
on the user side creates an additional empty statement.
Change-Id: I9c5e8fac381345a60792cb75e2938fd53958d3b0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
De-facto standard and reduces numbers of warnings.
Change-Id: Ic7758ee30091aaa47650a9697145a302480b31de
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
So far, if we had these three functions:
int getSomething() { return 44; }
int get_something() { return 43; }
int something() { return 42; }
then we did not get a completion for getSomething()
or get_something() if we just typed "some", as only
the prefix was taken into account.
This patch adds support for substring matches, and
adds these with lower priority to the proposal list.
Task-number: QTCREATORBUG-19170
Fixes: QTCREATORBUG-19918
Change-Id: Ifc5e2149e4b1fa995f1f8550efc84e7ff4fb1522
Reviewed-by: David Schulz <david.schulz@qt.io>
If there's no multiplexing, then qbs.architectures will have no effect.
Task-number: QTCREATORBUG-22738
Change-Id: If485481bf0f683fc3c693216d13aee1ba87255fe
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Make ServerModeReader::parse handle the forceCMakeRun flag gracefully.
The problem there was two-fold:
1. The server would send a "isReadyNow" signal when its connection is
estabilshed. This made the ServerModeReader trigger another parse run
with the same parameters.
That would in turn would force a new ServerMode process to be created.
2. The "configure" request that is sent races the new ServerMode
process being connected.
Solve both issues by connecting a slot to the server-mode's
connected signal and have that do the right thing.
Change-Id: I26f9ac00d6ad6397a1fd1fab78610951f535ab53
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Rename internally used classes and suppress them
explicitly while debugging python code to not display
them on the Locals and Expressions.
Change-Id: Ia396243172b2d138c9f4c81b2f1ed0fec0dce3d3
Reviewed-by: hjk <hjk@qt.io>
When parsing the file path of location information the
GdbMi parser expects UNIX-style formatted paths.
When debugging with the pdb on Windows we reported
Windows-style paths which in turn made the parser fail
and the stack never contained a file name and the
current location also had never a marker displayed.
Change-Id: I5216bbaf39ceead63efe8426561f132de3cd04a2
Reviewed-by: hjk <hjk@qt.io>
... in the target setup page. The default kit should only get selected
as a fallback. However, that code was called before checking the
imports, so it could happen that the default kit got selected in
addition to the kits for the imported builds.
Fixes: QTCREATORBUG-22499
Change-Id: I2a86f4de7e3d62f489ff5b5d56e4974b28f6d4f1
Reviewed-by: hjk <hjk@qt.io>
We need to derive some ABI-related data from the parent toolchain.
Otherwise, build systems that do not ignore the kit settings will not
work.
Task-number: QTCREATORBUG-22738
Change-Id: I4359143b4eade124b52af297d7509b682a5852b8
Reviewed-by: hjk <hjk@qt.io>
It's helpful to be able to temporarily disable environment variables, as
opposed to having to remove (and then re-add) them entirely.
Fixes: QTCREATORBUG-20984
Change-Id: Ib0d287035b9357507c4c19faaf3a1517382506b5
Reviewed-by: hjk <hjk@qt.io>
This prodecure requires no further information from the specific project
managers, so we can start it from the ProjectExplorer itself.
Also wait until after project parsing has officially finished and the
run configurations have updated their "enabled" state. Otherwise,
RunConfiguration::isEnabled() will always return false, potentially
leading to the active run configuration getting switched
unintentionally.
Fixes: QTCREATORBUG-21692
Change-Id: I32f4f758b5baa6222329d07b811993568eff1ee3
Reviewed-by: hjk <hjk@qt.io>
The tooltip text may contain characters that need
to be escaped without 'Qt::mightBeRichText' categorizing
this as rich text.
This is needed e.g. to show the proper type when
hovering over a variable of type 'std::vector<int>'
(or some smart pointer) in edit view (no debugging
session).
Otherwise, just "std::vector" is shown since
'Qt::mightBeRichText' returns false for that string
and "<int>" is then probably just ignored as an invalid
tag when the tooltip is displayed.
Change-Id: I25ded2b21e4350a1036ab4b3d8f144383aee776d
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This reverts commit 25f9d9c434.
The deprecation was reverted in qtbase 298f750cdba2bd15e735a47ba8d3b9c093367ba3.
Change-Id: I8a05f038be4b7fc89e05830435e08c3212e4f116
Reviewed-by: hjk <hjk@qt.io>
* Add ActionIndicator flag to control drawing of background and border
* Adapt controls layout to support ActionIndicator without background
and border
* Fix non-editable ComboBox input tap behavior
* Fix RealSpinBoxIndicator disable state
* Add ActionIndicator wrapper in HelperWidgets
Change-Id: I2c2b299a3588791492d8e53a858477306ea38f0a
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
While we do want to show contextual messages from the compiler, the
number displayed on the button should correspond to the actual number of
issues (i.e. errors or warnings), and should not include the notes
around them.
We used to do this correctly, but broke it in acd0d02e28.
Fixes: QTCREATORBUG-18490
Change-Id: Ib6b36f24b4f6bfe53ed5b977f0f88586c4d95b16
Reviewed-by: hjk <hjk@qt.io>
