Commit Graph

61421 Commits

Author SHA1 Message Date
Christian Stenger
93e725c17c Squish: Update UI tour handling
The UI tour is no more offered as modal messagebox
but a small banner frame on the bottom.
Close this the same way we closed the messagebox to
avoid interfering tests.

Change-Id: I40ab675330aa8c40efe5bbd386d2d6bd051ccb4d
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-10-01 19:51:45 +00:00
Thomas Hartmann
8fd26ab893 QmlDesigner: Increase size of SetFrameDialog
The dialog was a bit too small.

Change-Id: Id10d6c0789abe802009214f4799ed25e9812f690
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-10-01 16:06:41 +00:00
Christian Kandeler
8c0906e8fb ProjectExplorer: Make the session list in the management dialog sortable
Fixes: QTCREATORBUG-22911
Change-Id: I2110e00428d65f347fa83cd7b11f54084517be9a
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 15:04:52 +00:00
hjk
312ff692b0 Debugger: Do not crash when displaying uninitialized QImages
Fixes: QTCREATORBUG-23031
Change-Id: I074cdaf509edac6e5659d2e976ed7188e8944d81
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-10-01 14:57:14 +00:00
Nikolai Kosjar
092bdbc0a1 Clang: Reduce built-in diagnostic configs
Change-Id: Ieb7c712916f0b3ddd08b04cccf97fc0fa1f828d4
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-10-01 14:42:38 +00:00
Nikolai Kosjar
a0a39a0470 ClangTools: Make file selection dialog searchable/filterable
Allow filtering for open and edited documents.
Add also search functionality (triggerable by e.g. Ctrl+F).

Change-Id: Ib41400abfd3b81371afddd56b88ff1b9bf8b9bcd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-10-01 14:42:01 +00:00
Nikolai Kosjar
9fd4b25638 ClangTools: State diagnostic config on start
...in application output pane.

Change-Id: I3c630494b3e1283a2455d241cda048a89a02e9ab
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2019-10-01 14:40:56 +00:00
Alexander Akulich
0907bc8658 CMake Build: Fix LLVM lookup for cases when many versions available
If calling both find_package(Clang) and find_package(LLVM), call
find_package(Clang) first to get the currently active Clang version
by default with a consistent version of LLVM.

(Similar to the FindPythonInterp/PythonLibs ordering)

Change-Id: Ib6da04e0fb0ffc1fe67a8eafb0c5f04abbb36b6c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
2019-10-01 14:31:30 +00:00
Cristian Adam
6e7236e23a CMake Build: Add qtcreator_ctrlc_stub build
Change-Id: I22185098bbf6c9a8bdf0f48f82b463a0ebd850c5
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-10-01 14:22:33 +00:00
Christian Kandeler
030fd96d18 SSH: Ignore connection timeout with Microsoft's OpenSSH
The Microsoft-provided ssh binaries misinterpret the connection timeout
in that they only start to connect after that period has passed, which
slows down the connection process. So let's not use the timeout option
there.

Change-Id: I5a5335c7f1b4af04f1afb5603ab0f1a518e8c95e
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
2019-10-01 14:10:36 +00:00
Nikolai Kosjar
b895dfa382 Clang/ClangTools: Separate custom diagnostic configs
Add a separate pool of custom diagnostic configs for the
ClangTools plugin. That is, the diagnostic configs in

  Menu: Tools > C++ > Code Model

are not shared anymore with the configs at

  Menu: Tools > Analyzer > ClangTools

On plugin initialization of ClangTools, move tidy/clazy related configs
to ClangTools.

Change-Id: Id06087a58b53e466a3d7bbac669550c5fbe9899d
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-10-01 14:10:28 +00:00
Nikolai Kosjar
d2648db914 ClangTools: Clean up plugin tests
We can provide the run settings explicitly instead of writing to the
settings.

Change-Id: Ibb9ef0280c14315ff7ba72be75dfd04c50d84484
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
2019-10-01 13:51:42 +00:00
Christian Kandeler
44ddc028b5 Wizards: Make sure project combobox uses same sorting as project tree
Fixes: QTCREATORBUG-22876
Change-Id: Ia8817851a263e6ba3aad7ac0d316b7277ad0240e
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 13:13:51 +00:00
Mahmoud Badri
f9b225ae88 Some timeline visual updates and corrections
- Selection rect selects keyframes based on center point rather than
the whole keyframe.
- Make playhead vertical line extend to the whole height of the
timeline widget.
- Prevent a jump when dragging a selection of keyframes.
- Prevent dragging keyframes if the clicked keyframe is deselected
(i.e. Ctrl+click a selected keyframe).
- Correct timeline bounds checking while dragging multiple keyframes.

Task-number: QDS-1073
Change-Id: Ibf118ecccfe86346f2d4e921c0958294a15c24f1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-01 13:07:04 +00:00
Cristian Adam
171ad72b7a Build fix for qmldesigner
Build broke in 47ee781394

Change-Id: Iffd26cfe7778ded7802afe5cf317ca104b95b970
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2019-10-01 12:05:46 +00:00
Henning Gruendl
cf6a88c3ae QmlDesigner: Cleanup layout specifics
* Add missing drag range property to AnchorRow, MarginSection and
   PaddingSection SpinBoxes
 * Use MarginSection for LayoutProperties

Change-Id: I656fc0df353a16477a1ad0279af7186899f5f7e6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-10-01 11:52:24 +00:00
Henning Gruendl
15bf546ff9 QmlDesigner: Fix attached property handling
* Add margins to the list of attached properties
 * Add handling of margins change

Change-Id: I4630169ce07a4903360962b7c8d9fb6d4c01df13
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-01 11:52:11 +00:00
Henning Gruendl
e0f32375a6 QmlDesigner: Fix SpinBox rounding issue
Change-Id: Ibce91edca795c4ac560cd085be161850d9f01b76
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-01 11:51:52 +00:00
Tobias Hunger
7debb513e2 BaseQtVersion: Remove getters for configValues and qtConfigValues
They are unused.

Change-Id: I4350fe33af24e418eb318518f7ca66301d9a7519
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 11:47:00 +00:00
Tobias Hunger
b489bfd615 BaseQtVersion: remove qmakeProperty(...) getter
Qt 6 will not use qmake to identify a Qt version, so this can not
be part of the public interface of BaseQtVersion anymore.

Provide getters for the information actually read via qmakeProperty(...).

Use the getters whenever possible.

Change-Id: Iadbee80b75e4f8b06caf90e7ed69fae2029b4dd7
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 11:46:43 +00:00
Eike Ziller
123aa77c49 Help/litehtml: Guard against out-of-bounds scroll values
If we set the value of the scrollbar to an invalid value, nothing gets
repainted, so we need to take the branch that calls update explicitly in
that case.

Change-Id: I700c690119b1ee2fe8b88d77c29e00f329810448
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 11:32:41 +00:00
Mahmoud Badri
c2e6dd6958 Allow dragging the playhead by clicking the ruler
- clicking the ruler and dragging drags the playhead instead of showing
the selection rect.
- bound the selection rect to the functional (i.e. not the properties
section) and visible area so that it doesn't select something off
screen and also it looks better.

Task-number: QDS-1069
Change-Id: Icec0592bae028637056cbed24b499ef6b7e1803c
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2019-10-01 11:20:53 +00:00
Miikka Heikkinen
47ee781394 QmlDesigner: Create imported 3D assets initially in temporary directory
Once all assets are created in the temporary diractory, cancel is
disabled and all assets are copied to the final location.

Canceling no longer immediately closes the dialog, so you can see what
happened in the log.

Change-Id: I8c2d261091b0963e0b34a71bc9171e1757da68df
Fixes: QDS-1083
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2019-10-01 10:06:33 +00:00
Christian Kandeler
736eef24ca Designer: Fix look-up of resources for UI files
Commit 81a643ec99, fixing QTCREATORBUG-22412, was too restrictive: UI
files in applications have access to resources of library dependencies,
so we must consider those. We now only exclude resources from other
applications.
Note that this will potentially list non-applicable resources, e.g.
those from libraries to which our product does not have access. This
cannot be reasonably prevented, because not all build systems provide
this information. It's also not as bad as missing resources.

Fixes: QTCREATORBUG-22909
Fixes: QTCREATORBUG-22962
Change-Id: I51a87402b43c156618982813c408060f300e4e58
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 09:27:10 +00:00
Cristian Adam
b4022f90d5 GccToolchain: Print command line arguments and error message
In case of compiler toolchain defines autodetection print relevant
information needed to find out why it failed.

Change-Id: I03ff5d01c39c06bd4c3a24ad51688a7a701a3c33
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 09:05:54 +00:00
Christian Kandeler
016ad4a978 SSH: Fix for Microsoft-provided sftp.exe
The sftp.exe shipped with Windows 10 does not emit a prompt to stdout
when invoked via QProcess and thus cannot be used to establish an SFTP
session. However, batch mode can be made to work, so we now use that in
our device tester.

Fixes: QTCREATORBUG-22471
Change-Id: Ia55e66c6f342720c9a0f0c1943f6d9d969842bad
Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
2019-10-01 08:51:33 +00:00
Christian Kandeler
ec15cf23f3 Project Tree: Fix focus issue
Some godawful global focus state was set too late, resulting in weird
behavior after an action in the context menu was activated via the
keyboard. (Namely: If you did that *once*, the "Add New File..." entry
would *forever* be disabled in all subsequent context menus, regardless
of project, session etc.)

Fixes: QTCREATORBUG-22850
Change-Id: I0afed61b65ac5064cb6a229c9bfa45445a3a6c34
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 08:39:04 +00:00
Alessandro Portale
4ce705554a QmlDesigner: Fix forground color for FloatControl in Timeline editor
Task-number: QDS-1095
Change-Id: If55175b41ae16f02d4448a1ea9b630de55bca02c
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-01 08:35:31 +00:00
Alessandro Portale
060d47f317 QmlDesigner: Fix colors of +/- icons in TimelineWidget
In non-dark themes, icons outside toolbars requre a color role with
contrast against the background.

Task-number: QDS-1096
Change-Id: I10e1c77a71e77a2935844507c9ebe739065a69ef
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-01 08:35:24 +00:00
Alessandro Portale
dea46dd04e Qml tooling: Support Qt 5.14
QtQuick 2.14
QtQuick.Controls 2.14
QtQuick.Window 2.14
QtQuick.VirtualKeyboard 2.14

Change-Id: Ide447cf8f5beae481495e6c7220dfc075d6e859f
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2019-10-01 08:34:55 +00:00
hjk
fc2e22dad2 Android: Move logic to trigger AndroidManager::updateGradleProperties
Previously, AndroidManager::updateGradleProperties operated always
on a project node found using target->activeRunConfiguration()
which might or might not be the one that will actually be used
after the build.

This here still does not address the problem that the activeRunConfiguration
may change but introduces a way to specify the relevant node, and tries
to use the right one when available.

At some time, this could be developed into a real solution, e.g.
by invalidating the cache on build key changes.

Change-Id: I37a3d73e9ad3615025e4def2493f683d11add3c6
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
2019-10-01 08:15:55 +00:00
David Schulz
9afc5305d6 TextEditor: more FileName -> FilePath renaming
Change-Id: Ia61868806db47561e7bf7ae9b3cfb1e62a085a7a
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:54:11 +00:00
Eike Ziller
d3b4f06ada Help/litehtml: Fix that invisible text was found via text search
We need to explicitly restrict the index to the html body, otherwise
e.g. the title tag will be included.

Change-Id: Ic7d177deb9cc1c5ce072265669f4d921c9cb4bb1
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:41:26 +00:00
Tobias Hunger
e90081cd88 Fix white space
Change-Id: I1743eadb01149ebcc705aafbe7cc3374489e65e8
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:38:12 +00:00
Tobias Hunger
d6d05abccc BaseQtVersion: Return FilePath from frameworkInstallPath
Rename the method to frameworkPath to be more in line with the rest.

Change-Id: I3e018ca91e027a95d1ef4993705781957bc68144
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:37:41 +00:00
Tobias Hunger
a542f5075f BaseQtVersion: Deduplicate documentation related methods
Use docsPath() over documentationPath() since that fits better into
the naming scheme of the rest and already returns a FilePath.

Change hasDocumentation() to hasDocs() accordingly.

Change-Id: I619d7c68e612c4e25a830e4dce128d9a1e84c2e2
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:37:29 +00:00
Tobias Hunger
67934ccaaa BaseQtVersion: Use FilePath for demosPath()
Change-Id: I83bcbf64a37faf0f88c6b1f655ff3d5c5d7e623c
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:37:10 +00:00
Tobias Hunger
3404a44ee1 BaseQtVersion: Have examplesPath() return a FilePath
Change-Id: I6b37345022d7cdba4aef0af0ca2a825c8606062c
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:36:59 +00:00
Tobias Hunger
9c84c6b271 QtSupport: Replace 0 with nullptr
... and let clang-format clean up the indentation.

Change-Id: I56401804899628813e54c5b573806ab149885e67
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:36:46 +00:00
Tobias Hunger
17f7b8e957 QtSupport: Simplify detection of embedded linux Qt versions
The temporary Qt version never has a qmake path set, so it always
returns an empty list of qtAbis.

Make that explicit:-)

Change-Id: I74b65897e5a9daddae638a99c38fa1a95f8a3086
Reviewed-by: hjk <hjk@qt.io>
2019-10-01 07:36:37 +00:00
Elvis Angelaccio
85fcd10f90 Show application icon in Plasma Wayland sessions
kwin_wayland fetches application icons from .desktop files, so we
need to set the desktop filename on the QGuiApplication instance
(otherwise kwin will set a generic wayland icon as fallback).

Change-Id: I89921ace4a5a4ff2a2387111e51a8914f58e44a8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-10-01 07:02:35 +00:00
Christian Stenger
17f5e19399 Squish: Stabilize tests that rely on a parsed project
As more and more progress bars might be present for different
purposes and we are not able to easily distinguish them
we need to use a more reliable way to wait for the end of
parsing a project.
Add a respective function and use the new approach where
this appears to be appropriate or necessary.

Change-Id: I20e2b9b0efd4785f8f0b1ddbc8496be111628669
Reviewed-by: Robert Loehning <robert.loehning@qt.io>
2019-10-01 06:11:42 +00:00
Milian Wolff
be61acffe7 Don't link against QtSupport in CTF Visualizer plugin
Change-Id: I03e4e3d4a2c687ba5841987318eee569c3fa15c4
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
2019-09-30 20:23:52 +00:00
Thomas Hartmann
da0601e470 QmlDesigner: Add ItemFilterModel
This exposes a model to QML that allows
to get a list of all ids of items of a specific type.
This allows implementing a combobox that can e.g. set
the id of any image element in the file.

Change-Id: Ibc825cb5a66c951d29df12676f9433c9232fd8af
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2019-09-30 15:21:37 +00:00
Thomas Hartmann
2509dd4c32 QmlDesigner: Add supported Qt Quick version
Change-Id: If4e40fafe2270dcdd76cefe5d3a03f11984e466a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-09-30 15:21:18 +00:00
hjk
b0ea4311e8 Short live McuSupport
Medium term to be merged with BareMetal/RemoteLinux/...

Change-Id: I444c65bcfa8e3cf8642ff64e964459720814860a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2019-09-30 15:04:32 +00:00
Leena Miettinen
6b73eec05b Doc: Describe removing existing directories from projects
Task-number: QTCREATORBUG-16575
Change-Id: Ic2aed97d8b414b6aa69e00e6620a7613845c562d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-09-30 14:10:40 +00:00
Eike Ziller
3c5b774cd5 Add changes file for 4.11
Change-Id: Iebd122a40ebb20bf54d0d1af2398f69fcbf2eb18
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2019-09-30 13:58:09 +00:00
David Schulz
a30b936760 Python: add task for pyls installation
Change-Id: I0a85a3ae9fe4e8b327b3b90732556bf940215b7a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-30 12:50:45 +00:00
David Schulz
94f717bd3c Python: make pyls install kill timer a member
Change-Id: I62515673ef65e87b2f23345aa52a22a86a2be763
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-09-30 12:40:36 +00:00