All users did initialize m_priority with a call to setPriority in
their constructors, but we should not rely on that.
Change-Id: I707aaaf117e2680ba0bb1f2849e66c426b4fb8b4
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Use member initialization to make sure everything is properly initialized,
even when not on windows.
Change-Id: I585476556fd83f493a68b26dcecd26dd772122e2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This moves all of the RunControl implementation into a single
RunWorker, not yet splitting it up into separate RunWorkers
which is the final goal of this series.
Change-Id: I7373105603505aa4fffd7fe5ff0145f0128b34bc
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Also streamline code paths in the result.
Change-Id: Id7d96343a8f778ba8f415b1a850cc78576afa475
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If prefix is equal to some completion then show it
before anything else.
Task-number: QTCREATORBUG-15445
Change-Id: I976da4a829b818e843d31a76d2818eb5bbedda93
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Allow users without physical MenuKey to open the context menu
Change-Id: Id886a5614e26d614cba6ceb3b08a9df6148e9655
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Do not complete -> and . with global completions if
foo is a ptr/ref to forward-declared class.
Change-Id: I41e6745ffb07be1d973fe6a8132824f1b3bf7fb1
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
With the new big icons, the default ScrollMode = ScrollPerItem behavior
seems a bit unsmooth. ScrollPerPixel fixes that.
Change-Id: If4deb0f1323f70231af44a17d0b50eea9e37f10e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Fix templates highlight and completion on Windows
Add UI to turn on/off delayed parsing (off by default)
Task-number: QTCREATORBUG-17222
Change-Id: I0cd5e0bcfff2789cd938e4096829f777ff15957a
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This was still missing from the Qt Quick Application wizard docs.
Change-Id: I8e94d61080dc7877eb354c9342f49cdc1a6b01ed
Reviewed-by: Tarja Sundqvist <tarja.sundqvist@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
The model is not owned by the proposal.
For corner cases, we leaked here already for ages. Starting with
commit fab4dd068e
CodeAssist: Fix auto completion if function signature is shown
leaks happened also for a hot path: code completion results that does
not match any so far typed prefix. Due to auto completion turned on,
this triggers frequently when typing text.
Task-number: QTCREATORBUG-17752
Task-number: QTCREATORBUG-18326
Change-Id: I9df177723b31cf3df36e73ef1e7920d9aa5e16e5
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
This significantly simplifies the implementation, properly handles
C vs C++ compilers, and defaults to 64-bit architectures for iOS devices
and simulators.
LLVM-GCC support has been removed, as the last version to support it was
4.6.3, which is far below the version of Xcode we still intend to
support. The toolchains are also given more sensible names
("Apple Clang") instead of iphonesimulator-clang and iphoneos-clang, as
the there is now only one compiler for all Apple platform targets, and
there is one entry of the Apple Clang compiler per supported
architecture.
The different to the end user is minimal except that the compilers are
named better. The number of kits and their configurations remain the
same, but this patch paves the way for tvOS and watchOS support.
Change-Id: I6e2b17f8c17d9dd504f0ad540e08782f291b73c0
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
- Update Creator's sources to v4.2.2
- Update project trees to what Creator 4.3 shows
If needed, two separate changes are in codereview.
Change-Id: I16ee341653c8b916b15208f16699c0d4cbf6df05
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Deploy step names have changed in Qt 5.9 and the generic Linux
steps can now be used.
Change-Id: I409cd2d7b289a22a3c958be32b78d6936074a535
Reviewed-by: Kari Oikarinen <kari.oikarinen@qt.io>
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
Normal builds of Creator can only use cdb with the same bitness.
In the official packages this is being solved by sharing
qtcreatorcdbextXX between 32- and 64-bit builds.
Change-Id: Ib31e4d71789065bef908bf13569de4284ae20de9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The folder layout has changed, so the sanity check if cl.exe is actually
from a Visual Studio installation failed.
Task-number: QTCREATORBUG-17925
Change-Id: I19bc0ca93ee529643f271b6e61b5afda27fdf446
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Make sure m_cmbActivity is initialized, even when bombing out via
the QTC_ASSERT at the top of the constructor. This will fix a
coverity warning.
Change-Id: Ib5a68d8f5516ccee71c4dabc9c216092dd9c025a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The icons have been redesigned to have a more consistent and clean look.
The colors work well with both dark and light themes. The dimensions of
the icons have been made larger in order to facilitate their use in an
icon grid.
A follow-up commit will add more wizard templates that make use of the
larger icons in order to depict various Qt Quick UI layouts.
Some icons (Qt Quick Application, Qt Quick Controls 2 Application) were
unchanged, as the follow-up commit will remove them in favor of
more specific templates.
Task-number: QTPM-395
Change-Id: I5804c3fb92c60e53e1380cfb05d4c7f14e877d8a
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
BareMetal is destroyed before ProjectExplorer.
When DeviceManager clears its device list, it calls the devices' dtors,
which in turn call GdbServerProviderManager::findProvider in order to
unregister.
Since m_instance is already null at this point, this leads to a crash.
Change-Id: I1075433cad5579febddf79b463ffe12cdb75a85c
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Tim Sander <tim@krieglstein.org>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
It is deprecated, and GCC7 warns about RHS expansion to defined.
Change-Id: I161ee9c566ee12d0e443a9054dd0e5cdadc0518e
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
It causes an exception when being divided
Noticed with boost::icl::interval_set.
Change-Id: I5629436c3c1ba10e7b67bb05d720329f4c61eafe
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
