this was forgotten when the value lists were extended by a size hint.
Change-Id: I6f9b55ed671224a9b8735c8d937f94aac4a73a42
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Provide default implementation to do a single-line layout
and let the DebuggerKitConfigWidget span 3 rows, aligning label
and button accordingly.
Change-Id: I0fb3a3116a593822da9c4499c142b8a8255c02d0
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Reviewed-by: hjk <qthjk@ovi.com>
The "magic" symbol was QString::fromAscii, which might be fully inlined
in Qt 5. Use QString::fromAscii_helper instead, and also make the detection
a bit more robust in case the magic symbol is not found.
Change-Id: I99e61797356a0d90467d32e54acc2d2a104d609a
Reviewed-by: hjk <qthjk@ovi.com>
This is fixing a regression introduced recently during the
WatchModel rework.
Change-Id: I128368e78d00f1ef1fc96f7319b19873099396fa
Reviewed-by: hjk <qthjk@ovi.com>
Otherwise a crashing SFTP server can leave the client hanging.
Change-Id: Ie96d7a9797074ddea3b50a1788b8ef7cd4bcd5bf
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
For DEPLOYMENT, foo.sources has been superseded by
foo.files in Qt 5.
Change-Id: I8a357aca0969b7caa94b9e9ed63613064ba86299
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Make it possible to add kits again after all kits were removed
from a non qmake project.
Task-number: QTCREATORBUG-7814
Change-Id: I38967cd4c106b95288b7020fe325d8cfe2688a7c
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Add info about the kits. Fix changed field names.
Change-Id: Ic8d10e17d3cef4082c0a151d15bfe8da14e7ad66
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
As fillParameters(..) (debuggerplugin.cpp) now overrides the start
parameters for channel, pass the port to use when remote setup is
completed instead.
Change-Id: Iad4c3e4d092105cde32b52814218b77990549f61
Reviewed-by: hjk <qthjk@ovi.com>
The width of the List view showing the
autocompleter proposals is now adjusted
when scrolling.
Task-number: QTCREATORBUG-7185
Change-Id: I5b26ef6195d389b30fdf0964bebd9c2f33056c66
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
To be consistent with the change 5b847a66df
in the InsertionPointLocator. Nevertheless, there are still issues to be
addressed in this class so we probably need more test cases when those
are handled.
Task-number: QTCREATORBUG-7833
Change-Id: Ie9abdd70566063a94350723432215d030c154fab
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
It depends on and mixes in changes made in another change on gerrit
that is not merged, so it breaks the package build.
This reverts commit c29bf6f652.
Change-Id: Ibb251150909271f3e119f05a1691832aae8ac633
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Because the change depends on reverted commit
c29bf6f652
This reverts commit 550f8218de.
Change-Id: If287c4b126b1ef710c074fd85946da41161c6ba9
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
It is not guaranteed that all device creation factories have been set up
at that point, meaning that some devices will not be loaded from the
settings.
Change-Id: Ibce0e6c125980b1807efca4ce97693f9af7ab79a
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
TokBranch may hold zero-sized blocks, which must be explicitly handled
before trying to enter them.
Task-number: QTCREATORBUG-7706
Change-Id: Idaa129e12eb89cbc9572277083765fa6e15e0849
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
properties now use hashed names as well.
Task-number: QTCREATORBUG-7706
Change-Id: I6f941647104152c61f8b86972d24dea6d227cb77
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
When the first attempt to run an application on the BlackBerry device failed,
e.g. due to not being able to connect to the device, the Play button remained
disabled, so any subsequent attempts to run the application was not possible.
Change-Id: I2b9778f7b936e06b2594d2485d7e5575cddbba14
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Reason: $INSTALL_ROOT is only meant to be used by packagers
to temporarily put the contents into a different location,
which is needed for fakeroot packaging.
QTC_PREFIX is not a qmake variable, and defaults to
/usr/local. On Windows the default prefix is "QtCreator",
since "make install" is expected to be used in
a packaging context only where either INSTALL_ROOT
should be used or QTC_PREFIX should be set to the
absolute destination path where e.g. an installer
generator will pick it up.
Change-Id: Ifa4950340e58e34726c53f5417adcc7b50828ce1
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Introduce virtual methods such that it is possible to
write derived classes for specific KitInformation classes,
allowing for filtering and setting text and tooltip.
Remove debugging-specific code of KitChooser from
the ProjectExplorer.
Move populate() away from the constructor as not to call
virtuals from it.
Implement DebuggerKitChooser. It should no longer be
possible to to choose an invalid kit for debugging
from the debugger starter dialogs.
Add a protected constructor to DeviceProcessesDialog
allowing to pass a KitChooser.
Change-Id: I8c683a2da7d69bfbccdc08213cb47d69a0df8b3e
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Introduce a struct DebuggerItem as a debugger configuration
item, containing debugger engine type and binary. Store
information as a variant map. Add a combo box.
Remove engine guessing logic. Parts of it are still required
when checking the suggested debugger from the SDK.
Split error checking to be able to do a quick error check
and find only valid profiles in the matchers.
Pass on errors up to RunControl::create().
Change-Id: I08653e2a76ca2c371701082f8173b0b8f8ed462e
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
