Commit Graph

13 Commits

Author SHA1 Message Date
Thomas Hartmann
00d53966ec QmlDesigner: Simplify writing a setting
Change-Id: I4e9589622f40a5ac14b88f0914f4f6819259d4a6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-01-19 13:16:09 +00:00
Thomas Hartmann
f23c0db1a2 QmlDesigner: Simplify reading a setting
Change-Id: I754b3ac1635699e5d9ceab376ae70752a966082f
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-01-19 13:16:02 +00:00
Tim Jenssen
fa84524c0c QmlDesigner: rename RewriterError -> DocumentMessage
Change-Id: I8cbb1b8b83ec10c33e416de96a09281208be8773
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2017-01-10 16:22:23 +00:00
Thomas Hartmann
759db2b7b6 QmlDesigner: Polish error handling for integrated text editor
The integrated text editor requires a couple of fixes and features
in the error handling.

The errors are now handled by the model and not the document management
anymore.
The text editor does not get disabled if there is an error. Instead
we show the error in a status bar.
The form editor is blocked if there is a QML an error and we show the
error message inside the form editor.

Change-Id: I4bfb9b33b09e444ec1de31dd531ce83b32cbcf88
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2017-01-10 15:58:36 +00:00
Thomas Hartmann
2e81a39b7c QmlDesigner: Remove transparency from DocumentWarningWidget
The ToolTipBase has alpha in some themes (e.g. Flat Dark).
If the background of the DocumentWarningWidget is transparent,
this looks buggy. We remove the transparency by blending
the color against the background color.

Change-Id: I4a25a30700b3ee1e9e8d23d0b0bad09f297f0605
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2016-10-07 19:53:17 +00:00
Tim Jenssen
c27c9a3123 QmlDesigner: fix gotoCode in error/warning case
The QmlDesignerPlugin::hideDesigner() jumped again to selected node,
which came after the DocumentWarningWidget already set it.

Change-Id: I6e84342208c6405e8b25b516cd411b30bc48fcdb
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
2016-10-05 11:49:44 +00:00
Tim Jenssen
d915b22db9 improve static initializers
Change-Id: I304fdd6627f01fc216c84930da607127c52409d9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2016-09-23 14:27:01 +00:00
Tim Jenssen
1d61239bb9 QmlDesigner: readd the flag to fix a crash
Also this is necessary to be at the right middle
position of QtCreator.

Change-Id: I691002b7ed5a29a1ea2094f62aba121b2a2e458e
Task-number: QTCREATORBUG-16673
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
2016-07-29 08:25:11 +00:00
Thomas Hartmann
a72c24a0fd QmlDesigner: Cleaning up DocumentWarningWidget
This patch also simplifies DocumentWarningWidget.

Task-number: QTCREATORBUG-16539
Change-Id: I64a715c2a0eaf12a8515a59566e7b22c86ad8928
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2016-07-19 14:14:46 +00:00
Thomas Hartmann
78be4281c1 QmlDesigner: Fixing DocumentWarningWidget
* Connect was missing
* The check box contains the opposite truth value of the setting.

Change-Id: If6ef86e0e1107ce537ee05ddf983131f65ee9e20
Reviewed-by: Tim Jenssen <tim.jenssen@theqtcompany.com>
2016-06-23 12:57:44 +00:00
Tim Jenssen
6512227302 QmlDesigner: merge QmlWarningDialog and DocumentWarningWidget
- fixed cases where the user got the one and the other
    dialog
  - not only the first error is shown, the user can browse

Task-number: QTCREATORBUG-15772
Change-Id: I27786b0e4f9c987646a69d8d7d9ff33e3702587a
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
2016-05-20 10:29:16 +00:00
Tim Jenssen
cacdcf7160 QmlDesigner: improve warning widget code
- the "move" code needs to be inside the warning widget,
   this also fixes the problem of wrong position at startup
 - the patch removes knowledge about the DesignModeWidget and
   uses a signal

Change-Id: I9a861ab955d16e85d7af36f1b56ddb82578b8da4
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
2016-05-10 13:04:04 +00:00
Tim Jenssen
55c951e4a7 QmlDesigner: move DocumentWarningWidget to extra file
Change-Id: I6ea87a224565b77ff42f187461094ca258dcdb01
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
2016-04-29 08:07:15 +00:00