Commit Graph

11 Commits

Author SHA1 Message Date
Thiago Macieira
9dd60b34f8 Fix use of variable before initialization
That's what you get for shadowing a variable... The "childItem" variable
on the second part of the foreach refers to one declared on the first
part, which is uninitialized.

Found by ICC 14.0:
graphicalnodeinstance.cpp(300): warning #592: variable "childItem" is used before its value is set

Change-Id: I9079a428eda90f4bb06f9ccd1adf836fee119133
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
2013-12-16 21:47:21 +01:00
Marco Bubke
89db22a1c8 QmlDesigner: Better componentComplete
Change-Id: I2bfdbeabd4d08474d50434d7e13c32b780e783ca
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-06-18 15:10:43 +02:00
Marco Bubke
30d3e7e51d QmlDesigner: Fix preview rendering
We excluded item which had a node instance. For the preview all item should
be marked dirty.

Change-Id: I0cbad89707d7d94f65ac0d055488e124da40e7b3
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-06-18 15:09:26 +02:00
Marco Bubke
782e8f66a1 QmlDesigner: Remove code which does nothing
Change-Id: Ia6edcd10c42f0ef71ed1237e45185e5fd8a4a66e
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-06-04 14:37:35 +02:00
Marco Bubke
7976456002 QmlDesigner: Add content item hack
There is no stand content item interface, so try to work around to enable
snapping and anchoring.

Change-Id: Ib2eaf0d6c35e3ba289dd7d55b2ba4c064ad40748
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-05-22 14:45:43 +02:00
Marco Bubke
4f28228293 QmlDesigner: Fix anchoring for application window
We don't tested that target anchor object are node instances. Now we
search for the parent object recursively.

Change-Id: I2e03e714f858a285309b02f5e88c757f0dcfe7e5
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-05-21 17:13:48 +02:00
Thomas Hartmann
7a5836d257 QmlDesigner.Instances: emit component complete signal for 5.1
Emitting the Component.onComplete signal.

This is only available in Qt 5.1

Change-Id: I77503333296cccd9999d2610cca126530f777777
Reviewed-by: Marco Bubke <marco.bubke@digia.com>
2013-04-30 13:11:05 +02:00
Marco Bubke
cec82a13e1 QmlDesigner: Fix clipping render bug
Clipping is happen over the bounding rectangle, so should provide the
clipped bounding rectangle.

Change-Id: I602da312a7ca327def378a887a75782c61cc680d
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-04-24 17:45:52 +02:00
Marco Bubke
ea5169a163 QmlDesigner: Improve naming of variables
Change-Id: I8429517b81308f4a6a15b90a1ac7486de49562d9
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-04-24 17:45:44 +02:00
Marco Bubke
ff4457bb46 QmlDesigner: Prepare for other layout items
Change-Id: I831e68877eb3d785b4bbb99db002ab8e42158d75
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-04-22 17:03:37 +02:00
Marco Bubke
40b62e1cfa QmlDesigner: Add GraphicalNodeInstance as abstraction for item and window
Change-Id: Icaba711464f672a3bfbb9d83a449d47e72ba11ff
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
2013-04-22 17:03:23 +02:00