Commit Graph

10 Commits

Author SHA1 Message Date
hjk
611e1ea837 Utils: Encourage marking of raw command line parameters
Change-Id: Id66ac07732c66ab8c1232fe1f58042de8a61abb0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-06-06 12:22:47 +00:00
hjk
d1fef0ea51 ProjectExplorer: Add a Runnable::setCommandLine()
Change-Id: I9b6a782e143dca8519cdc57171557bd3893df921
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-06-03 11:31:53 +00:00
hjk
4098be05b2 Utils: Extract a CommandLine structure from a QtcProcess
We regularly pass around strings or filenames or pairs of strings
or filenames and stringlist etc the in the end will be used
as a kind of "command line", with quite a bit of ad-hoc user
code and QtcProcess::addArg etc to set them up and manipulate them.

Let's have a class for that concept.

Change-Id: I288ab939d853b32c717135a65242c584c2beab50
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-05-29 14:36:46 +00:00
hjk
c3d0d2d97b ProjectExplorer: Make it easier to use RunConfiguration ids
... in RunWorkerFactory. The semantics is the same as in the other
{RunConfiguration,BuildConfiguration,...}Factory::addSupportedFoo
cases: As long as none is specified, there's no constraint, if
there are any, it's a whitelist.

Change-Id: Ia05afd9afe6886e4bacc58ac786f2548f03e5ca8
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-04-05 05:32:43 +00:00
Christian Stenger
aa69f1af3d ProjectExplorer: Fix compile for journald support
Change-Id: Ib00057da9f8572f8d218af4f482d7dab60aa1f4e
Reviewed-by: hjk <hjk@qt.io>
2019-03-21 08:51:53 +00:00
hjk
592417ac17 Android: Avoid a direct use of RunControl::runConfiguration()
Change-Id: I69a610befeda78b85a2cb6285ff60a4e75ff12b4
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-21 08:00:31 +00:00
hjk
5672e1199a ProjectExplorer: Remove RunWorker::runMode()
Only used once, and that use can be replaced.

Change-Id: I844254dfff9bb2b2c9c56ecbd56d2af2241fd2d8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-21 06:47:50 +00:00
hjk
68a10d71e7 ProjectExplorer: Replace RunControl::producer
... by two more specialized canRun() / createMainWorker() functions
resulting in somewhat leaner code on the user side and paving the
way for introducing a RunWorkerFactory class intended to follow the
now-canonical way of having factories as members in the plugin pimpl.

Change-Id: Id6fc2043a340203f14ab0b896a8dfa1e298f58a6
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-20 09:16:08 +00:00
hjk
7a4752bde5 Debugger: Avoid some uses of RunControl::runConfiguration()
Change-Id: I1dcf5b96e6c23e369217f38a440305abb51dcd25
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2019-03-14 08:16:57 +00:00
hjk
164ae1428e ProjectExplorer: Move RunControl related classes to separate file pair
Change-Id: I5da56f80336673d595907abcc797f628be680cd5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2019-03-13 14:44:46 +00:00