When applied to the QPlainTextEdit, the first selection for a range wins.
We want "OtherSelection" which is used for links to win, so we "sort"
it to the beginning of the final list.
Change-Id: Idf84c92ad5bd12d9f6ad6381f7e556e51ee459a9
Reviewed-by: David Schulz <david.schulz@qt.io>
And clean up a bit.
Change-Id: I735c5af3d2806b78564095c9ad0f748f2821e787
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Check m_processor again after starting. There is a callback resetting
the processor and we cannot ensure that starting the processor does not
result in calling this callback.
Change-Id: I4dca31399fb5224234c81df36edcb7b75d9ceaef
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This led to an assert in QSFPM because it got confused by the
nested reset signals.
Detected by adding
new QAbstractItemModelTester(this, QAbstractItemModelTester::FailureReportingMode::Fatal);
to the OutlineModel constructor, and just opening QtCreator on a small
qmake-based project.
Change-Id: I41dbc81b5a2275521ece6b865115e1428e07ecf7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This apparently canh be triggered from a delayed
LanguangeClientManager::deleteClient() when the Client
checks isShuttingDown in its destructor.
The triggering code path probably should change, but this
here avoids the crash.
Change-Id: Ic39640b5465bcf14645510b925e00b9977351eac
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... and make use of that in TextEditor::RefactoringFile.
This allows calling code to have fine-grained control over which parts of
a refactoring should get re-formatted, while also providing sensible
default values that are "almost always" right, so things typically work
as expected out of the box.
Change-Id: I9200c2135b7477c33bc5a61c5d410b34853e4b61
Reviewed-by: David Schulz <david.schulz@qt.io>
Install the language server into the Qt Creator resource directory
instead. Reuse the server for all interpreters with the same
version. This also reduces the amount of editor toolbars asking the user
to install a language server for a specific interpreter.
Change-Id: I48ef4ad30fe0097ee8d2b855b0f278e98be5ce57
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
On Windows upon a CMake file change and save during a build, the
reconfiguration would fail due to the inability to save the build.ninja
file.
Fixes: QTCREATORBUG-30048
Change-Id: I68bec70b0a95bc4256b736a1c4caf1b4d706e43b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The command passed to bash as argument needs to be quoted.
Task-number: QTCREATORBUG-29981
Change-Id: I0e91ab4c088f8cd4e5a2df82604ea86cf73369fc
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
... for the MiniProjectTargetSelector.
Instead, use a maximum width relative to the main window width,
similarly to what we did for the height in
ef00a7e28b.
Fixes: QTCREATORBUG-30038
Change-Id: If3de0460ea8e9ce43bfc795d6aba9d466c141313
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The default value was not correctly converted to a QVariant.
When a LibraryAspect was de-serialized from the default variant value,
it would create q QVariant<QMap<QString, QString>> which cannot be converted
to a Store by Utils::storeFromVariant and would end in an assert therefore.
Change-Id: I6f7b14d78793a07f027a6b375bc554941ffb83de
Reviewed-by: David Schulz <david.schulz@qt.io>
We forgot to reset the state, which gave us a permanently broken run
control, preventing re-starting the application, among other things.
Change-Id: I7c168e31e015fdf7002c57aba0ed2178437a15ae
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
For plugins that are still provided, but are no longer supported.
They are disabled by default and show a "unsupported" hint in the
plugin manager (similar to "experimental" plugins).
Change-Id: I6ad72fc0043900b5aa919c225ae94850d1d7a443
Reviewed-by: hjk <hjk@qt.io>
Do a copy of future interface inside the lambda body instead.
Change-Id: If84e37c62e43b815cfea0b5f60fe7fcebca63093
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Adds a full copy of KSyntaxHighlighting::Repository class
to the Highlighter class, enabling the relocation of the
Highlighter class to a separate thread. This adjustment ensures
that all Definitions come from the copy of the repository, making
them immutable from external code.
The "reload Definition" function stays supported, as triggering
it results in the recreation of the highlighter for the document,
thereby reconstructing the Repository class.
Change-Id: Id7a4d865228c7e7e20e4770601a3fde55b8a6513
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
