We need to store the source text document so that when the editor
is remove and the user triggers undo/read, the pointer is still valid.
Change-Id: I571906db1c4424455172a42d72351cd9ba1e7c03
Reviewed-by: David Schulz <david.schulz@qt.io>
Since m_focusedArea is always a sender of the signal connected to the
onFocusedDockAreaViewToggled() slot, reuse it in place of sender().
Change-Id: I17b817132c8b74e825f0accb9c1d467bfdf24ac3
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
We have to take into account that signal themselves
are considered dynamic properties, but do not require
the changed suffix.
Task-number: QDS-10977
Change-Id: I6af83586eee1b8f37e0510839baecee42972494c
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Also hide the code icon from effect maker
Change-Id: I1045a0718b5b86ef13164e215e5f0f1420487497
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Qt Creator should only be built and be running on macOS 10.14 or later.
This cleanup is in preparation for other following changes.
Task-number: QTCREATORBUG-29783
Change-Id: Idd549051b899726f2db8fed320a2ef15e948d2d7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Rather, emit directly in sequence. Saves a few cycles in the
signal/slot machinery simplifies reasoning on the user side
which signals to expect.
Change-Id: Ib75f47a73e9731b506b9df3c713684a9cf59aa67
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Fixes a Windows test failure in CompilationDatabaseProjectManager.
Change-Id: Ic373b7a50b1374be4cf028fc304442c3cf077735
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The tool is already shown in the perspective selector, and the view
shows the found diagnostics.
Change-Id: I0c9f7e1aa21801c176623ecb751412637ff6c025
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Type annotations were being removed by the reformat action. Write out
the relavant annotations in ast to fix it.
Add exclusion mechanism in tst_qml_reformatter test since it performs
line by line comparison which doesn't fit all reformatting cases.
Introduce char-by-char data tests.
Fixes: QTCREATORBUG-29061
Change-Id: Ia52b51e6d7d938bdec325c4f426b11c722f85f8e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
They are reasonably standardized, and generally usable cross-plugin,
so this can help to avoid a few cross-plugin compiletime dependencies.
Change-Id: Icb2b010c3e12dee69df54ab16f6f8e90d9cffba6
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
We don't pass the correct value "c++header" to the -x option, because to
clang that implies building a precompiled header, which apparently
switches on some different mode that breaks clang-tidy and clazy.
On the other hand, with "-x c++" clazy now thinks that this is a source
file and frowns at "#pragma once". Suppress this warning for header files.
Amends 60fca0596a.
We might run into similar "header vs source" problems in the future. I
don't see anything better than suppressing them one by one.
Fixes: QTCREATORBUG-29781
Change-Id: Ia15ac5b278777e2b2e089e9d58bb7537c38955ce
Reviewed-by: David Schulz <david.schulz@qt.io>
This is a workaround for the ugly hack that QmlDesigner forces the
EditorManager to send a currentEditorChanged signal with QmlDesigner's
custom, internal IEditor.
The currentEditorChanged signal triggered an update/re-creation of the
outline widget *for that editor*. Which is not the intended result in
the first place, but even aggrevated by the fact that QmlDesigner never
calls currentEditorChanged with the actual
EditorManager::currentEditor() again.
Work around that by only ever using the EditorManager::currentEditor()
for the outline widget.
Fixes: QTCREATORBUG-29653
Fixes: QTCREATORBUG-29702
Change-Id: I39c5bee94141a0d86c0e92879eb8b1c2b7ba64b9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
More canonical.
Also remove two unused slots markers plus a bit code cosmetics.
Change-Id: I4015ffecc5cb2f7d0bb7d8e35c4a59c425a42a6d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
"GDB" and "GDB Extended" tabs have been combined into one tab.
Task-number: QTCREATORBUG-29392
Change-Id: I5f5e40399abf20d61cf0e2cd4e4c1f02dfc1404c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The "Enable auto format on file save" check box was removed
and the group name turned into a check box.
Task-number: QTCREATORBUG-29392
Change-Id: Ic9b01191e523e234431f18ffceb42b9c332bcf5c
Reviewed-by: hjk <hjk@qt.io>
There is no need to have an extra file for one struct that is only used
inside texteditor.cpp
Change-Id: Iee8f7ce5e0d19da7b444660d81c350eb10b501ef
Reviewed-by: hjk <hjk@qt.io>
If the kit includes a correctly configured sysroot gdbserver will tell
us our hostPath. Respect that hostPath if it exists, otherwise fall back
to remote debug.
Also, populate the hostPath with the symbol file from the run
parameters.
Task-number: QTCREATORBUG-29614
Change-Id: I3838cd44aa96d7dfcd4ded660b8102a1532c5362
Reviewed-by: hjk <hjk@qt.io>
