Amends 796053d7.
After all, the defaulted destructor of the class did some actual work
via the destructors of the QScopedPointer members.
Change-Id: If6dc8a3d57961ec263fced11f9fa9f7e9f8c54cc
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
I had to rename the BinEditor class as moc apparently
stumbles over the same-named namespace:
In file included from /data/dev/creator/src/plugins/bineditor/bineditorplugin.cpp:529:
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc: In member function 'virtual void* BinEditor::Internal::FactoryServiceImpl::qt_metacast(const char*)':
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:40: error: 'FactoryService' in 'class BinEditor::Internal::BinEditor' does not name a type
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:54: error: expected '>' before '*' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:54: error: expected '(' before '*' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:55: error: expected primary-expression before '>' token
/data/dev/creator/src/plugins/bineditor/BinEditor_autogen/include/bineditorplugin.moc:227:62: error: expected ')' before ';' token
Change-Id: I736dc89c270f4245806792b0e350d7155f027a19
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
It's not meant to be used from the outside.
Change-Id: I94e46f95f896fa4b44e77e0196523beb8afdf8c3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
It's not meant to be accessed from the outside.
Change-Id: I0652ec8309e678a9b28e05acab6d0f77a0b13639
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Before deploying we check if the provisioning information includes the
device that is deployed to. This suffers from the same issue as
QTCREATORBUG-21291: We use the USB identifier for the device ID in Qt
Creator, which cannot contain dashes, but the iOS hardware udid that
Apple uses can contain dashes (and the USB identifier then is that udid
without the dashes).
We need to use the iOS hardware udid when checking for the device in the
provisioning information.
Fixes: QTCREATORBUG-30158
Change-Id: I6f9e162ad6ece02370923ea59c046f439b8cc47a
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Instead keep a list of "vanished targets".
These are shown in Projects mode in a separate list under the list of
kits. Via the context menus of those items (or with single-click), the
user can choose to either copy the steps of the vanished target to
another kit (already configured or not), or to create a new replacement
kit for it (similar to the previous replacement kits, with the same
device type and the steps restored, but no other parameters from the
kit restored - the project doesn't save that information), or remove
them.
The vanished targets are not removed from the project's settings as
long as the user doesn't create a kit or copy the steps, so if the kit
re-appears on a later run of Qt Creator, the original target is
restored for that kit and the entry in the "vanished targets" list
automatically vanishes.
This has the advantage that in contrast to the replacement kits, the
vanished targets are clearly separate from "normal" kits, and that they
are local to the project. Nothing is left behind after closing the
project.
Change-Id: Iccec04fea38cd55ff683665c9cf4edc9a2388c82
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Not quite the standard setup yet, but getting closer.
Change-Id: Ifadc0b07b9d3f43381d5f49848c49bcc1d069861
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
... and clean up/modernize a bit and use new setup pattern.
Change-Id: Ie1b5f8da1fcc884a32869db2ce0f43e97e0f3aab
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Checking the existence of qGuiApp isn't enough, since the
implementation just static_casts qApp to QGuiApplication.
The issue might happen in autotests if some function calls
methods of QGuiApplication. The autotests instantiate just
QCoreApplication by default.
Change-Id: Id384fb21b2a2ad66fac59bf5de35668ce50df1d1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Instead, iterate directly over the container.
Notably, sorting the result of keys() didn't play any
significant role in this contexts.
Change-Id: Iba82f3d503143ff0036509d0bf08c87747aeb40c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Update information about changed or added features.
Task-number: QTCREATORBUG-29361
Change-Id: Ia318b987602141f0021abd561ce3aac1d405904f
Reviewed-by: David Schulz <david.schulz@qt.io>
