Commit Graph

85691 Commits

Author SHA1 Message Date
Thomas Hartmann
5ff6fe0eba QmlDesigner: Add missing qualification
This was leading to random errors.

Change-Id: I51ec0c71ac1bd3ea7bd966eeb4d3a2b9cfeb0159
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-09-18 13:53:35 +00:00
Miikka Heikkinen
461340d245 QmlDesigner: Tie 3D helper grid to snap interval
Helper grid minimum step now changes to match set snap interval.

Fixes: QDS-10624
Change-Id: I82b8206774b3769bee19be5eb0f38930f3b49c12
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-18 13:52:55 +00:00
Christian Kandeler
88ddecd281 qbs build: Fix wrong uses of qbs.toolchainType
qbs.toolchainType is a convenience property to *set* the toolchain in a
profile or on the command line. It must not be used to check for the
toolchain.

Change-Id: I97e3a2baceca4233db97f33b9fa8f2bc61abbcf3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-18 13:31:37 +00:00
Amr Essam
7b183a774c QmlDesigner: Move effect maker to an independent plugin
Task-number: QDS-10656
Change-Id: I1c1e67d3461650bfaec46ccc10b832effce76ad9
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-18 13:23:06 +00:00
Miikka Heikkinen
a6e8a247b3 QmlDesigner: Fix minimum value for NumberAnimation to and from fields
Change-Id: Ic5fcb1d69ab0c3369dacbc93da71714b20253e25
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-18 13:03:43 +00:00
Thomas Hartmann
6dc4243995 QmlDesigner: Choose proper default signal
Change-Id: I2a9493d0cc2a49afd624d58b53df54686d827422
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-18 12:56:09 +00:00
Thomas Hartmann
c693bd06b3 QmlDesigner: Fix toolbar height for non QDS styles
Task-number: QDS-10687
Task-number: QDS-10596
Change-Id: Ia4a7e958c6719cafa3a3fe2fea588cbd20c5b703
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-18 12:47:16 +00:00
Aleksei German
106bb82d73 QmlDesigner: Remove Connections Editor action
Task-number: QDS-10606
Change-Id: I0b0d4364e6c80eddee3bb1d8b8491c8c00542593
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 12:42:51 +00:00
Aleksei German
4949c1911e QmlDesigner: Add code preview indentation
Task-number: QDS-10680
Change-Id: I61528f517ed4baef2115fbddf1b014b9f7f966d2
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 12:42:46 +00:00
Alessandro Portale
eec022ac85 WebAssembly: Cache emsdk_env and toolchain --dumpversion results
Stores the results of emsdk_env and --dumpversion in the settings
database. Also stores the modification time of the ".emscripten" file in
the sdk root folder in order to validate the cached entries.

Change-Id: Iacb907ee6d8cd9f4c14d33a6ad425ec684c66238
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-18 12:27:58 +00:00
David Schulz
09b347d0d3 ProjectExplorer: fix gcc toolchain detection on windows
Change-Id: Ibf23eeca79389562bc38a01ca9ec7799e22787fe
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-18 12:12:02 +00:00
Christian Kandeler
bdded29b33 qbs build: Improve some base items
Clean-up, simplification and modernization.
Also fix the bugs uncovered by this.

Change-Id: Ia3a77557f10faf9a901540a55fd6c07a2e986bf5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-18 11:50:09 +00:00
Christian Stenger
2842eeeecc AutoTest: Start renewal of wizard
Remove option for enabling C++11 for gtest. C++14 is minimum
nowadays when using a recent gtest version.

Change-Id: Iaa1c07be37fba0ee80d3bc46cef7238e91a541cd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-18 11:26:08 +00:00
Christian Stenger
23fffcb429 AutoTest: Fix creating cmake and qbs based test projects
Fixes creation of test projects for GTest, Boost Test and
Catch2 when not using qmake as build system.

Change-Id: I2fee3bcacf310e6dc4dbdd50bf8bd445dfb74328
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-18 11:25:58 +00:00
Eike Ziller
b72f9dc8ef OutputPane: Add Reset to Default to menu
Resetting the visibility of the buttons to the default.

Change-Id: I0f8bf1cd9c33ac0a318e992526657c564f51f170
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-18 11:10:26 +00:00
Jarek Kobus
9d3fca4edc BuildManager: Disconnect instead of connect
Amends a140a93067

Change-Id: I88a3d62adf80f213b9772fd190c21052596829a0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-18 11:04:19 +00:00
Eike Ziller
39fdfc9e0c OutputPane: Modernize menu
Use lambdas instead of user data.

Change-Id: I66585df8de2f1f3ea42f66c6f3b0df7d4d3f3f01
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-18 10:15:27 +00:00
Eike Ziller
b0043ed1ac OutputPane: Use setter for priority and fix default visibility
Do not show the buttons of output views with priority < 0 (instead of
only == -1). Reduce the number of buttons that are shown by default to
the essential ones.

Change-Id: I5b44f18537b3033ce9d616f044a8b54b76988783
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-18 10:14:51 +00:00
Eike Ziller
053c6253b8 OutputPane: Add an id() for the settings
It was using the displayName for the key in the settings (visibility and
shortcut), which is annoying when changing the language.

Change-Id: Iffa784347c59389599c90f468dcba15834599c39
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-18 10:14:42 +00:00
Eike Ziller
409a4c972a OutputPane: Use setter for display name
Change-Id: I2e89fbd052330c9e7124272c2f2fa81a0db94de9
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-18 10:14:35 +00:00
Marcus Tillmanns
11c7cd0c9d Utils: Fix access after delete
Change-Id: I8bd120e39de202618044c0812f423653b914f4bc
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-18 10:14:25 +00:00
Miikka Heikkinen
516a2238e2 QmlDesigner: Ensure we save the latest values on 3D snap dialog close
Track value property of spin boxes changes directly instead of the
extra valueModified signal, which is not emitted in all cases.

Also removed duplicate applying of snap configuration.

Fixes: QDS-10653
Change-Id: If0ce7bffa1dcfb5b01e80b6e962f356f91f44d51
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-18 10:09:31 +00:00
Miikka Heikkinen
1a88cf1446 QmlDesigner: Open 3D view toolbar popups to correct position
The button that is shown under extension menu is not actually the
same button widget that is tied to the action, so we need to resolve
the menu position based on toolbar dimensions in that case.

Fixes: QDS-10635
Change-Id: I0c2319041638f9f1cb19f3e57fccbb993e31c743
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-09-18 10:08:48 +00:00
Henning Gruendl
44699727ad QmlDesigner: Close dialog when view loses focus
Change-Id: Ib48229615ee9b2ccef1a8be98086a93851dae6af
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-18 09:58:43 +00:00
Christian Kandeler
18372ca553 TextEditor: Do not make one-letter doxygen commands end a rewrap region
In 8e118e9d5e, we stopped re-wrapping in
comments when a doxygen/qdoc command appeared at the start of the line.
However, there are also "inline" commands such as \l and \c that can by
chance appear on the start of a line and should not stop rewrapping.
Since we are still quite reluctant to enumerate and categorize the
countless doxygen/qdoc commands, let's just ignore all one-letter
commands for rewrapping purposes.
(Yes, this is another hacky heuristic.)

Fixes: QTCREATORBUG-28761
Change-Id: I40d77706851ec24504d6fd8795906dd55249661d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-18 09:18:02 +00:00
Eike Ziller
e371cd2369 Make warning about using MIME database early stricter
The MIME database should really only be used after the UI is shown,
since initializing it takes time.

Now that restoring sessions/files from the command line/settings is done
after delayedInitialization, also warn if anyone uses the MIME database
before the delayedInitialization really begins, which is after the UI is
shown.

Change-Id: I94b0e4bd9bd790a61befd3009851ea0530a25ab9
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-18 09:12:43 +00:00
Eike Ziller
431583872a Session: Restore session/open files after initialization
Only restore a session or file from the command line (or the setting)
after initialization is completely done.

Kit restoration moved to delayedInitialize, and before that we cannot
sensibly open a session anyway.

Change-Id: I73b984a8744729ea63af16b1f0161b49a2cd5d55
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-18 09:12:23 +00:00
Eike Ziller
116a51343e PluginManager: Do not allow user interaction during delayedInit
The purpose of delayedInitialize is to have some UI that can show the
main window and potentially progress information, but user interaction
is not really supported during that phase, so prevent it.

Instead of using a timer between different plugins during
delayedInitialize, just give the event loop a chance to run.

Change-Id: I1d67da228d6358103cf8073deed5275a7ace9f3a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-18 09:12:03 +00:00
Christian Kandeler
9371afde4a CppEditor: More FilePath-ification in correspondingHeaderOrSource()
Also, fix a double look-up in a map.

Change-Id: I5ddddb509b0dadb52a227053ac968e049ab72826
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-18 09:07:00 +00:00
Jarek Kobus
bd84337d33 BuildManager: Remove unused variable
Amends a140a93067

Change-Id: I9014e42727c498866d1bd170f4cf7594f11dcfbb
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-09-18 08:54:20 +00:00
Cristian Adam
e37bbb8e03 CMakePM: Show link for Ctrl + mouse for functions/macros in editor
Amends 4d358ae337

Change-Id: I7f89a1c2e4a32ec8944995074d0198e960a9d798
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-09-18 08:33:03 +00:00
Eike Ziller
6cc11b21c5 German translation: Squish
Change-Id: If4a4be5a308d842a7441e054ed6028011f4aeb84
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-09-18 06:49:07 +00:00
Marcus Tillmanns
5109b0ce0e Docker: Fix default device name
Change-Id: I1d7e8dd62a11cf897ebb22389f21370c8a3811cf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-18 06:48:51 +00:00
Henning Gruendl
f25ce01ead QmlDesigner: Close dialog when view loses focus
Change-Id: I4666953ff862886fbb02fb3982d6856a223fe969
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-15 19:50:41 +00:00
Brook Cronin
a496ac5d02 QmlDesigner: Design fixes for connections popout
Change-Id: I06968cfef23f8b296f1ba6b07e57cdc96701447b
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-15 17:21:33 +00:00
Henning Gruendl
5aa3e573ce QmlDesigner: Fix empty literal remove
Fix issue that literal token is not immediately when pressing backspace
and text is empty.

Change-Id: I7ba2401ad6adfa689f697188feb7b30a71d82eeb
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-15 16:58:01 +00:00
Henning Gruendl
9b2d6f5edd QmlDesigner: Fix Connections Popup layout
* Set proper width on labels
* Set proper width on StatementEditor
* Forward backend property into StatementEditor

Change-Id: Ia0db6ff7f235bd8d25eb0f36124fa158b76aaf04
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
2023-09-15 16:57:51 +00:00
Henning Gruendl
55034b1cde QmlDesigner: Pill redesign
Change-Id: I3c28599c3cbc1555fbdb206e387dccf6f45a77cd
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 16:57:34 +00:00
Thomas Hartmann
fedb38a0f5 QmlDesigner: Priotize 3D related properties
Task-number: QDS-10682
Change-Id: Ib75877257ea34edfa539a198e56d9499810aca15
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 15:12:46 +00:00
Thomas Hartmann
1a1e898f0f QmlDesigner: Set Core::ICore::dialogParent() for QML windows
Change-Id: Ie09c7255495456cb76e94504392c9474e2a88688
Reviewed-by: Brook Cronin <brook.cronin@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-09-15 15:12:38 +00:00
Knud Dollereder
b18b7920bb Refuse to add properties from unselected nodes
... and select property after adding it to the model.

Change-Id: I4210e9b1e27b3d396ba5f421629a2b90d2771f50
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 13:23:02 +00:00
Thomas Hartmann
5ca59da1af McuSupport: Do not regularly restet code mode in QDS context
Resetting the code model on a regular base has quite a
negative performance impact and also generates unexpected
code paths and updates.

Change-Id: I5a62166d714beb6cc6c9a64333abf093a5a87ac6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
2023-09-15 13:11:45 +00:00
David Schulz
85cba79cd2 ClangCodeModel: fix setting refactoring markers for clangd
LanguageClient::updateCodeActionRefactoringMarker overwrites previously
set refactoring markers.

Fixes: QTCREATORBUG-29493
Change-Id: I156b4e2ff65aed5928251bfea184e093df686818
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-09-15 13:09:09 +00:00
David Schulz
0b85fc5aa0 ProjectExplorer: reduce the perceived startup time
... by moving restoreKits to the delayed initialize phase.

Change-Id: If72e41b64ee71f2917b3f7a317d9887afc6e29e8
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-09-15 13:08:49 +00:00
Christian Kandeler
f1fa1ad3d9 CppEditor: Speed up findFilesInProject()
This function had a number of serious performance problems. As it is
executed by several quickfix factories, it could cause freezes on right-
clicking a symbol.
Measures taken:
  - Check file type before file path.
  - Do not collect all files in the project first, but filter earlier.
  - Check all candidate file names at once.
In an example project, I observed a speed-up of factor ~100.
Some FilePath-ification was done as well.

Task-number: QTCREATORBUG-29611
Change-Id: Ic5dc48ffd86f22263d1caea4b6bfea5f49e589a4
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-09-15 13:07:36 +00:00
Marcus Tillmanns
67bd5fc359 Utils: Add StringSelectionAspect
Change-Id: I73b5c964be1222f56fcc01f30d17506f92d1f6b2
Reviewed-by: hjk <hjk@qt.io>
2023-09-15 13:02:07 +00:00
Marcus Tillmanns
b81026488c Docker: Improve error reporting
Change-Id: I1a1ad824b4084ce7203357acf9ec19ccfe91b5cd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: hjk <hjk@qt.io>
2023-09-15 13:00:39 +00:00
Miikka Heikkinen
f3036d52e5 QmlDesigner: Fix dragging 3D snap configuration spinboxes
Changed to use HelperWidgets.DoubleSpinBox, which has the proper drag
support built into it and implemented required context functions.

Fixes: QDS-10639
Change-Id: I6fce39251d7f754985f95bba5784784fc6eb8fae
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
2023-09-15 12:52:30 +00:00
Henning Gruendl
b73b94d27a QmlDesigner: Remove anchors from positioner child
Change-Id: Ibff848d5f80ac74491ab77e88baffb4d0e1454bf
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 12:48:05 +00:00
Henning Gruendl
954385c34d QmlDesigner: Fix wrong role name
Change-Id: I195ead9ade9c4bc430bdee630f533e6e04e15027
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-09-15 12:47:54 +00:00