Commit Graph

85691 Commits

Author SHA1 Message Date
hjk
6e307be365 Utils: Rename the new Storage to Store
Apparently that's what the young people on the web use for such a thing.

Change-Id: I75d5396ff3cb3c26efd6008b5f2261354c4f7896
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-24 05:56:57 +00:00
Marco Bubke
ddde6b1ea5 UnitTests: Silence padding warning in tests
It is not very useful here and adds a warning for every test.

Change-Id: Iaf75385f90ebbe3d0ac9a306328ba56c489ea6cf
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-08-23 21:53:08 +00:00
Friedemann Kleint
14d21f4f2c Designer plugin: Simplify connections
Connect to members instead of using lambdas.
Amends 93de403391.

Change-Id: I401f550ee3f2e3a12086b064f698ec2fc8b5aca6
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-08-23 18:50:31 +00:00
hjk
ff647966e5 RemoteLinux: Disable private key path chooser unless key use is selected
Fixes: QTCREATORBUG-29534
Change-Id: I55b0869083ad10a43b635c79c33466b016540a41
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-23 16:28:15 +00:00
Yasser Grimes
3edbdc9290 McuSupport: Allow the Text.textFormat property in QtMCUs 2.6
Task-number: QDS-10506
Change-Id: Id72641b1c309b99feab5edb51a31f2a487e82b79
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Aleksei German <aleksei.german@qt.io>
2023-08-23 16:17:47 +00:00
hjk
5aa503d3d3 Utils: Compile fix
Change-Id: I7b3298313d16b778ba471330d4d019f7e6d92b92
Reviewed-by: hjk <hjk@qt.io>
2023-08-23 15:04:01 +00:00
hjk
753c00543d Utils: Introduce a Storage class
... mapping Keys (currently QString) to Data (currently QVariant),
i.e. effectively an oddly named QVariantMap.

Plan is to

    1. make QVariantMap using loading/saving related functions to use
       Storage instead of QVariant map,
    2. replace QString by a UTF-8 container (QByteArray for starters)
    3. add/remove parts of the map interface so that neither decoration
       of string literals in user code are needed, nor that
       unnecessary allocations happen.

Long term Storage could cover some of the current JSON uses, with
Storage's implementation possibly switching over to something
based on JSON (or CBOR?) directly, to be closer what we typically
send over the wire.

Change-Id: Ic33b8e95fed5268d6298b5391ff42cbb582b56c4
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-23 14:58:52 +00:00
hjk
dc6b40a5c0 Use Utils::Storage instead of QVariantMap in a few places
Change-Id: I02833cf2bc3caaadc22ff93ae530e4aebe4c3868
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-23 14:30:50 +00:00
Marco Bubke
22166404f3 QmlDesigner: Use system includes for google test
System includes are silencing warnings.

Change-Id: I7d7954e01a28f94aa5983cfc44eba976d97b0311
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-23 10:50:09 +00:00
hjk
55b5b8a975 CMakeProjectManager: Fix connection to save tools settings
Amends 4e23f2a6eb.

This should actually not be needed in the end, and rather steered
by the auto registration and settings page apply.

Change-Id: I7f94e776fec4394f539e32e5c527c367251654a8
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-23 10:47:10 +00:00
David Schulz
6e6587c528 ProjectExplorer: allow adding expanding project settings widgets
Change-Id: I27dee2a8d1b14d1dcc535669e3dc9c5369ec2c81
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-23 09:14:44 +00:00
Marco Bubke
e0314c8204 QmlDesigner: Prefer std::get_if to std::get for variants
It cannot not throw, so no exceptions code is generated. And it is quite
often shorter too.

Change-Id: Icd555cedb880a1547b0ddcbcdd74fc21feb83ccb
Reviewed-by: Ali Kianian <ali.kianian@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-08-23 07:57:55 +00:00
Ali Kianian
7f323ee1b3 QmlDesigner: Move pruneChildren to ModelUtils
Change-Id: I77a799d351b7f95e901b32a4b5f7e39b9450c8c6
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
2023-08-23 07:56:59 +00:00
Eike Ziller
13fa7703a4 Merge remote-tracking branch 'origin/11.0'
Change-Id: I6c2a1d497aae9bda45c4aae47fb0be6c61c1ec29
2023-08-23 09:30:32 +02:00
Dominic Ernst
72480f5dd6 Todo plugin: add \todo keyword to default settings
As Qt Creator supports Doxygen style comments, the Todo plugin should
also find the \todo keyword by default.

Change-Id: Ic0acbcfe610b7752acfd77dfcc6717895f6e97b7
Reviewed-by: hjk <hjk@qt.io>
2023-08-23 05:43:56 +00:00
hjk
6216c0e924 ProjectExplorer: Don't use object names for KitAspectFactories
Not used. Also the debugger knows the typename and these are
singletons.

Change-Id: I577241876318aa2930bbc36f454846ffa47cb571
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-23 05:38:50 +00:00
hjk
a7630f999f Android: Use a aspect for AndroidBuildStep::buildAAB
Testing the water...

Change-Id: Ic5bd970519f0ec11e03ba19a24e0aeb2a84a18e3
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-23 05:38:18 +00:00
hjk
45bae4b525 ProjectExplorer: De-Q_OBJECT-ify FilterTreeView
... and rename some local variables.

Change-Id: Ia54a96a4f40c7f4b5ded29df34a12e718d86bd3c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-23 05:37:47 +00:00
Tim Jenßen
0f05d7adb3 cleanup QMessageBox includes
Change-Id: I358a216c48b8fbf549af38360a93a073f03e3a98
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
2023-08-22 16:56:50 +00:00
Jarek Kobus
201b28f362 Android: Unexport Android plugin
It doesn't seem that any class from this plugin is used outside.

Change-Id: I88a63e4c41cbd4b20f0de8bbd05668f55bafdc97
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-22 15:15:13 +00:00
Jarek Kobus
53f16e9b49 AndroidManager: Remove some unused functions
Hide one internally used function.

Change-Id: If286880397a1c6fd808b3eee22332e905911f4d1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-22 15:14:52 +00:00
Jarek Kobus
c72734e678 AndroidManager: Make it a namespace
Unexport it, as it seems that no method is used outside of the
Android plugin.

Change-Id: I5c76234a1f37ddfa3dcfa51ded5a441163ec9093
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
2023-08-22 14:52:56 +00:00
Mahmoud Badri
733c276a4d QmlDesigner: Add some effect maker uniform UI value types
Change-Id: I13516f5bcbf6e15591fc2ca81e0aa9c7eb9e9c64
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
2023-08-22 14:52:50 +00:00
Andreas Loth
020d4c72e4 Axivion: Use type aliases from updated Axivion Dashboard DTO generator
Change-Id: I4e27c90d643d4e4ca33fde8dc0ae6e62e6a78fb6
Reviewed-by: hjk <hjk@qt.io>
2023-08-22 14:09:29 +00:00
Jarek Kobus
c8a25e8fd9 AndroidManager: Cleanup includes
Change-Id: I779eadcc978e76adff8f6e4a0671f3db6a2a2402
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-22 14:01:23 +00:00
Jarek Kobus
8bdf70e271 AndroidManager: Use Utils::Process for startAdbProcess()
Change-Id: I675d0103bee854af67d379d08a7e0ddbc6654e8d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-08-22 13:59:19 +00:00
Christian Kandeler
b33b99e2d9 ClangCodeModel: Take changes from header files into account immediately
... in the dependent sources. That's also how the built-in code model
behaves, but clangd itself only does this when a document is saved.

Change-Id: I52d6badb0b7f063e5924c05dbf83a6e9849c9f6f
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-08-22 13:59:04 +00:00
Marcus Tillmanns
73c5cf29c4 Utils: Add missing connections to validChanged
FancyLineEdit and PathChoosers valid state can be
asyncronously update, so users need to connect to the
validChanged signal to correctly update the UI and not
just to textChanged, or rawPathChanged etc.

Fixes: QTCREATORBUG-29525
Change-Id: I706fef61f6228af7dae9271a146cf739c3202cc7
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
2023-08-22 13:45:46 +00:00
David Schulz
806e24138b LanguageClient: send out empty workspace configurations
... instead of an error when the server asks for the configuration even
if we do not provide a way to configure workspace configurations yet.

Change-Id: I0d330b47a12627af100bf9d9b1eec34a58d6471b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 13:42:37 +00:00
Christian Kandeler
2f6bec1d48 ProjectExplorer: Fix clipping problem in issues pane
Add the missing call to QTextDocument::setTextWidth() in the delegate's
paint() method, add a workaround for invalid QStyleOption::rect in
sizeHint(), take item indentation into account.

Fixes: QTCREATORBUG-29458
Change-Id: I56d9f942d6c82dfac82d357ca0f16138ed39150d
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 13:41:49 +00:00
Marcus Tillmanns
3024c1314e Utils: Speed up isDirectory for roots
Change-Id: Ic369bb1b6a5deb84f0da38af7e71d51139a67c9e
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
2023-08-22 13:28:16 +00:00
hjk
45e3fa1621 ProjectExplorer: Simplify KitAspect::addToLayoutWithLabel()
The parent widget was not used anymore.

Change-Id: I57bb024b770c01efc68bb722623bcc7fb565cfeb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 13:14:02 +00:00
Marcus Tillmanns
882397d53d CMake: Remove outdated check
Change-Id: I490a68f9b4719c65b4058f5263b13bc5979fd6b2
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-22 13:00:56 +00:00
hjk
4e23f2a6eb CMakeProjectManager: Hide kit aspect factory implementation
Also avoid re-instantiation of factories in the build configurations.

Closer to the setups of the other kit aspect(factories).

Change-Id: I1b74a68287b63ee94ff18106d3a00b23624a601b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 12:56:12 +00:00
hjk
effcc0d471 Project: Inline kitmodel.{h,cpp} into kitoptionspage.cpp
The only user.

Change-Id: I4fea0752c68b70eb1fe6d9db561d70830b6174aa
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 12:48:42 +00:00
Miikka Heikkinen
3ca4b37e3c QmlDesigner: Hide selection box for 3D scene root nodes
Fixes: QDS-10501
Change-Id: I31477f6ef241aab8d400bae174e3928c47c5c189
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
2023-08-22 12:36:06 +00:00
Christian Stenger
0a83f33bad CMakePM: Remove unused include path
Change-Id: Id48ea93a1b9728c7cd68cfa3f52620a799909371
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
2023-08-22 12:06:47 +00:00
David Schulz
a066a0d290 LanguageClient: Fix ConfigurationItem scopeUri type
'scopeUri' should contain a DocumentUri and not a QString according to
the protocol (https://microsoft.github.io/language-server-protocol/
specifications/lsp/3.17/specification/#configurationItem).

Change-Id: Ibdec5f22cdce4dc1b5e3e0ef264cdc0458c124f1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 12:06:16 +00:00
Ali Kianian
f018ea6d8b QmlDesigner: Implement Connection Editor Evaluator and Parser
An AST Visitor checks the correct structure for the connection editor
Statements are parsed as the result
Javascript statements could be resurrected
Some tests are added

Task-number: QDS-10257
Task-number: QDS-10288
Change-Id: Ia6e4f9c0f48678b6610941c977b7d7bed296ced0
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-08-22 10:48:58 +00:00
Marcus Tillmanns
5399588e4d RemoteLinux: Don't use SFTP if source is remote
The SFTP does not work if the source files are on a remote devices
so we fall back to generic copy in those cases.

Fixes: QTCREATORBUG-29524
Change-Id: Iecb2723dfcbb65653ce6f793dc2d7253979540a5
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 10:14:42 +00:00
Marcus Tillmanns
124cd2f31a RemoteLinux: Don't try to create existing dirs
Change-Id: Ia3af92470d285874c2e469f6ec95cc8c4f412daf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 10:14:35 +00:00
Henning Gruendl
6cb3e6ec9d QmlDesigner: Fix top toolbar workspace selection
Task-number: QDS-10494
Change-Id: I1f055f7bed7a76df76d733ff8d17e190485ab76d
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
2023-08-22 09:30:23 +00:00
hjk
6b82b29e23 ProjectExplorer: Down-prioritize SysRootKitAspect
It's mostly used in connection with the debugger, so put it afterwards.

Change-Id: I6351b4c3db34e1b740c444c04205544ea88b8e8a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 09:11:31 +00:00
hjk
46e97ad08d ProjectExplorer: Always access kit aspects according to priority
Change-Id: Ia2f95614ccaceca22702df1f16e21bdd900a75f2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
2023-08-22 08:48:49 +00:00
David Schulz
e6b8791fa9 LanguageClient: correctly cancel running rename request
When requesting rename results while we have not received the response
to the previous rename request, we have to cancel that previous request
otherwise we end up with duplicated replace operations that potentially
can invalidate the document.

Task-number: QTCREATORBUG-29389
Change-Id: I3be425b8306c18b64fca7bb71bf65c32ae50fed1
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 08:48:46 +00:00
Mahmoud Badri
9018a7bc20 QmlDesigner: Update composition node model's value from UI
Task-number: QDS-10404
Change-Id: I6292c9371a748d6305bdf068cc0cf8f3ca907fd9
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
2023-08-22 08:41:17 +00:00
Andreas Loth
8f9e75a3b8 Axivion: Use DTO for ProjectInfo deserialization
This is a proof of concept that the DTOs can be used to deserialize and
access the data the Axivion Dashboard returns. In future, this is going
to replace all manual deserialization and manually written Dashboard
interface classes.

Change-Id: Ic3c997f6aca7fcb179cd19fa9b5107fe7d4dec03
Reviewed-by: hjk <hjk@qt.io>
2023-08-22 08:38:18 +00:00
Marcus Tillmanns
b96802b3ee SdkTool: Fix sysroot for docker devices
Using QDir::cleanPath on devices paths
destroys the path.

Also adds workaround for already registered toolkits.

Fixes: QTCREATORBUG-29523
Change-Id: Ibb331f3e4e3ec2021e517e341757499a7316b503
Reviewed-by: hjk <hjk@qt.io>
2023-08-22 07:53:10 +00:00
David Schulz
2ff5293c4a Python: Workaround pylsp rename bug
upstream bug report:
https://github.com/python-lsp/python-lsp-server/issues/413

Fixes: QTCREATORBUG-29389
Change-Id: I5b122b5e5c245cb5c43c32da1296b2132a07a9aa
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-08-22 07:37:57 +00:00
David Schulz
5122d8addc Merge remote-tracking branch 'origin/11.0'
Change-Id: Idbf5f641aa9db7574cf2a4bd09adb8bcd03da894
2023-08-22 08:10:48 +02:00