... after a StringAspect/FileAspect split, instead of relying on
the current inheritance.
Change-Id: I7dd91f402636d35a15e9d1618b73c0981777b06e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Pasting large amounts of data on macos would block the App indefinitely.
The issue was a blocking call to ::write. The first fix for that was to
set O_NONBLOCK on the tty stdout fd. The second fix was to pass the
actual result of the write back to the caller so they can react to it.
In the TerminalSurface we now check if the write was successful and
if not we buffer the data and try again later.
Change-Id: Ibc92cce57fad88b5e9aa325197b42e17bec5e746
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
... instead of a IOptionsPage-derived class.
Change-Id: Ica45b1752fc4e6f83e9dfae25c5e9dcd1fd9c9ba
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It hasn't been about just deploying Qt for a very long time.
Change-Id: I72fb070db505909500d2e68f2bafb198c3342c2b
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
The cast function is now returning an invalid variant if the meta info
is invalid. It is too not anymore converting the value magically.
Task-number: QDS-10290
Change-Id: I125aab9ac46c9ac0605364ede32fb1a10d20cd89
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Added a new Creating Projects for MCUs topic and updated the
related topics, including the ToC, accordingly.
Task-number: QDS-9288
Change-Id: Ia6e3afad48e98f549bdbb210b8ec7d3ebc5687c5
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
A confusing amount of TextCommand or Utils::Command objects or
-returning functions were called 'command'. Rename a few to make
future reasoning simpler.
Change-Id: I872b2e841cb40a4533e5ebcd37cb05489158cec7
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
It's being deleted on plugin unload, so it should be
a proper substitute.
Change-Id: I27383db72dfa0d5b0df2886b24c96266602ccbac
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: hjk <hjk@qt.io>
The GerritPlugin constructor calls GerritParameters::fromSettings()
which then calls calls detectApp() if there is no curl (or no ssh/GIT_SSH).
On Windows this ends up calling GitClient::instance()->gitBinDirectory()
which crashes as the GitClent instance does not exist at this time.
Work around by switching the construction order.
Change-Id: I0b1172d6b7ec96502a51684578b78042a42a95ca
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
They were still using variables in qmake style.
Directly use CMake variables in the json.in files and remove the no
longer needed escaping of quotes.
Adds a fatal message if it detects the old style in a .json.in file for
easier porting.
Change-Id: I8de88d8db2da55781f0e9d72eda03f943723188e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Nano does not work well with pasted \n, so we replace them with \r.
Change-Id: I2518e6e2095b5ee76e8eca55dede7ed708f21b9e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Will be used for e.g. valgrinds error categories. These are handled
by actions in a menu outside the settings page mechanism.
Change-Id: I2dea9b9f13dbc92fa3e9938f85aa083d01d0d99b
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
We will need it twice when the FilePathAspect is fully separate.
Change-Id: Ief69af0e1167d5ca5c770c3cbd16fdafa16114f7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
I have some notion where this should lead to, but we are not
there yet.
Change-Id: I402618a64dfef43c8e2089bface44ec5c822eb0b
Reviewed-by: hjk <hjk@qt.io>
It's going to be used in task tree for QbsBuildStep,
QbsCleanStep and QbsInstallStep.
Change-Id: I347562b72a628b66d648f943c2fbf67df69c0bc5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
