Save some allocations and return a view instead of a new value. If you
want a value because you depend on a null terminated string you have to
use toScope() and toName().
Task-number: QDS-10290
Change-Id: Ia87b8d559fc1fe9bb1992e61da0aa86c68d53535
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
A dict's values object is not a list as it had been in Python 2.
Explicitly convert it.
Change-Id: Iab54a5833b77c6890b108065657da3ff73c96f7f
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This is fairly close to the new "standard" pattern for an
individual page but still allows flat access using the same
'settings().' stanza.
Change-Id: I1edbbd64a857a3d3936fb2c21fdc7e3c8ae7a44c
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
The functions are doing not much but are called often. So they are a
good case for inlining.
Change-Id: I755c63287d7d518b55d4f131077b98dd0345930c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
The text editor was declared changed even in non-design mode. Now it's
notified only when the design mode is selected.
Task-number: QDS-9953
Change-Id: I64d0d7c1eec0e56d00f91e9522325ecb8660cd2d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Some menus inside QC have special numbering - but this only
applies to Linux and Windows. On macOS we do not add this
special numbering.
Additionally this patch stabilizes the triggering of
submenus. When they get triggered it takes a split of a
second until the items inside the menu are usable.
Let squish wait until the sub menu is fully present before
trying to activate some of its items.
Change-Id: I32c688a937ada1da07506d4ebd22730e4f2bcaef
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Isn't a benefit here, but what the other settings do, so it's easier
to ponder more centralized solutions later.
Change-Id: I3837e5bedc8771dd56b8bacda8c23e40281b4fe3
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Otherwise we may fail to hide widgets of aspects that are explicitly
set invisible while construction.
Change-Id: I2679c8fa22e79e4eb32ca5ae4266010d8cf9387d
Reviewed-by: hjk <hjk@qt.io>
That's the by far more common name nowadays.
Change-Id: Iae987221f9fa2e955fdee21496f895d25d44be4e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Keep a pointer to the unarchiver inside the FileExtractor
in order to not to leak it on FileExtractor destruction.
Change-Id: I517bfb5997612db36e7ca8e61709b022caf5dc09
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Not necessarily the final setup, but a step closer.
The selected style doesn't seem to stick anymore, but that's already
the case in 11.x.
Change-Id: I6c094c1222147c31456cf843397ffaaae9252a30
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Do not give them the QSettings object that has SystemScope.
Also rename the "globalSettings" term to "installSettings" locally and
in PluginManager, and the one for aspects to just "setSettings" (like
e.g. for TerminalCommand).
Change-Id: Iad051f6e507373042014db73b83d0b16944b7374
Reviewed-by: hjk <hjk@qt.io>
This was still going to StringAspect, even with the new FilePathAspect
base. Operationally it was not different as the FilePathAspect does
not do anything else than what the StringAspect was doing.
Change-Id: I3dac247acf48d653f77abb228a1765f01da7823b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Accessing gui elements is very aspect-specific, whereas the
rules when and how values are synchronized are rather general.
Splitting the two concepts and having a permanent 'buffer' area
that is synchronized with the gui elements if and only if they
have been created helps to keep the boilerplate needed per-aspect
at a minimum.
This value could also serve as "model" in case we wanted to allow
multiple "views" in different places of the gui onto that aspect.
Change-Id: I34832512b99c53cb0e4df437ee9b4c5d17a2ad8f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Not quite harmless, as it was destroying persistent data written by
the normal one.
Amends b9cf021b8e.
Change-Id: Ie2775881535c4d19174177f443a4606acc1576de
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The Process takes care of the proper destruction automatically.
This is a preparation step before creating a task tree adapter
for IosToolHandler.
Change-Id: I6a8ae12b46a83be3a7074d0a268a598c260a66b5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When the current line is modified, refresh the
blame after saving. Before, the cursor had to
be moved to another line to restart the blame.
Change-Id: I61012f1c8583545b9bc34a71ff63ade2f9cc5b13
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
