Deprecated in Qt 5.14, alternative has been around since Qt 4 at least.
Change-Id: I4e3a53c289088368609e0d0ce2405a832d311308
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
The internal build target key had changed again. Adapt and use
a more error proof pattern to be hopefully safe if it may
change again.
The wrong build target key led inside the AutoTest plugin to a
wrong comparison of build target of the project parts vs. the
build target of the run configuration which in turn ended up
in always deducing the run configuration for the test runner.
Change-Id: I32df578df85cc0206c2b8fdac00acc3a798f0d73
Reviewed-by: hjk <hjk@qt.io>
If one uses the Python - Window template and does not explicitly
change the custom base class to an existing the generated project
lacks some essential stuff.
Make the generated main file usable even for first time users.
Change-Id: I898189fd4edff88f13987d6d1df9f77e2ef6bd68
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Only use the file size heuristic on Windows, as it actually helps us
filter out duplicates there.
On Unix, there is no such compensation for the risk of false positives.
For instance, on my Linux machine, i686-w64-mingw32-gcc and x86_64-w64-
mingw32-gcc have the same file size, but they are not the same file.
Change-Id: I427d2ff36a33ffb045c71851c91312e129616f69
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This is not a limitation in practice, as the condition is very hard to
trigger.
Change-Id: Ibe89fbca6e789c61b896f1aac7a55958567cddb9
Reviewed-by: hjk <hjk@qt.io>
The observable problem:
- Create a qmake SUBDIRS project with e.g. two apps, or something
corresponding to that in a different build system.
- Add the same file to both sub-projects.
- Click on the file node for that file in the *second* sub-project
and select "Remove".
- Watch the file disappear from the *first* sub-project.
The underlying problem:
- Before the file is removed, there is a dialog asking the user
for confirmation.
- Afterwards, the code checks whether the currently selected node in
the project tree is still the one that was selected before.
- If it's not, then the node for that file path is re-retrieved from
the tree.
- However, after the dialog ran, there is no current node anymore,
presumably because the focus was taken away from the tree widget.
- As a result, the node we continue to work on is always the one
from the first sub-project, no matter which one the original
node belonged to.
The fix:
- Keep working with the original node if it's still in the tree.
Change-Id: I6c76ed96db9f55edbc7626c4ea99f166736707b8
Reviewed-by: hjk <hjk@qt.io>
Aspects are not completely orthogonal, e.g. working directory
depends usually on environment etc. So far handling this used
ad-hoc set up in the (Run)Configuration constructor. Lets make
this an official second phase, that also reduces the need to
use a specific construction order of aspects.
Change-Id: Ic98b7d4e1ac9d46a32ec624bbbbfbbc32a40ab32
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
The non-deletable toolchains are the ones coming from the SDK.
Amends 3969a007c2.
Change-Id: I9586e2311378417c72c2eb6b55e6d5e29c65fba3
Reviewed-by: hjk <hjk@qt.io>
A product is a project node from which a target binary is produced, such
as a Product item in qbs or a .pro file in qmake.
Change-Id: I6a0e6bed6c02684cb03b2b18fed6a1b493fa78b2
Reviewed-by: hjk <hjk@qt.io>
And realize that at most places (except native help viewer) the code
using them is not optional on macOS.
Change-Id: I308406a0e8f176dad4151d23a33cd3fc0fb8635c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
... from AppOutputPane to IOutputPane. We want to have filtering in
other output panes too.
Change-Id: I805ec68baedf491b71d392c3370dee78ed4ab76c
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
The old implementation sent the command over the wire as-is, so we
declared it as a QByteArray and let the caller choose the encoding. This
doesn't make sense anymore, as the command is now passed to an external
process as a QString anyway.
Change-Id: Ib84bc0f871db2b45b93f71d924c4177cc28d3bb0
Reviewed-by: hjk <hjk@qt.io>
Also added current source directory as public include directory.
Change-Id: I6a23e02b84be3fc5f29ac33ef8ccd7d70a48f494
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
If tests prints out non-XML data to stdout the XML parser gets
nuts and refuses to handle the result.
Ignore unexpected output as it will be printed out on the
command line view anyhow.
Task-number: QTCREATORBUG-22354
Change-Id: I96f453fadd834d21572080857c86d25b2d6f6aa9
Reviewed-by: David Schulz <david.schulz@qt.io>
for BUILD_PLUGIN_${NAME}. This is only used as the default for the CMake
cache, so only if you haven't run CMake before.
The disadvantage is that just changing the environment variable after
the fact will not change anything.
The advantage is that the CMake cache keeps reflecting the actual state,
which is great for ccmake, the UI in Qt Creator, and other configuration
tools.
Change-Id: I25448270c29afa31d240072f58f981b8776597f2
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
While at it use the same environment variable used for
Qmake or Qbs based project.
Change-Id: Ieefb4e1da4ce4155863b80a1b275b67e664273c6
Reviewed-by: David Schulz <david.schulz@qt.io>
To execute them you need - beside the former prerequisites -
either have boost installed installed at system level (UNIX)
or you must specify BOOST_INCLUDE_DIR as environment variable
otherwise the respective test will be skipped.
Change-Id: I6bd8472e554132ab05e58b56e3ccbd5e9dffada9
Reviewed-by: David Schulz <david.schulz@qt.io>
GoogleTest started using the term Test Suite for grouping
related tests and Test Case for general tests.
This patch adapts the visual strings as well as some
internal API which used the same terms.
This completes 6189745a3b.
Change-Id: I0307c10b8b5f8574f31a68ee4320732f3e829532
Reviewed-by: David Schulz <david.schulz@qt.io>
Not all members can be default constructed, so neither can this class.
Change-Id: I6e3593bdbb9905bc4fb39aaf7cc290e30dda8300
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
Filter out all interfering options and environment variables when
running tests.
Task-number: QTCREATORBUG-21169
Change-Id: I0cac36907d79aa74ac96873f868eb7a7a3666794
Reviewed-by: David Schulz <david.schulz@qt.io>