Disconnect from the WinDebugInterface instance, because every new
run control started will emit the same 'cannotRetrieveDebugOutput()'
signal again.
Change-Id: I94d591e0fa1664f7f7ca0ed4b1d9e021d23cd3e3
Task-number: QTCREATORBUG-5443
Reviewed-on: http://codereview.qt.nokia.com/2327
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
Do not increase the number of VCSes by readding the same entries when going
back/next on the summary page of the project load wizard.
Task-number: QTCREATORBUG-5519
Change-Id: I60058cf2060fae4e5703e77fe97a727108bbc8c8
Reviewed-on: http://codereview.qt.nokia.com/2283
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Robert Löhning <robert.loehning@nokia.com>
toolSelected() & toolDeselected are const methods in the base class.
But anyway the attach Action isn't used any more, so let's remove it
completely ...
Change-Id: Ia40cb6d927fb8422700816a8c6de81aa3734959d
Reviewed-on: http://codereview.qt.nokia.com/2324
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Fixes an occassional assert "Cannot send events to objects owned by a
different thread." with receiver QHelpEngineCorePrivate.
Change-Id: I77ffd663a055c493607907374f7a4d775f6aac6c
Reviewed-on: http://codereview.qt.nokia.com/2289
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
The use of QErrorMessage::qtHandle() installs a message handler
that from then on pops up a warning for each qWarning().
Change-Id: Iad6ac7b002ffc007de7df7a41c3ce0f9ee40e6d0
Reviewed-on: http://codereview.qt.nokia.com/2280
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
The destructor of QmlAdapter deletes the QDeclarativeDebugConnection,
which in turn results in status changes to the QmLJSInspectorClient. This
again leads to QmlAdapter::logServiceStatusChange() being called for the
already half-destructed object ... break this change by guarding the pointer
to QmlAdapter in QmlJSClientProxy.
Change-Id: I7ae3d45b2146b4f02e3843375ecf276ae75d5ea0
Task-number: QTCREATORBUG-5500
Reviewed-on: http://codereview.qt.nokia.com/2276
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Despite of '-k' passed to make, the 'all' target might still fail prematurely
because make doesn't forward the '-k' to sbs. Anyway, now that we
know the exact toolchain we can do better and only compile the
targets that fit to the toolchain.
If not Symbian, use the 'all' target everywhere, which ensures
we're both compiling debug and release versions of all helpers.
Change-Id: I0c3b699724472c8c2035d2c20bc451b47a301d1d
Reviewed-on: http://codereview.qt.nokia.com/2159
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alessandro Portale <alessandro.portale@nokia.com>
Actually the error message should ideally show up in Application Output, but
that would require a translation. Left for 2.4.
Change-Id: Ia13dc46bf82f28862ac38e830b241f4b23f83fa2
Reviewed-on: http://codereview.qt.nokia.com/2267
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
Instead of hiding the widget we move it accordingly.
Task-number: QTCREATORBUG-2958
Change-Id: I45deafab33ea928d4c4d6ff199ec542c1ee6ef3e
Reviewed-on: http://codereview.qt.nokia.com/2266
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
If no source is defined we set an empty source.
Before we took the source from the last image object which was
confusing.
Task-number: QTCREATORBUG-2714
Change-Id: If9535ffa4dc7abe0767d8aee5629c46de4df9825
Reviewed-on: http://codereview.qt.nokia.com/2265
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
Fix the RunControl so that it uses the right address & port for
connecting to the running app.
Task-number: QTCREATORBUG-5607
Change-Id: Ia8c76740fe6c7d67f8c5bcaac6416a08dcb7774d
Reviewed-on: http://codereview.qt.nokia.com/2199
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christian Stenger <christian.stenger@nokia.com>
One can already build debugging helpers for Qt Versions not yet
registered to QtVersionManager - which resulted in a QTC_ASSERT
+ the changes after the built were not picked up.
Change-Id: I12a769df6e18a05b0d1677fd913f4064efed3429
Reviewed-on: http://codereview.qt.nokia.com/2168
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
For some reason using push buttons in the status bar will make
the clickable area of the buttons too small (half of the button isn't
clickable). Using QToolButtons instead.
Task-number: QTCREATORBUG-4513
Change-Id: I8b0f97552ec9b2471d570d577522b7ce5f382fb9
Reviewed-on: http://codereview.qt.nokia.com/2193
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
Reviewed-by: Daniel Molkentin <daniel.molkentin@nokia.com>
Fix rendering issues in the build step lists display of the project
mode: The label got dropped from the layout.
Never drop the widgets from the layout to avoid this issue:-)
Change-Id: I912a8b6d78537f0c395c2bc440387b20b66a4584
Reviewed-on: http://codereview.qt.nokia.com/2126
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
The dialog is always hidden by the time the tracking state is queried,
so all new branches were done in non-tracking mode.
Change-Id: I11cdbec6af1c756c1449d68a2efeb31a1c5bd0ec
Reviewed-on: http://codereview.qt.nokia.com/2196
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@nokia.com>
