Commit Graph

252 Commits

Author SHA1 Message Date
Oswald Buddenhagen
b2ae433a58 centralize exec-continue calling and error handling 2009-10-20 14:08:59 +02:00
Oswald Buddenhagen
ad092d11d5 re-add debug-in-terminal in form of a new gdb adapter 2009-10-20 11:26:55 +02:00
Oswald Buddenhagen
3dc1e31deb fix initial breakpoint setting
as it turns out, it is not possible to set pending breakpoints until
gdb has loaded as image. so add some hooks to enable adapters to trigger
the initial breakpoint syncing at the right time. do not add additional
states (say, InferiorPreparing), as it would just complicate things.
2009-10-20 11:26:55 +02:00
Oswald Buddenhagen
b3addf14f1 fix shutdown paths
this includes:
- move the gdb ownership back to the engine (thus strip down the
  adaptors as far as possible)
- make gdb startup synchronous
- make adapter shutdown synchronous
- fix the state transitions relating to shutdown
2009-10-20 11:26:55 +02:00
Oswald Buddenhagen
de9b4e8365 centralize setting of AdapterStarted state 2009-10-20 11:26:55 +02:00
Oswald Buddenhagen
0e398303cc remove dead code 2009-10-20 11:26:55 +02:00
Erik Verbruggen
074d477fb0 Got the gdb engine to compile on Mac.
Reviewed by: Friedemann Kleint
2009-10-16 17:08:51 +02:00
Friedemann Kleint
25ee70bb24 Debugger: Use the code model to detect unitialized variables.
This should save debugger round trips and crashes in the debugging
helpers.
Add respective option to debugging helper option page, defaulting to
true.On this occasion, make CDB detect shadowed variables correctly
and display them as "<shadowed n>" as does the Gdb engine by
reversing the direction in which
CdbSymbolGroupContext::populateINameIndexMap works.
Rubber-stamped-by: hjk <qtc-committer@nokia.com>
2009-10-16 16:26:28 +02:00
hjk
25d75c7f90 debugger: allow fancy/non-fancy mode for new dumpers 2009-10-16 11:13:19 +02:00
hjk
73aa3e2164 debugger: make parsing of new dumper outpuit a bit more robust 2009-10-16 11:13:19 +02:00
hjk
fa71a4879c debugger: work on autotests 2009-10-14 10:02:07 +02:00
Oswald Buddenhagen
af3a387b5f do not attempt to load dumpers until the inferior is fully initialized
specifically, this will skip the initial stop at _start when using the
terminal and remote adapters.
2009-10-13 20:43:13 +02:00
Oswald Buddenhagen
70f696d056 -gdb-exit has a special return code as well 2009-10-13 20:43:13 +02:00
Oswald Buddenhagen
b27093c07d fix state machine surrounding spontaneous stops 2009-10-13 20:43:13 +02:00
Oswald Buddenhagen
d1783e0974 fold preparing inferior into starting inferior
after refactoring the trk adapter startup, the split was not necessary
any more. in fact, it seemed fairly arbitrary at this point.
2009-10-13 20:43:12 +02:00
Oswald Buddenhagen
9aaa953245 reorder instructions for readability 2009-10-13 20:43:12 +02:00
Oswald Buddenhagen
a2cc84194f remove dead code 2009-10-13 20:43:12 +02:00
Oswald Buddenhagen
7782e26ae6 comment out handleExecRunToFunction()
it is currently unused. do not just remove it, as hjk says he wants to
revive it.
2009-10-13 20:42:11 +02:00
Oswald Buddenhagen
973f607e64 centralize entering the InferiorStartFailed state 2009-10-12 18:52:15 +02:00
Oswald Buddenhagen
a1a8f6adcb centralize gdb command result class checking
each command can have only one of two legitimate responses: "error" or -
depending on the command, and thus declared via a flag - "done" or
"running".
this is way nicer than sprinkling the code with else-ifs (where elses
are sufficient) and asserts all over the place - and silently failing in
release builds.
2009-10-12 14:56:35 +02:00
hjk
7e3d954195 debugger: work on a "synchroneous" mode
For the case that gdb can give all the interesting data in one go.
2009-10-12 14:51:23 +02:00
Oswald Buddenhagen
8e6d25d14a centralize gdb comm log queuing
this drastically improves the usefulness of the debugger output window
by making internal and external messages appear in sync.
2009-10-09 16:36:58 +02:00
Oswald Buddenhagen
9ae0575ae2 add central GdbEngine::handleInferiorPidChanged()
fixes build
2009-10-09 13:39:27 +02:00
Oswald Buddenhagen
1610c14d22 make direct call of handleStop1() more elegant 2009-10-09 13:01:51 +02:00
Oswald Buddenhagen
b84d2f32c7 micro-optimization
don't evaluate expression for possible reset if the variable is already
unset ...
2009-10-09 13:01:50 +02:00
Oswald Buddenhagen
21314b78d9 rename handleAsyncOutput() => handleStopResponse() 2009-10-09 13:01:50 +02:00
Oswald Buddenhagen
e0f4c4bcee =thread-group-created are the new process creation notifications 2009-10-09 13:01:50 +02:00
Oswald Buddenhagen
8fdf9e61bf remove "stopped" which is immediately followed by "processing queued..." 2009-10-09 13:01:50 +02:00
Oswald Buddenhagen
0eca150031 debug output: don't claim "continuing after temporary stop" if we are not 2009-10-09 13:01:50 +02:00
Friedemann Kleint
22ab8d5662 Debugger: Do configuration error checking early on.
Add a configuration checking method to the Debugger manager,
depending on toolchain, wire it to the engines.
Check that in the debugger run controls.

Add a convenience method to ICore that shows a warning
message with a "Settings" button, pointing the user
to a configuration error on a settings page.

Remove leftovers of the dumper parser.
Acked-by: con <qtc-committer@nokia.com>
2009-10-08 17:23:27 +02:00
hjk
c6de8d457b debugger: fix pid parsing on mac 2009-10-08 16:14:51 +02:00
Oswald Buddenhagen
aa97f43a92 rename m_continuationAfterDone => m_commandsDoneCallback for clarity 2009-10-08 12:43:48 +02:00
Oswald Buddenhagen
ccf4fe9a5f use gdb's target stream output
at least in theory, this is the output of a remote debuggee
2009-10-08 12:18:03 +02:00
Oswald Buddenhagen
c951e5b605 reset output converter state again 2009-10-08 12:18:03 +02:00
Oswald Buddenhagen
1d6da5044d move the output collector to the plain gdb adapter
doesn't make sense anywhere else
2009-10-08 12:18:03 +02:00
Oswald Buddenhagen
7313f3d666 don't instanciate all adaptors at once 2009-10-08 12:18:03 +02:00
Oswald Buddenhagen
51a22cbe7c centralize STRINGIFY definition 2009-10-08 12:18:02 +02:00
Friedemann Kleint
81a8f2f927 Debugger: Improve adapter error handling
Correctly reset state on missing Symbian gdb.
Provide "settings" options.
Reviewed-by: hjk <qtc-committer@nokia.com>
2009-10-08 11:43:26 +02:00
Daniel Molkentin
b262472973 Centralize S60 check, also use it for adding the GDB TRK page. 2009-10-06 14:43:05 +02:00
hjk
06abe6b813 debugger: fix frame switching when using core files 2009-10-06 11:06:34 +02:00
hjk
d130588469 debugger: add option to automatically derefence pointers in locals&watchers 2009-10-06 10:54:08 +02:00
hjk
babe027d9f debugger: update registers when switching stack frames 2009-10-06 10:17:51 +02:00
hjk
5e7a26d863 debugger: rework fetching of memory from device
still a few cases for chunked fetching missing
2009-10-06 10:17:51 +02:00
hjk
13212eef14 debugger: work around Apple gdb-1344 problem 2009-10-05 12:06:29 +02:00
hjk
75529d87d3 debugger: rework 'jump to source' logic 2009-10-05 12:01:23 +02:00
hjk
d22438e9bd debugger: add some debug output when disassembler view fails to retrieve the
base address
2009-10-05 09:19:03 +02:00
hjk
5ab3be8cc4 debugger: handle failure of -exec-step gracefully if debug information is
missing.
2009-10-05 08:56:02 +02:00
hjk
5a73440b18 debugger: fix gotoLocation() on Mac
Mac's "stopped" message does not come with location data.
2009-10-02 14:32:44 +02:00
hjk
7e005752a7 debugger: code cosmetics 2009-10-02 14:32:43 +02:00
hjk
99bdc54199 debugger: small tweaks to gotoLocation() 2009-10-02 12:31:59 +02:00