Nicolas Arnaud-Cormos
9b19a9c8e2
Analyzer: refactor global and project tool settings usage.
...
IAnalyzerTool has now 2 new virtual methods used to create the global and per-project settings.
No need to create any static factory method and pass a pointer to them to the AnalyzerGlobalSettings
instance anymore.
The Valgrind plugin is now using it, the memchecktool creates the settings for all
valgrind tools.
Change-Id: I3c5845ceb7151130032cfff4ab5b7b36ca2459d9
Reviewed-by: hjk <qthjk@ovi.com >
2011-12-28 18:26:12 +01:00
Nicolas Arnaud-Cormos
4a8432112a
Analyzer: create a run control factory for all tools.
...
Having one factory per tool (or plugin) created some bugs:
* analyzer project settings being created twice
* per-project analyzer settings widget duplicated
Also, most of the code from the run control factory were copied.
Now, the Analyzer only creates one run control factory shared among all tools, and the IAnalyzerTool
has two new virtual method: canRun and createStartParameters. It simplify the code a bit, and
creating a new analyzer tool is easier (only two classes to subclass: IAnalyzerTool and IAnalyzerEngine).
Change-Id: I4e180846a26b74b2b77cb99bc97534d680a80a4d
Reviewed-by: hjk <qthjk@ovi.com >
2011-12-28 18:25:56 +01:00
Nicolas Arnaud-Cormos
1571b7f977
Analyzer: no need to pass a start mode when it's implicit in the name.
...
startRemoteTool and startLocalTool are implcicitely working remotely and localy, they don't need a mode.
Change-Id: I433ca421f68a1026979489c7f9d86b12251ec830
Reviewed-by: hjk <qthjk@ovi.com >
2011-12-28 12:06:39 +01:00
hjk
8e236db9f5
mostly core and analyzer: more id-fication
...
Change-Id: Ic794fdc6a582f4a03d84b6220c59111044c753b9
Reviewed-by: hjk <qthjk@ovi.com >
2011-11-15 18:25:19 +01:00
hjk
31600758de
all: s/info@qt.nokia.com/qt-info@nokia.com/
...
Change-Id: If18afb5d4665924e7d9250dccbc60a65e6daa75e
Reviewed-by: Eike Ziller <eike.ziller@nokia.com >
2011-11-03 10:33:19 +01:00
hjk
3cce72dcf5
analyzer: merge valgrind related settings
...
This mainly reduces the number of tabs in the settings dialog.
Change-Id: I62ba5c74585648c8f495602cd4d676d0628de9b5
Reviewed-on: http://codereview.qt.nokia.com/1575
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com >
Reviewed-by: Eike Ziller <eike.ziller@nokia.com >
2011-07-13 15:56:48 +02:00
hjk
7a50c47f51
display: simplify AnalyzerStartParameters
...
Change-Id: Ibc9db3d7de96461b097d1a78e1bcfd757458fc99
Reviewed-on: http://codereview.qt.nokia.com/1205
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com >
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com >
2011-07-06 12:01:18 +02:00
hjk
26a4e55842
Revert "Valgrind: fix compilation"
...
This reverts commit b1faac0e73http://codereview.qt.nokia.com/1095
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com >
Reviewed-by: hjk <qthjk@ovi.com >
2011-07-05 12:09:59 +02:00
hjk
be452fcaff
Revert "analyzer: move convenience factory back to base plugin"
...
This reverts commit 06a41da04ehttp://codereview.qt.nokia.com/1094
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com >
Reviewed-by: hjk <qthjk@ovi.com >
2011-07-05 12:09:25 +02:00
Christiaan Janssen
b1faac0e73
Valgrind: fix compilation
...
Change-Id: Id82d6e772b326ea9a59a713a8de8af4a616283da
Reviewed-on: http://codereview.qt.nokia.com/1089
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com >
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com >
2011-07-04 17:48:56 +02:00
hjk
06a41da04e
analyzer: move convenience factory back to base plugin
...
Change-Id: Ife82b74ce4b457dd9e6a6cc3749cb629aeeacf58
Reviewed-on: http://codereview.qt.nokia.com/1086
Reviewed-by: hjk <qthjk@ovi.com >
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com >
2011-07-04 16:23:38 +02:00
hjk
36a3028b9d
analyzer: refactor progress
...
Change-Id: If74c8035bc83a8113c2a15dcacefa38afbbbb4d8
Reviewed-on: http://codereview.qt.nokia.com/1056
Reviewed-by: hjk <qthjk@ovi.com >
2011-07-04 12:02:36 +02:00
hjk
f0a0e5b1ea
analyzer: move responsibility for run modes to individual tools
...
Change-Id: Iaf2fa9d4c087470649336a453c6a9a7db12d220f
Reviewed-on: http://codereview.qt.nokia.com/1051
Reviewed-by: hjk <qthjk@ovi.com >
2011-07-04 12:01:25 +02:00
hjk
99d9f065b3
analyzer: refactoring of analyzer manager
...
Change-Id: I60268b8bc86e439beb3fca8f4b6a87ea03925bad
Reviewed-on: http://codereview.qt.nokia.com/1049
Reviewed-by: hjk <qthjk@ovi.com >
2011-07-04 12:01:00 +02:00
hjk
8bb99e4c75
analyzer: merge valgrind based tool plugins
...
It is hard to imagine there is a real use case that someone wants one but
absolutely not the other.
Change-Id: I58bb57912f2edeacf2d5a24e3b2eb5a81262eabd
Reviewed-on: http://codereview.qt.nokia.com/66
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com >
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com >
2011-05-23 13:55:11 +02:00
