Commit Graph

21 Commits

Author SHA1 Message Date
hjk
23149b27ab Utils: Introduce variantFromStore and storeFromVariant
These are functional replacements for
  QVariant::fromValue(QVariantMap) (or QVariant::fromValue(Store)) and
  QVariant::toMap() (or QVariant::toValue<Store>())

We will have a few code paths in the end that need to explicitly
operarate on both QVariantMap and Store (e.g. actual reading/writing
to keep format compatibility etc), so these can't in the end be
simple to/fromValue(OneType) but need an internal 'if' or such.

Change-Id: I954f3cb24fa8fe123162b72bbd25d891dd19b768
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-28 11:16:40 +00:00
hjk
8d0aa34bfc Plugins: A bit more Keys and Store
Change-Id: Iee55eeaa881dd9f2047fdbe95ad8d827f4ba34e0
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-25 08:00:02 +00:00
hjk
ec7abcf98c Utils: Make FilePathAspect::setDefaultValue take a QString
This sets the unexpanded value, so going to a "cooked" FilePath can
at least theoretically break. On the user side it saves a
roundtrip in a few cases, but is more ugly when the input is already
a proper FilePath.

Change-Id: I8a7e8f6d46fcc34c96b55e41d656dca933fbef4e
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-17 11:58:41 +00:00
Marcus Tillmanns
ec4c85bab4 Copilot: Enabler readSettings workaround
readSettings does not trigger signals when values change, so
other aspects that have setEnabler set will not realize that
the enablers changed and possibly not update.

Calling setEnabler after read settings ensures that the correct
value is used.

Change-Id: Ifff3ff13d9c78e16bddf8032b891a5004a035496
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-17 04:42:55 +00:00
Marcus Tillmanns
ae51ad8c92 Copilot: Move to Settings::setLayouter()
Change-Id: I1d7d9872f12aa5436f03107bdd5fedfbe2829700
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 06:55:06 +00:00
Marcus Tillmanns
f2d62c6d91 Copilot: Add support for proxy settings
For easier testing a docker file is added. You can start
"buildandrun.sh" in copilot/tests/proxy to get a simple
proxy server up and running. The argument "PWDMODE" in
buildandrun.sh can be set to "with" and "without" to get
a proxy server that needs a password or not. The username
and password are user/1234.

Fixes: QTCREATORBUG-29485
Change-Id: I3859c9ad04ebd4f9349e25665ba710e23fb64dea
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
2023-08-16 06:54:54 +00:00
Burak Hancerli
98e24a199f Copilot: Fix the broken link in the settings page
Change-Id: Iabedbbd1cc4c3371bd5351e434918e8368705daf
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-08-01 12:46:27 +00:00
hjk
7d08f96da5 Utils: Remove AspectContainer ctor's parent parameter
Instead use setParent in the two cases that use it. The parent gets
in the way when attempting to derive AspectContainer from BaseAspect.

Change-Id: I6079beb0e00334133da115b714bc5186064c6722
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
2023-07-28 12:24:04 +00:00
hjk
3bfd60b708 Copilot: Move AuthWidget update to the class itself
Change-Id: Iab23566c6d74760eab732fdbad2d9eac645faaff
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-14 14:39:30 +00:00
hjk
17267bb15c Copilot: Move closer to latest settings setup and usage pattern
Change-Id: I86983f55cd53a540e2fe1a5b307ebf67f7ea7a98
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-07-14 14:39:06 +00:00
Eike Ziller
26e96bfad8 Merge remote-tracking branch 'origin/11.0'
Conflicts:
	src/plugins/debugger/debuggeritemmanager.cpp

Change-Id: I9d99d13feff9315f52eacbd84857c63cb69bf804
2023-07-03 10:24:09 +02:00
hjk
98bba063b6 Utils: Use FilePathAspect::setDefaultValue
... instead of StringAspect::setDefaultFilePath.

Closer to the intended uniform access.

Task-number: QTCREATORBUG-29167
Change-Id: I87df385ef98873a0955010149a9a9b09a5f29daf
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-06-30 09:34:26 +00:00
Marcus Tillmanns
bb6a53240e Copilot: Additional search path for vim plugin
Fixes: QTCREATORBUG-29335
Change-Id: Ib86dc2dc5e4f0df8188dc8e4351f7117cc73710a
Reviewed-by: David Schulz <david.schulz@qt.io>
2023-06-29 13:20:40 +00:00
hjk
379e7f906e Utils: Rework aspect implementation
This avoids some repetition and could be a step towards
having type storage in (or rather accessible from) the base,
so we can have aspects for more complex data (treemodels...)
that are not easily converted to QVariant.

Change-Id: I9797b3d5646195705212db1830d2b415291ac651
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
2023-06-29 11:25:44 +00:00
hjk
c9521b294f Copilot: Disable by default also in the settings
... and make the enabling more prominent.

Change-Id: I77e236a1aec2d3ced3280aa8af322a02b8a14dd1
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-06-23 07:12:33 +00:00
Leena Miettinen
0b5123cd74 Copilot: Fix UI text
- Change an external link to point to the English language version
- Fix capitalization of product names
- Add a period to the end of a tooltip

Change-Id: Ia46709db9911c0a3bfad252db2ffe0b3f7e5f2d7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
2023-05-31 07:00:44 +00:00
Marcus Tillmanns
bdb31d4348 Copilot: Allow user to disable Copilot
Fixes: QTCREATORBUG-29179
Change-Id: I274de1f13f773fb61b376643b61056b6f14dabaf
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
2023-05-26 12:55:57 +00:00
hjk
b47df2a304 Copilot: Register settings aspects more directly
Also simplify a search.

Change-Id: I2ba511ca3250c624fb7dbc2b44f845a5757e72ce
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-05-26 09:00:48 +00:00
hjk
95d21f3966 Use new FilePathAspect in a few more places
Change-Id: I910a802255c8d54a31313dcccb0d1a48ec577b7a
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
2023-05-17 11:22:48 +00:00
David Schulz
afcbe845ce Copilot: Add setting for automatic completion
Can be used to turn off the automatic completion insertion, so a user
only can request suggestions explicitly via the shortcut.

Change-Id: I0c4d9e2f41d30312b0870facdd80dc1d3d03d809
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
2023-04-24 10:07:21 +00:00
Marcus Tillmanns
625f0ef726 Copilot: Add LSP plugin for Copilot
Fixes: QTCREATORBUG-27771
Change-Id: I1249b9a4492427208a70b3e21bf20ac668fc3c50
Reviewed-by: hjk <hjk@qt.io>
2023-02-21 10:26:12 +00:00