Avoid flooding logging messages by default and let the user enable
them explicitly.
Change-Id: I9f8fe044a460309e4462a5d88bd12a0ab6088731
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This information is re-used inside the System Information dialog.
Change-Id: I71d2b9a1574ea1cd3f68349d974555ec5625f185
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
When Locator shows long file paths, showing last part of path more can be
useful.
For example, if we search "qtcreator.png" in Qt Creator,
it shows eight QtProject-qtcreator.png paths in separate directries.
QtProject-qtcreator.png qt-creator/src/plugins/coreplugin/images/...
QtProject-qtcreator.png qt-creator/src/plugins/coreplugin/images/...
QtProject-qtcreator.png qt-creator/src/plugins/coreplugin/images/...
...
This patch improves as below.
QtProject-qtcreator.png qt-creator/src/.../128/QtProject-qtcreator.png
QtProject-qtcreator.png qt-creator/src/.../16/QtProject-qtcreator.png
QtProject-qtcreator.png qt-creator/src/.../24/QtProject-qtcreator.png
...
Change-Id: I2c796026f1ba123870000c28556e775831a438df
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Remove setCreateProcessArgumentModifier() from the ProcessInterface
API and replace it with belowNormalPriority flag.
Change-Id: I6bcb92e56c3a68af7fa3e3a1c8b8eb13e3a2e5a7
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
Don't connect updateFilterButton() to the
QStackedWidget::currentChanged(). Call updateFilterButton()
explicitly by the end of setCurrentIndex().
Fixes: QTCREATORBUG-26099
Change-Id: I7cba97346e1f6c73171a9b83381e271750d50f25
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Manually editing the path inside a PathChooser will trigger some
validation and may end up in constructing some invalid paths
but still marking them as valid.
Beside this it will make the cursor jump to different locations
while typing which ends up in creating even more incorrect paths.
So, avoid creating invalid paths and mark the resulting path
as invalid if it is.
Change-Id: I27f55ae03745474fc6b91c44cdbc307c581fb2f8
Reviewed-by: hjk <hjk@qt.io>
This patch needs to be applied together with the parent change.
There are 3 basic cases:
1. The user doesn't write anything to the write channel:
You don't need to call closeWriteChannel manually anymore.
By default the QtcProcess you create is in ProcessMode::Reader mode.
Internally it opens the process in ReadOnly mode and
closes the write channel just after starting.
2. The user writes some initial data (after being started)
and then closes the write channel:
All what is needed now it to set the write data
(QtcProcess::setWriteData) before calling start.
You also use the default ProcessMode::Reader mode.
Internally it opens the process in ReadWrite mode
and writes the writeData asynchonously when the process
already started. After writing the data it closes the
write channel automatically.
3. The user writes the data also after calling start.
All you need now is to create a process with
ProcessMode::Writer mode. In this mode the write
channel is not closed.
Internally it opens the process in ReadWrite mode
as some writers also read the data from the process.
All the code base is adapted here to the above rules.
Change-Id: Id103019d1d71a3012fd1eade226fe96b9aaa48c2
Reviewed-by: hjk <hjk@qt.io>
Only modify device letter if it appears to be one.
Do not touch capitilization when fixing.
Amends b6dd53d4ed.
Change-Id: I55203eb14bc78d551dd4d88cd2a4e3efac3d816e
Reviewed-by: hjk <hjk@qt.io>
When working with make wrapper scripts, sometimes they forward
everything to stdout. When this happens failures are not parsed,
and the are not "clickable" in QtC.
This patch adds an option to enable parsing of standard output.
Change-Id: I44b283dbdf6286f90c546898d496bff41de0d5ed
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
... in tooltip of debugger path lineedit.
Helps with cases where necessary libraries are missing.
The tooltip is a bit hard to recognize, but as such cases now also
are marked in red text there's at least some direct hint that something
is not ok.
Change-Id: Ic5da8dcb1921a98f91f6eed755fa87ce5feed698
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
... and let the fallout trickle down a bit.
Change-Id: I1a2f79e281725c4a121cc2fbbc0377e881616ce5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Try to mimic the behavior of QProcess inside process launcher
as much as possible. After calling QtcProcess::kill() we send
StopProcessPacket to the process launcher - when we receive
it there we start reaping of the process itself and report
back the finished packet with a failure.
Remove canceled state from the LanucherHandle, as after
canceling the process we still need to handle the finished
(or others) signals - like in case of QProcess.
Change-Id: Id66b06449de06675a0ab6778e93e9782afea09d4
Reviewed-by: hjk <hjk@qt.io>
In my case astyle returns "Artistic Style Version 3.1" and
it didn't want to match.
Change-Id: Ie3bee186cb39d29f11fa1add2f99c87d5fd67842
Reviewed-by: hjk <hjk@qt.io>
This will remove the warnings for examples that setup only
the C++ compiler, or when configuring QML debugging.
Amends 1bf9900aed
Change-Id: Ica9361114be420b81f611f5d498d87949399e8b4
Reviewed-by: hjk <hjk@qt.io>
Instead of waiting for certain state we wait for
certain signal to be placed into the buffer.
No need for m_finished flag anymore, since we are
only interesting if the buffer contains the finished
signal. This will enable to implement waiting for
ready read properly, since no state is changed
in this case.
Change-Id: I4209da385b2e37de6f1897357e35c0ed0c9e4096
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Amends 11a40e02f2.
Environment::searchInPath only works for local setups, the
remote replacement is FilePath::searchOnDevice.
Change-Id: I8a2ba51903d3308ca9198fbf1154779c78e69e63
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
If there is no filter accept all instead of nothing.
Fixes e.g. ABI detection on docker image running
on Windows.
Change-Id: I17588f71018952b1087b5b8f700b6c158bf5b89d
Reviewed-by: hjk <hjk@qt.io>
A negative index was ignored before, but ::slide
now throws more aggressive.
In any case -1 means there is no item and that no slide is required.
Task-number: QDS-4796
Task-number: QDS-4601
Change-Id: Ief7f597e4d430652c2b18e6af3bc187c4c4e28a6
Reviewed-by: Marco Bubke <marco.bubke@qt.io>
