... when renaming symbols.
Otherwise, the server might return an empty list of results, as renaming
a symbol to itself is a no-op.
Change-Id: I9ca808c4032458c9a2eec262feadd28212938c23
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This synchronizes JSON files used by unit tests with files
in QtMCUs repo. To do that some changes in code were needed.
QtMCUs package is no longer created for each JSON file. Because of
its nature it's created once and passed to each target.
Unit tests now have verifyPackage function to avoid duplication
of checks.
In test creating target QtMCUs package is checked beside toolchain
ones.
Change-Id: I5dea470daf184b45facfaaa793c359310ac22fc1
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Yasser Grimes <yasser.grimes@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Do not continue dumb after setting break points. If the location
we are located at while setting the break points is a break point
we have to stay there interrupted.
Change-Id: Ic0496ea3f2d8ea1d4eab6f3cdbd04c9dbf17bb72
Reviewed-by: David Schulz <david.schulz@qt.io>
It's too late, and apparently "close-without-open" is triggered:
QDEBUG: tst_fsengine::testRootPathContainsFakeDir() SOFT ASSERT: "m_tempStorage" in /data/dev/creator/src/libs/utils/fsengine/fsengine_impl.cpp:64
QDEBUG: tst_fsengine::testListDir() SOFT ASSERT: "m_tempStorage" in /data/dev/creator/src/libs/utils/fsengine/fsengine_impl.cpp:64
Change-Id: Ic7100d7abddfffca909b412ea7ea19e295c86729
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
The view manager has dependencies on many components so it should be
part of the componets core.
Change-Id: I68d233ca51625f38ed6c30601ec630782dcdf487
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
We apply not very often the parent to views. So it can lead to dangling
pointer if the parent is used by other objects and does not handle the
null pointer case. It can lead to double deletion if the parent is
deleted before the object when it is on the stack or handled by smart
pointer.
If you really want to use it there is still setParent.
Change-Id: I1fc6b145a50f037a0e9d415fb36e7970ea7296ed
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Many validation tests can now be skipped.
Task-number: QDS-7454
Change-Id: I447e106d1b5deb3af92046c6ee8907341c7d5220
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Many checks are not anymore need so we can just remove the code and make
it clean what we want. Use the filtered algorithm to remove some loops.
We add Utils::filteredCast to algorithm.h to return a different result
container and let it be cast in std::copy_if.
Change-Id: I114c17cd2d5a69c9ebbfbd804805c4d2fa0599e1
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Many validation tests can now be skipped.
Task-number: QDS-7454
Change-Id: I9c93498b96c1f1facd72a98d58751d3ad031c483
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Many validation tests can now be skipped.
Task-number: QDS-7454
Change-Id: Icfdf53cbf02a08e8922258b4bd93ebb4cf3d2e64
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Many validation tests can now be skipped.
Task-number: QDS-7454
Change-Id: I84d5330d2666968eec757f70eceb73b45ce72383
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Many validation tests can now be skipped.
Task-number: QDS-7454
Change-Id: I04a800edab774604d825d53a368d05b8520f9e22
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Many validation tests can now be skipped.
Task-number: QDS-7454
Change-Id: Idb93b565415ea715db143b292988679c221b2a5a
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
From cppreference:
internal linkage
The name can be referred to from all scopes in the current translation
unit.
Any of the following names declared at namespace scope have internal
linkage:
* variables, variable templates (since C++14), functions, or function
templates declared static;
* non-volatile non-template (since C++14) non-inline (since C++17) non-
exported (since C++20) const-qualified variables (including constexpr)
(since C++11) that aren't declared extern and aren't previously
declared to have external linkage;
* data members of anonymous unions.
Change-Id: Ibbd7c3925ead59879039d4b266ebfda548c68744
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
TO save space and make material names clearer.
Change-Id: I1cea8787ca03a37adca6e4a0f352732d50bc1b40
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Used in assetImporter plugin
Task-number: QDS-7652
Change-Id: I2caff28f6a9effbcb2312f120f2ccdc2d0a82a86
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
When apply a material from the material bundle directly to a model in
the 3D scene, check frist if there is an existing material that has no
properties set, if so apply it instead of creating a new instance.
Also few tweaks.
Change-Id: I4ddadfd84442164b671645af5e4f5d9e8dcb7cb0
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
The CppSourceProcessor initially expects the "<per-editor-defines>"
pseudo-file in the working copy and then puts the resulting document into
the snapshot. Therefore, if we reset the snapshot, we must put the data
back into the working copy.
Fixes: QTCREATORBUG-22584
Change-Id: I4e3fd0647cc35327a2e72547c81c4edc16a670b2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This is a preparation step before making diff showing more
interactive.
Change-Id: I149b76466c3ccce05d823bac91fe89ac806b9130
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Instead of providing a message box with unrelated information
just refuse the run and inform the user about this.
Change-Id: Ia6feb835dd5d4876abc85d186faf0abe89e5a47f
Reviewed-by: David Schulz <david.schulz@qt.io>
Information is fetched anyhow and we need it later on.
Change-Id: I6389c183b584b312559ca44d2fdda856e6315583
Reviewed-by: David Schulz <david.schulz@qt.io>
These settings should be usable for more than just the
settings page.
Change-Id: I5150601405163327290808127d761438e57794a3
Reviewed-by: David Schulz <david.schulz@qt.io>
Apparently we can't rely on code model picking up the import addition
in all cases, so always do code model reset if a new material is
imported from bundle.
Fixes: QDS-7750
Change-Id: Idba05cd9ce0af4165cb933515ada8ed7bd3f64c9
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Deleting is now made the same way as deleting a selected node, so
dangling references to the deleted material are removed.
Fixes: QDS-7716
Change-Id: I552c328eb928bfc20e3e33caa0e817f6d22162cc
Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
